Invoke JUnit assertEquals with Argument Order (expected, actual)
The JUnit API documents assertEquals as taking the expected argument
before the actual argument. Failure to adhere to this can result in
very confusing test failure messages.
For example in testTransformOneValue 'old' contains 'A' and 'expected'
contains 'a'. If the implementer does not lower-case the key, the
failure message is as follows if the argument order is
(actual, expected):
EtlTest > testTransformOneValue FAILED
java.lang.AssertionError: expected:<{A=1}> but was:<{a=1}>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at EtlTest.testTransformOneValue(EtlTest.java:27)
This is very confusing as "was:<{a=1}>" is exactly what we were hoping
the result would be.
Issue #152: Made simple-cipher more approachable (#224)
* Issue #152: Made simple-cipher more approachable by splitting test classes in a more sensible way and making clear which steps they relate to.
* Changed SimpleCipherTest to use the junit Rule annotation for expected exceptions. Changed variable names in SimpleCipherTest to be more descriptive and moved the test cipherThrowsWithEmptyKey from step three to step two.
* Added HINT.md which explains how to run only one test class.
* Changed HINT.md in simple-cipher to refer to the actual test file names and not to contain the same information as in SETUP.md
Issue #166: Added format string to @Parameters annotation in Scrabble… (#222)
* Added format string to @Parameters annotation in and (to make them more descriptive) changed names of variables and tests in:
* AtbashTest,
* BinaryTest,
* OctalTest,
* PigLatinTest,
* RaindropsTest,
* RomanNumeralsTest,
* ScrabbleScoreTest.
* Removed repeated word in format string for PiglatinTest and ScrabbleScoreTest.
Fixes #160.
Fixes #161.
Fixes #162.
Fixes #163.
Fixes #164.
Fixes #165.
Fixes #166.
Without this instruction, the system continues to use the default OpenJDK. This is confusing since we instruct the practitioner to install Oracle's JDK.
Issue 202: Replaced assertj assertions in simple-linked-list with junit and hamcrest assertions. Removed assertj from simple-linked-list gradle build file.
Issue #200: Replaced assertj assertions in nucleotide-count tests with junit and assertj assertions. Removed assertj from nucleotide-count gradle build file. Added extra hamcrest library to nucleotide-count gradle build file to be able to use hasEntry for maps.
Stuart Kent
FridaTveit
Colin Mullikin
Colin Mullikin
John Ryan
Frida Tveit
Nigel Perkins
Stuart Kent
Dmitry Noranovich