#32 lab_fundamental

Open
mexiliang wants to merge 1 commits from mexiliang/ZCW-Lab-Fundamental-Methods:master into master
There is no content yet.
nhu313 commented 6 years ago
Owner

Good job on the MathUtilities and PredicateUtilities.

For the string utilities, a few comment. You don't have to call String.format unless there is a format you want, like padding space. So for these methods, you can return the string and concatenate it without calling format.

    public String getHelloWorld() {
        return "Hello World";
    }

    public String concatenation(int firstSegment, String secondSegment){
        return firstSegment + secondSegment;
    }

For getSuffix, what we're expecting is the last three character, that means return input.substring(input.length() - 3);

Please finish up the homework.

Good job on the MathUtilities and PredicateUtilities. For the string utilities, a few comment. You don't have to call `String.format` unless there is a format you want, like padding space. So for these methods, you can return the string and concatenate it without calling format. ``` public String getHelloWorld() { return "Hello World"; } public String concatenation(int firstSegment, String secondSegment){ return firstSegment + secondSegment; } ``` For getSuffix, what we're expecting is the last three character, that means `return input.substring(input.length() - 3);` Please finish up the homework.
This pull request can be merged automatically.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.