#29 chitraBegerhotta

Открыто
chitraBegerhotta хочет смерджить 1 коммит(ов) из chitraBegerhotta/CleanCode-GildedRoseKata:master в master
2 измененных файлов: 58 добавлений и 40 удалений
  1. 54
    36
      Inventory.java
  2. 4
    4
      package.bluej

+ 54
- 36
Inventory.java Просмотреть файл

@@ -1,39 +1,57 @@
1 1
 
2 2
 public class Inventory {
3
-    private Item[] items;
4
-
5
-    public Inventory(Item[] items) {
6
-        super();
7
-        this.items = items;
8
-    }
9
-
10
-    public void updateQuality() {
11
-        for (int i = 0; i < items.length; i++) {
12
-            if (!items[i].getName().equals("Aged Brie")) {
13
-                if (items[i].getQuality() > 0) {
14
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
15
-                        items[i].setQuality(items[i].getQuality() - 1);
16
-                    }
17
-                }
18
-            } else {
19
-                if (items[i].getQuality() < 50) {
20
-                    items[i].setQuality(items[i].getQuality() + 1);
21
-                }
22
-            }
23
-
24
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
25
-                items[i].setSellIn(items[i].getSellIn() - 1);
26
-            }
27
-
28
-            if (items[i].getSellIn() < 0) {
29
-                if (!items[i].getName().equals("Aged Brie")) {
30
-                  items[i].setQuality(items[i].getQuality() - 1);
31
-                } else {
32
-                    if (items[i].getQuality() < 50) {
33
-                        items[i].setQuality(items[i].getQuality() + 1);
34
-                    }
35
-                }
36
-            }
37
-        }
38
-}
3
+   private Item[] items;
4
+
5
+   public Inventory(Item[] items) {
6
+       super();
7
+       this.items = items;
8
+   }
9
+
10
+   public void updateQuality() {
11
+       for (int i = 0; i < items.length; i++) {
12
+           if (items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
13
+               continue;
14
+           }
15
+
16
+
17
+           if (items[i].getName().equals("Aged Brie")) {
18
+               updateAgedBrie(i);
19
+           }else if(items[i].getName().equals("Conjured Item")){
20
+               updateConjuredItem(i);
21
+           } else{
22
+               updateRegularItem(i);
23
+           }
24
+
25
+         
26
+           if(items[i].getQuality() < 80){
27
+               items[i].setSellIn(items[i].getSellIn() -1);
28
+           }
29
+       }
30
+   }
31
+
32
+
33
+
34
+       public void updateAgedBrie(int i){
35
+       if(items[i].getSellIn() > 0 && items[i].getQuality() <= 49){
36
+           items[i].setQuality(items[i].getQuality() + 1);
37
+       } else if(items[i].getSellIn() < 0 && items[i].getQuality() <= 48){
38
+           items[i].setQuality(items[i].getQuality() + 2);
39
+       }
40
+   }
41
+
42
+   public void updateRegularItem(int i){
43
+       if(items[i].getSellIn() > 0 && items[i].getQuality() > 0){
44
+           items[i].setQuality(items[i].getQuality() - 1);
45
+       } else if(items[i].getSellIn() < 0 && items[i].getQuality() > 1){
46
+           items[i].setQuality(items[i].getQuality() - 2);
47
+       }
48
+   }
49
+
50
+   public void updateConjuredItem(int i){
51
+       if(items[i].getSellIn() > 0 && items[i].getQuality() > 0){
52
+           items[i].setQuality(items[i].getQuality() - 2);
53
+       } else if(items[i].getSellIn() < 0 && items[i].getQuality() > 1){
54
+           items[i].setQuality(items[i].getQuality() - 4);
55
+       }
56
+   }
39 57
 }

+ 4
- 4
package.bluej Просмотреть файл

@@ -7,15 +7,15 @@ dependency2.to=Inventory
7 7
 dependency2.type=UsesDependency
8 8
 editor.fx.0.height=722
9 9
 editor.fx.0.width=800
10
-editor.fx.0.x=320
11
-editor.fx.0.y=50
10
+editor.fx.0.x=240
11
+editor.fx.0.y=26
12 12
 objectbench.height=164
13
-objectbench.width=776
13
+objectbench.width=461
14 14
 package.divider.horizontal=0.6
15 15
 package.divider.vertical=0.6845018450184502
16 16
 package.editor.height=364
17 17
 package.editor.width=674
18
-package.editor.x=577
18
+package.editor.x=480
19 19
 package.editor.y=61
20 20
 package.frame.height=600
21 21
 package.frame.width=800