Prior to this commit the tests had a mixture of JUnit4 and JUnit3 style
of writing. With this commit all tests are using JUnit4 style with
annotations.
With this commit the Spring part has also been polished to use the
updated runner and cleanup the tests to remove the deprecation warnings
due to deprecated annotations.
Prior to this commit some of the versions/dependencies had a
version which was already managed by Spring Boot or one of
the starters. The version of those dependencies have been
removed and either moved to the <properties> section or
removed all together.
The scope of spring-boot-starter-test has also been fixed
to have <scope>test</scope> to properly scope it. As
spring-boot-starter-test already managed jUnit the explicit
declaration has been removed.
Instead of declaring the JMS dependencies and using a
specific version of ActiveMQ the spring-boot-starter-
activemq has been used to cleanup the pom.
Were possible we removed versions and plugins already
declared in the parent project.
Version 3.2.1 has a CVSS 10.0 vulnerability. That's the worst kind of
vulnerability that exists. By merely existing on the classpath, this
library causes the Java serialization parser for the entire JVM process
to go from being a state machine to a turing machine. A turing machine
with an exec() function!
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103
https://commons.apache.org/proper/commons-collections/security-reports.html
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/
I think this might be a leftover from when `CarrierMovement` used to have five constructor parameters, and the test was passing null into different positions. Once refactored the statements ended up looking quite the same instead.