- We used "convert-junit-assertions-to-assertj.sh" script to launch the automatic conversion.
- The auto conversion of assertEquals(<List>, <List>) was wrong.
- assertThat(result.get("REGISTRATIONTIME")).isEqualTo(new Date(20)) in HandlingEventRepositoryTest.java (in the testSave method) throw an exception, because equals call isn't symmetric between java.util.Date and java.sql.Timestamp. AssertJ and Junit equality assertion doesn't call equals method in the same way. One invoke expected.equals(actual) and the other actual.equals(expected).
Version 3.2.1 has a CVSS 10.0 vulnerability. That's the worst kind of
vulnerability that exists. By merely existing on the classpath, this
library causes the Java serialization parser for the entire JVM process
to go from being a state machine to a turing machine. A turing machine
with an exec() function!
https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103
https://commons.apache.org/proper/commons-collections/security-reports.html
http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/
I think this might be a leftover from when `CarrierMovement` used to have five constructor parameters, and the test was passing null into different positions. Once refactored the statements ended up looking quite the same instead.
Need to specify time zone for tests to avoid tz dependent tests. Using server JVM's tz is probably not reasonable for the actual view either, but we'll leave that as is for now.