소스 검색

Use toString() for retrieving a string representation of TrackingId and CarrierId instead of repeated id accessor.

peter_backlund 18 년 전
부모
커밋
e4a93041ca

+ 2
- 1
dddsample/src/main/java/se/citerus/dddsample/domain/CarrierId.java 파일 보기

@@ -18,7 +18,8 @@ public class CarrierId implements Serializable {
18 18
     this.id = id;
19 19
   }
20 20
 
21
-  public String id() {
21
+  @Override
22
+  public String toString() {
22 23
     return id;
23 24
   }
24 25
 

+ 2
- 1
dddsample/src/main/java/se/citerus/dddsample/domain/TrackingId.java 파일 보기

@@ -22,7 +22,8 @@ public class TrackingId implements Serializable {
22 22
     this.id = id;
23 23
   }
24 24
 
25
-  public String id() {
25
+  @Override
26
+  public String toString() {
26 27
     return id;
27 28
   }
28 29
 

+ 5
- 6
dddsample/src/main/java/se/citerus/dddsample/repository/CargoRepositoryInMem.java 파일 보기

@@ -1,15 +1,14 @@
1 1
 package se.citerus.dddsample.repository;
2 2
 
3
-import java.util.HashMap;
4
-import java.util.Map;
5
-
6 3
 import org.springframework.dao.DataRetrievalFailureException;
7
-
8 4
 import se.citerus.dddsample.domain.Cargo;
9 5
 import se.citerus.dddsample.domain.HandlingEvent;
10 6
 import se.citerus.dddsample.domain.Location;
11 7
 import se.citerus.dddsample.domain.TrackingId;
12 8
 
9
+import java.util.HashMap;
10
+import java.util.Map;
11
+
13 12
 /**
14 13
  * CargoRepositoryInMem implement the CargoRepository interface but is a test
15 14
  * class not intended for usage in real application.
@@ -29,11 +28,11 @@ public class CargoRepositoryInMem implements CargoRepository {
29 28
   }
30 29
 
31 30
   public Cargo find(TrackingId trackingId) {
32
-    if (trackingId.id().equalsIgnoreCase("DAE")){
31
+    if (trackingId.toString().equalsIgnoreCase("DAE")){
33 32
       throw new DataRetrievalFailureException("Network failure. Please try again");
34 33
     }
35 34
     
36
-    return cargoDb.get(trackingId.id());
35
+    return cargoDb.get(trackingId.toString());
37 36
   }
38 37
   
39 38
   public void save(Cargo cargo) {

+ 2
- 2
dddsample/src/main/java/se/citerus/dddsample/service/CargoServiceImpl.java 파일 보기

@@ -19,7 +19,7 @@ public class CargoServiceImpl implements CargoService {
19 19
       return null;
20 20
     }
21 21
     final CargoWithHistoryDTO dto = new CargoWithHistoryDTO(
22
-            cargo.trackingId().id(),
22
+            cargo.trackingId().toString(),
23 23
             cargo.origin().unlocode(),
24 24
             cargo.finalDestination().unlocode(),
25 25
             cargo.currentLocation().unlocode()
@@ -28,7 +28,7 @@ public class CargoServiceImpl implements CargoService {
28 28
     for (HandlingEvent event : events) {
29 29
       CarrierMovement cm = event.carrierMovement();
30 30
       String carrierIdString =
31
-              (cm == null) ? Location.UNKNOWN.unlocode() : cm.carrierId().id();
31
+              (cm == null) ? Location.UNKNOWN.unlocode() : cm.carrierId().toString();
32 32
       dto.addEvent(new HandlingEventDTO(
33 33
               event.location().unlocode(),
34 34
               event.type().toString(),

+ 1
- 1
dddsample/src/test/java/se/citerus/dddsample/web/CargoTrackingControllerTest.java 파일 보기

@@ -49,7 +49,7 @@ public class CargoTrackingControllerTest extends TestCase {
49 49
 
50 50
         // TODO: use DTO assemblers
51 51
         CargoWithHistoryDTO cargoDTO = new CargoWithHistoryDTO(
52
-                cargo.trackingId().id(),
52
+                cargo.trackingId().toString(),
53 53
                 cargo.origin().unlocode(),
54 54
                 cargo.finalDestination().unlocode(),
55 55
                 cargo.currentLocation().unlocode()