Просмотр исходного кода

Use toString() for retrieving a string representation of TrackingId and CarrierId instead of repeated id accessor.

peter_backlund 18 лет назад
Родитель
Сommit
e4a93041ca

+ 2
- 1
dddsample/src/main/java/se/citerus/dddsample/domain/CarrierId.java Просмотреть файл

18
     this.id = id;
18
     this.id = id;
19
   }
19
   }
20
 
20
 
21
-  public String id() {
21
+  @Override
22
+  public String toString() {
22
     return id;
23
     return id;
23
   }
24
   }
24
 
25
 

+ 2
- 1
dddsample/src/main/java/se/citerus/dddsample/domain/TrackingId.java Просмотреть файл

22
     this.id = id;
22
     this.id = id;
23
   }
23
   }
24
 
24
 
25
-  public String id() {
25
+  @Override
26
+  public String toString() {
26
     return id;
27
     return id;
27
   }
28
   }
28
 
29
 

+ 5
- 6
dddsample/src/main/java/se/citerus/dddsample/repository/CargoRepositoryInMem.java Просмотреть файл

1
 package se.citerus.dddsample.repository;
1
 package se.citerus.dddsample.repository;
2
 
2
 
3
-import java.util.HashMap;
4
-import java.util.Map;
5
-
6
 import org.springframework.dao.DataRetrievalFailureException;
3
 import org.springframework.dao.DataRetrievalFailureException;
7
-
8
 import se.citerus.dddsample.domain.Cargo;
4
 import se.citerus.dddsample.domain.Cargo;
9
 import se.citerus.dddsample.domain.HandlingEvent;
5
 import se.citerus.dddsample.domain.HandlingEvent;
10
 import se.citerus.dddsample.domain.Location;
6
 import se.citerus.dddsample.domain.Location;
11
 import se.citerus.dddsample.domain.TrackingId;
7
 import se.citerus.dddsample.domain.TrackingId;
12
 
8
 
9
+import java.util.HashMap;
10
+import java.util.Map;
11
+
13
 /**
12
 /**
14
  * CargoRepositoryInMem implement the CargoRepository interface but is a test
13
  * CargoRepositoryInMem implement the CargoRepository interface but is a test
15
  * class not intended for usage in real application.
14
  * class not intended for usage in real application.
29
   }
28
   }
30
 
29
 
31
   public Cargo find(TrackingId trackingId) {
30
   public Cargo find(TrackingId trackingId) {
32
-    if (trackingId.id().equalsIgnoreCase("DAE")){
31
+    if (trackingId.toString().equalsIgnoreCase("DAE")){
33
       throw new DataRetrievalFailureException("Network failure. Please try again");
32
       throw new DataRetrievalFailureException("Network failure. Please try again");
34
     }
33
     }
35
     
34
     
36
-    return cargoDb.get(trackingId.id());
35
+    return cargoDb.get(trackingId.toString());
37
   }
36
   }
38
   
37
   
39
   public void save(Cargo cargo) {
38
   public void save(Cargo cargo) {

+ 2
- 2
dddsample/src/main/java/se/citerus/dddsample/service/CargoServiceImpl.java Просмотреть файл

19
       return null;
19
       return null;
20
     }
20
     }
21
     final CargoWithHistoryDTO dto = new CargoWithHistoryDTO(
21
     final CargoWithHistoryDTO dto = new CargoWithHistoryDTO(
22
-            cargo.trackingId().id(),
22
+            cargo.trackingId().toString(),
23
             cargo.origin().unlocode(),
23
             cargo.origin().unlocode(),
24
             cargo.finalDestination().unlocode(),
24
             cargo.finalDestination().unlocode(),
25
             cargo.currentLocation().unlocode()
25
             cargo.currentLocation().unlocode()
28
     for (HandlingEvent event : events) {
28
     for (HandlingEvent event : events) {
29
       CarrierMovement cm = event.carrierMovement();
29
       CarrierMovement cm = event.carrierMovement();
30
       String carrierIdString =
30
       String carrierIdString =
31
-              (cm == null) ? Location.UNKNOWN.unlocode() : cm.carrierId().id();
31
+              (cm == null) ? Location.UNKNOWN.unlocode() : cm.carrierId().toString();
32
       dto.addEvent(new HandlingEventDTO(
32
       dto.addEvent(new HandlingEventDTO(
33
               event.location().unlocode(),
33
               event.location().unlocode(),
34
               event.type().toString(),
34
               event.type().toString(),

+ 1
- 1
dddsample/src/test/java/se/citerus/dddsample/web/CargoTrackingControllerTest.java Просмотреть файл

49
 
49
 
50
         // TODO: use DTO assemblers
50
         // TODO: use DTO assemblers
51
         CargoWithHistoryDTO cargoDTO = new CargoWithHistoryDTO(
51
         CargoWithHistoryDTO cargoDTO = new CargoWithHistoryDTO(
52
-                cargo.trackingId().id(),
52
+                cargo.trackingId().toString(),
53
                 cargo.origin().unlocode(),
53
                 cargo.origin().unlocode(),
54
                 cargo.finalDestination().unlocode(),
54
                 cargo.finalDestination().unlocode(),
55
                 cargo.currentLocation().unlocode()
55
                 cargo.currentLocation().unlocode()