Просмотр исходного кода

Removed unchecked exception from signature

peter_backlund 16 лет назад
Родитель
Сommit
cb73e352be

+ 1
- 2
dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/application/handling/HandlingEventService.java Просмотреть файл

@@ -1,7 +1,6 @@
1 1
 package se.citerus.dddsample.tracking.core.application.handling;
2 2
 
3 3
 import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
4
-import se.citerus.dddsample.tracking.core.domain.model.handling.CannotCreateHandlingEventException;
5 4
 import se.citerus.dddsample.tracking.core.domain.model.handling.OperatorCode;
6 5
 import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
7 6
 import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
@@ -33,6 +32,6 @@ public interface HandlingEventService {
33 32
                              VoyageNumber voyageNumber,
34 33
                              UnLocode unLocode,
35 34
                              HandlingActivityType type,
36
-                             OperatorCode operatorCode) throws CannotCreateHandlingEventException;
35
+                             OperatorCode operatorCode);
37 36
 
38 37
 }

+ 8
- 4
dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/application/handling/HandlingEventServiceImpl.java Просмотреть файл

@@ -7,7 +7,10 @@ import org.springframework.stereotype.Service;
7 7
 import org.springframework.transaction.annotation.Transactional;
8 8
 import se.citerus.dddsample.tracking.core.application.event.SystemEvents;
9 9
 import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
10
-import se.citerus.dddsample.tracking.core.domain.model.handling.*;
10
+import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEvent;
11
+import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEventFactory;
12
+import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEventRepository;
13
+import se.citerus.dddsample.tracking.core.domain.model.handling.OperatorCode;
11 14
 import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
12 15
 import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
13 16
 import se.citerus.dddsample.tracking.core.domain.model.voyage.VoyageNumber;
@@ -20,7 +23,8 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
20 23
   private final SystemEvents systemEvents;
21 24
   private final HandlingEventRepository handlingEventRepository;
22 25
   private final HandlingEventFactory handlingEventFactory;
23
-  private final Log logger = LogFactory.getLog(HandlingEventServiceImpl.class);
26
+
27
+  private static final Log LOG = LogFactory.getLog(HandlingEventServiceImpl.class);
24 28
 
25 29
   @Autowired
26 30
   public HandlingEventServiceImpl(final HandlingEventRepository handlingEventRepository,
@@ -35,7 +39,7 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
35 39
   @Transactional
36 40
   public void registerHandlingEvent(final Date completionTime, final TrackingId trackingId,
37 41
                                     final VoyageNumber voyageNumber, final UnLocode unLocode,
38
-                                    final HandlingActivityType type, final OperatorCode operatorCode) throws CannotCreateHandlingEventException {
42
+                                    final HandlingActivityType type, final OperatorCode operatorCode) {
39 43
 
40 44
     /* Using a factory to create a HandlingEvent (aggregate). This is where
41 45
        it is determined wether the incoming data, the attempt, actually is capable
@@ -53,7 +57,7 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
53 57
     /* Publish a system event */
54 58
     systemEvents.notifyOfHandlingEvent(handlingEvent);
55 59
 
56
-    logger.info("Registered handling event: " + handlingEvent);
60
+    LOG.info("Registered handling event: " + handlingEvent);
57 61
   }
58 62
 
59 63
 }