Przeglądaj źródła

Removed unchecked exception from signature

peter_backlund 16 lat temu
rodzic
commit
cb73e352be

+ 1
- 2
dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/application/handling/HandlingEventService.java Wyświetl plik

1
 package se.citerus.dddsample.tracking.core.application.handling;
1
 package se.citerus.dddsample.tracking.core.application.handling;
2
 
2
 
3
 import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
3
 import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
4
-import se.citerus.dddsample.tracking.core.domain.model.handling.CannotCreateHandlingEventException;
5
 import se.citerus.dddsample.tracking.core.domain.model.handling.OperatorCode;
4
 import se.citerus.dddsample.tracking.core.domain.model.handling.OperatorCode;
6
 import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
5
 import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
7
 import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
6
 import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
33
                              VoyageNumber voyageNumber,
32
                              VoyageNumber voyageNumber,
34
                              UnLocode unLocode,
33
                              UnLocode unLocode,
35
                              HandlingActivityType type,
34
                              HandlingActivityType type,
36
-                             OperatorCode operatorCode) throws CannotCreateHandlingEventException;
35
+                             OperatorCode operatorCode);
37
 
36
 
38
 }
37
 }

+ 8
- 4
dddsample/tracking/core/src/main/java/se/citerus/dddsample/tracking/core/application/handling/HandlingEventServiceImpl.java Wyświetl plik

7
 import org.springframework.transaction.annotation.Transactional;
7
 import org.springframework.transaction.annotation.Transactional;
8
 import se.citerus.dddsample.tracking.core.application.event.SystemEvents;
8
 import se.citerus.dddsample.tracking.core.application.event.SystemEvents;
9
 import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
9
 import se.citerus.dddsample.tracking.core.domain.model.cargo.TrackingId;
10
-import se.citerus.dddsample.tracking.core.domain.model.handling.*;
10
+import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEvent;
11
+import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEventFactory;
12
+import se.citerus.dddsample.tracking.core.domain.model.handling.HandlingEventRepository;
13
+import se.citerus.dddsample.tracking.core.domain.model.handling.OperatorCode;
11
 import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
14
 import se.citerus.dddsample.tracking.core.domain.model.location.UnLocode;
12
 import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
15
 import se.citerus.dddsample.tracking.core.domain.model.shared.HandlingActivityType;
13
 import se.citerus.dddsample.tracking.core.domain.model.voyage.VoyageNumber;
16
 import se.citerus.dddsample.tracking.core.domain.model.voyage.VoyageNumber;
20
   private final SystemEvents systemEvents;
23
   private final SystemEvents systemEvents;
21
   private final HandlingEventRepository handlingEventRepository;
24
   private final HandlingEventRepository handlingEventRepository;
22
   private final HandlingEventFactory handlingEventFactory;
25
   private final HandlingEventFactory handlingEventFactory;
23
-  private final Log logger = LogFactory.getLog(HandlingEventServiceImpl.class);
26
+
27
+  private static final Log LOG = LogFactory.getLog(HandlingEventServiceImpl.class);
24
 
28
 
25
   @Autowired
29
   @Autowired
26
   public HandlingEventServiceImpl(final HandlingEventRepository handlingEventRepository,
30
   public HandlingEventServiceImpl(final HandlingEventRepository handlingEventRepository,
35
   @Transactional
39
   @Transactional
36
   public void registerHandlingEvent(final Date completionTime, final TrackingId trackingId,
40
   public void registerHandlingEvent(final Date completionTime, final TrackingId trackingId,
37
                                     final VoyageNumber voyageNumber, final UnLocode unLocode,
41
                                     final VoyageNumber voyageNumber, final UnLocode unLocode,
38
-                                    final HandlingActivityType type, final OperatorCode operatorCode) throws CannotCreateHandlingEventException {
42
+                                    final HandlingActivityType type, final OperatorCode operatorCode) {
39
 
43
 
40
     /* Using a factory to create a HandlingEvent (aggregate). This is where
44
     /* Using a factory to create a HandlingEvent (aggregate). This is where
41
        it is determined wether the incoming data, the attempt, actually is capable
45
        it is determined wether the incoming data, the attempt, actually is capable
53
     /* Publish a system event */
57
     /* Publish a system event */
54
     systemEvents.notifyOfHandlingEvent(handlingEvent);
58
     systemEvents.notifyOfHandlingEvent(handlingEvent);
55
 
59
 
56
-    logger.info("Registered handling event: " + handlingEvent);
60
+    LOG.info("Registered handling event: " + handlingEvent);
57
   }
61
   }
58
 
62
 
59
 }
63
 }