completed

README.md

@@ -52,7 +52,7 @@ String phoneLineCode = phoneNumber.getPhoneLineCode();
 	* where `(###)-###-####` will be replaced with the respective input parameter.
 
 * Add logging to the `createPhoneNumberSafely` method from `Part 2`, which logs the message
-	* `(###)-###-#### is not a valid phone number`
+	* `"Attempting to create a new PhoneNumber object with a value of (###)-###-####
 	* Where `(###)-###-####` will be replaced with the respective input parameter.
 
 	

src/main/java/com/zipcodewilmington/phone/PhoneNumber.java

@@ -4,14 +4,22 @@ import com.zipcodewilmington.exceptions.InvalidPhoneNumberFormatException;
 
 /**
  * Created by leon on 5/10/17.
+ * Upon instantiating a new `PhoneNumber` object, it is possible to
+ * receive a `InvalidPhoneNumberFormatException` if the `String` passed
+ * into the `PhoneNumber` constructor does not fit the format `(###)-###-####`.<br>
+ * * `InvalidPhoneNumberFormatException` extends `IOException`, which is a `checked exception`.<br>
+ * * Modify the `createPhoneNumber` method so that it throws any resulting `InvalidPhoneNumberFormatException`.
+ * 	* This will ensure that any method calling `createPhoneNumber` will have to handle the exception.
  */
 public final class PhoneNumber {
     private final String phoneNumberString;
 
+
     // default constructor is uncallable
-    private PhoneNumber() throws InvalidPhoneNumberFormatException {
-        this(null);
-    }
+  private PhoneNumber() throws InvalidPhoneNumberFormatException {
+
+         this(null);
+     }
 
     // non-default constructor is package-protected
     protected PhoneNumber(String phoneNumber) throws InvalidPhoneNumberFormatException {

src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java

@@ -2,6 +2,7 @@ package com.zipcodewilmington.phone;
 
 import com.zipcodewilmington.exceptions.InvalidPhoneNumberFormatException;
 
+import java.util.Random;
 import java.util.logging.Logger;
 
 /**
@@ -19,15 +20,27 @@ public final class PhoneNumberFactory {
      * @param phoneNumberCount - number of PhoneNumber objects to instantiate
      * @return array of randomly generated PhoneNumber objects
      */ //TODO - Implement logic
-    public static PhoneNumber[] createRandomPhoneNumberArray(int phoneNumberCount) {
-        return null;
+    public static PhoneNumber[] createRandomPhoneNumberArray(int phoneNumberCount) throws InvalidPhoneNumberFormatException{
+
+    PhoneNumber[]  phone=new PhoneNumber[phoneNumberCount];
+    for(int i=0;i<phoneNumberCount;i++ )
+    {
+        phone[i]=createRandomPhoneNumber();
     }
 
+        return phone;
+    }
     /**
      * @return an instance of PhoneNumber with randomly generated phone number value
      */ //TODO - Implement logic
-    public static PhoneNumber createRandomPhoneNumber() {
-        return createPhoneNumberSafely(-1, -1, -1);
+    public static PhoneNumber createRandomPhoneNumber()  {
+        Random random=new Random();
+        int areaCode=random.nextInt(900 ) +100;
+        int centralOfficeCode=random.nextInt(900)+100;
+        int phoneLineCode=random.nextInt(8990)+1000;
+        System.out.println("areacode" +areaCode+"\tcentralOfficeCode:"+ centralOfficeCode +"\t phoneLineCode"+phoneLineCode);
+
+        return createPhoneNumberSafely(areaCode , centralOfficeCode ,phoneLineCode );
     }
 
 
@@ -38,15 +51,27 @@ public final class PhoneNumberFactory {
      * @return a new phone number object
      */ //TODO - if input is valid, return respective PhoneNumber object, else return null
     public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOfficeCode, int phoneLineCode) {
-        return createPhoneNumber(null);
+        String phoneNumber="(" + areaCode + ")-" +centralOfficeCode +"-"+phoneLineCode;
+        try {
+            PhoneNumber phoneNumber1 = new PhoneNumber(phoneNumber);
+            return phoneNumber1;
+
+        } catch( InvalidPhoneNumberFormatException e)
+         {
+         logger.warning("invalid phone number" ) ;
+         return  null;
     }
+}
 
     /**
      * @param phoneNumberString - some String corresponding to a phone number whose format is `(###)-###-####`
      * @return a new phone number object
      * @throws InvalidPhoneNumberFormatException - thrown if phoneNumberString does not match acceptable format
      */ // TODO - Add throws statement to method signature
-    public static PhoneNumber createPhoneNumber(String phoneNumberString) {
-        return null;
+    public static PhoneNumber createPhoneNumber(String phoneNumberString) throws InvalidPhoneNumberFormatException {
+        //phoneNumberString ="302-312-5555";
+        PhoneNumber phone=new PhoneNumber(phoneNumberString );
+        logger.info("Attempting to create a new PhoneNumber object with a value of " + phone);
+        return   phone;
     }
 }