Testing poll Controller

src/main/java/io/zipcoder/tc_spring_poll_application/controller/ComputeResultController.java

@@ -14,6 +14,7 @@ import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 
 import java.util.HashMap;
+import java.util.stream.StreamSupport;
 
 @RestController
 public class ComputeResultController {
@@ -34,12 +35,11 @@ public class ComputeResultController {
         // increase the optioncount count field accordingly for each vote
 
         // create Collection Option Counts
-        int voteCount = 0;
+        long voteCount = StreamSupport.stream(allVotes.spliterator(), false).count();
         HashMap<Long, OptionCount> optionCountsMap = new HashMap<>();
 
         for (Vote v: allVotes
              ) {
-            voteCount++;
             Long optionID = (v.getOption().getId());
             if (!optionCountsMap.keySet().contains(optionID)) {
                 optionCountsMap.put(optionID, new OptionCount());
@@ -51,7 +51,7 @@ public class ComputeResultController {
             }
         }
 
-        voteResult.setTotalVotes(voteCount);
+        voteResult.setTotalVotes((int)voteCount);
         voteResult.setResults(optionCountsMap.values());
 
         //TODO: Implement algorithm to count votes

src/main/java/io/zipcoder/tc_spring_poll_application/controller/PollController.java

@@ -14,7 +14,7 @@ import java.net.URI;
 
 @RestController
 public class PollController {
-    PollRepository pollRepository;
+    private PollRepository pollRepository;
 
     @Autowired
     public PollController(PollRepository pollRepository) {

src/main/java/io/zipcoder/tc_spring_poll_application/domain/Poll.java

@@ -43,4 +43,11 @@ public class Poll {
     public void setOptions(Set<Option> options) {
         this.options = options;
     }
+
+    @Override
+    public String toString() {
+        return "{\"id\":" + this.id
+                + ",\"question\":" + question
+                + ",\"options\":" + options + "}";
+    }
 }

src/test/java/io/zipcoder/tc_spring_poll_application/controller/PollControllerTest.java

@@ -0,0 +1,106 @@
+package io.zipcoder.tc_spring_poll_application.controller;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import io.zipcoder.tc_spring_poll_application.domain.Poll;
+import io.zipcoder.tc_spring_poll_application.exception.ResourceNotFoundException;
+import io.zipcoder.tc_spring_poll_application.repositories.PollRepository;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.boot.test.json.JacksonTester;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.MediaType;
+import org.springframework.mock.web.MockHttpServletResponse;
+import org.springframework.test.context.junit4.SpringRunner;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.setup.MockMvcBuilders;
+
+import java.util.Arrays;
+
+import static org.mockito.BDDMockito.given;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+
+@SpringBootTest
+@RunWith(SpringRunner.class)
+@AutoConfigureMockMvc
+public class PollControllerTest {
+    @Autowired
+    private MockMvc mvc;
+    private Poll testPoll;
+    private Iterable<Poll> polls;
+
+    @Mock
+    private PollRepository pollRepository;
+
+    @InjectMocks
+    private PollController pollController;
+
+    private JacksonTester<Poll> pollJacksonTester;
+
+    @Before
+    public void setUp() {
+
+        pollController = new PollController(pollRepository);
+        JacksonTester.initFields(this, new ObjectMapper());
+
+        mvc = MockMvcBuilders.standaloneSetup(pollController)
+                .setControllerAdvice( new ResourceNotFoundException())
+                .build();
+
+        testPoll = new Poll();
+        pollController.createPoll(testPoll);
+
+        Poll[] pollArr = {testPoll};
+        polls = Arrays.asList(pollArr);
+
+    }
+
+    @Test
+    public void testGetPollByIdSuccess() throws Exception {
+
+        given(pollRepository.findOne(1L))
+                .willReturn(testPoll);
+
+        MockHttpServletResponse response = mvc.perform(get("/polls/1")
+                .accept(MediaType.APPLICATION_JSON))
+                .andReturn().getResponse();
+
+        Assert.assertEquals((response.getStatus()), HttpStatus.OK.value());
+        Assert.assertEquals(response.getContentAsString(), testPoll.toString());
+    }
+
+    @Test
+    public void testGetAllPollsSuccess() throws Exception {
+
+        given(pollRepository.findAll())
+                .willReturn(polls);
+
+        MockHttpServletResponse response = mvc.perform(get("/polls")
+                .accept(MediaType.APPLICATION_JSON))
+                .andReturn().getResponse();
+
+        Assert.assertEquals((response.getStatus()), HttpStatus.OK.value());
+        Assert.assertEquals(response.getContentAsString(), polls.toString());
+    }
+
+    @Test
+    public void testGetPollByIdFailException() throws Exception {
+
+        given(pollRepository.findOne(200L))
+                .willThrow(new ResourceNotFoundException());
+
+        MockHttpServletResponse response = mvc.perform(
+                get("/polls/200")
+                .accept(MediaType.APPLICATION_JSON))
+                .andReturn().getResponse();
+
+        Assert.assertEquals(response.getStatus(), HttpStatus.NOT_FOUND.value());
+        Assert.assertTrue(response.getContentAsString().isEmpty());
+    }
+}