refactored computeResult to be cleaner

src/main/java/io/zipcoder/tc_spring_poll_application/controller/ComputeResultController.java

@@ -29,14 +29,19 @@ public class ComputeResultController {
     @RequestMapping(value = "/computeresult", method = RequestMethod.GET)
     public ResponseEntity<?> computeResult(@RequestParam Long pollId) {
         VoteResult voteResult = new VoteResult();
-        Iterable<Vote> allVotes = voteRepository.findById(pollId);
-        Map<Long, Integer> mapOptions = new HashMap<>();
-        Collection<OptionCount> optionCounts = new ArrayList<>();
-        int totalVotes = 0;
+        Map<Long, Integer> mapOptions = mapVotes(voteRepository.findById(pollId));
+        Collection<OptionCount> optionCounts = collectOptionCounts(mapOptions);
+
+        voteResult.setResults(optionCounts);
+        voteResult.setTotalVotes(getTotalVote(optionCounts));
 
+        return new ResponseEntity<>(voteResult, HttpStatus.OK);
+    }
+
+    private Map<Long, Integer> mapVotes(Iterable<Vote> allVotes) {
+        Map<Long, Integer> mapOptions = new HashMap<>();
         for(Vote vote: allVotes) {
             Long id = vote.getOption().getId();
-            totalVotes++;
             if(!mapOptions.containsKey(id)) {
                 mapOptions.put(id, 1);
             } else {
@@ -45,15 +50,25 @@ public class ComputeResultController {
                 mapOptions.put(id, count);
             }
         }
+        return mapOptions;
+    }
+
+    private Collection<OptionCount> collectOptionCounts (Map<Long, Integer> mapOptions) {
+        Collection<OptionCount> optionCounts = new ArrayList<>();
 
         for(Long i: mapOptions.keySet()) {
             OptionCount optionCount = new OptionCount(i, mapOptions.get(i));
             optionCounts.add(optionCount);
         }
+        return optionCounts;
+    }
 
-        voteResult.setResults(optionCounts);
-        voteResult.setTotalVotes(totalVotes);
+    private int getTotalVote(Collection<OptionCount> optionCounts) {
+        int totalVotes = 0;
 
-        return new ResponseEntity<>(voteResult, HttpStatus.OK);
+        for(OptionCount o: optionCounts) {
+            totalVotes += o.getCount();
+        }
+        return totalVotes;
     }
 }