Просмотр исходного кода

Invoke JUnit assertEquals with Argument Order (expected, actual)

The JUnit API documents assertEquals as taking the expected argument
before the actual argument.  Failure to adhere to this can result in
very confusing test failure messages.

For example in testTransformOneValue 'old' contains 'A' and 'expected'
contains 'a'.  If the implementer does not lower-case the key, the
failure message is as follows if the argument order is
(actual, expected):

EtlTest > testTransformOneValue FAILED
    java.lang.AssertionError: expected:<{A=1}> but was:<{a=1}>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at EtlTest.testTransformOneValue(EtlTest.java:27)

This is very confusing as "was:<{a=1}>" is exactly what we were hoping
the result would be.
Nigel Perkins 9 лет назад
Родитель
Сommit
ee314364e1
1 измененных файлов: 4 добавлений и 4 удалений
  1. 4
    4
      exercises/etl/src/test/java/EtlTest.java

+ 4
- 4
exercises/etl/src/test/java/EtlTest.java Просмотреть файл

24
         };
24
         };
25
         expected = Collections.unmodifiableMap(expected);
25
         expected = Collections.unmodifiableMap(expected);
26
 
26
 
27
-        assertEquals(etl.transform(old), expected);
27
+        assertEquals(expected, etl.transform(old));
28
     }
28
     }
29
 
29
 
30
     @Test
30
     @Test
47
         };
47
         };
48
         expected = Collections.unmodifiableMap(expected);
48
         expected = Collections.unmodifiableMap(expected);
49
 
49
 
50
-        assertEquals(etl.transform(old), expected);
50
+        assertEquals(expected, etl.transform(old));
51
     }
51
     }
52
 
52
 
53
     @Test
53
     @Test
70
         };
70
         };
71
         expected = Collections.unmodifiableMap(expected);
71
         expected = Collections.unmodifiableMap(expected);
72
 
72
 
73
-        assertEquals(etl.transform(old), expected);
73
+        assertEquals(expected, etl.transform(old));
74
     }
74
     }
75
 
75
 
76
     @Test
76
     @Test
120
         };
120
         };
121
         expected = Collections.unmodifiableMap(expected);
121
         expected = Collections.unmodifiableMap(expected);
122
 
122
 
123
-        assertEquals(etl.transform(old), expected);
123
+        assertEquals(expected, etl.transform(old));
124
     }
124
     }
125
 }
125
 }