kristofer
/
JavaExercism
Tarkkaile 1
Äänestä 0
Fork 1
Koodi Ongelmat 0 Pull-pyynnöt 0 Julkaisut 1 Wiki Activity
Selaa lähdekoodia

remove final from tests (#1439)

Scott Ertel 6 vuotta sitten
vanhempi
ebd47c44ed
commit
7924b434ac
1 muutettua tiedostoa jossa 36 lisäystä ja 36 poistoa
Yhdistetty näkymä Näytä diff tilastot
  1. 36
    36
      exercises/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java

+ 36
- 36
exercises/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java Näytä tiedosto

12
12
13 
     @Test
 13 
     @Test
14 
     public void testCorrectlyCalculatesLargestProductWhenSeriesLengthEqualsStringToSearchLength() {
 14 
     public void testCorrectlyCalculatesLargestProductWhenSeriesLengthEqualsStringToSearchLength() {
15 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("29");
16 
-        final long expectedProduct = 18;
15 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("29");
16 
+        long expectedProduct = 18;
17
17
18 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
18 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
19
19
20 
         assertEquals(expectedProduct, actualProduct);
 20 
         assertEquals(expectedProduct, actualProduct);
21 
     }
 21 
     }
23 
     @Ignore("Remove to run test")
 23 
     @Ignore("Remove to run test")
24 
     @Test
 24 
     @Test
25 
     public void testCorrectlyCalculatesLargestProductOfLengthTwoWithNumbersInOrder() {
 25 
     public void testCorrectlyCalculatesLargestProductOfLengthTwoWithNumbersInOrder() {
26 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0123456789");
27 
-        final long expectedProduct = 72;
26 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0123456789");
27 
+        long expectedProduct = 72;
28
28
29 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
29 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
30
30
31 
         assertEquals(expectedProduct, actualProduct);
 31 
         assertEquals(expectedProduct, actualProduct);
32 
     }
 32 
     }
34 
     @Ignore("Remove to run test")
 34 
     @Ignore("Remove to run test")
35 
     @Test
 35 
     @Test
36 
     public void testCorrectlyCalculatesLargestProductOfLengthTwoWithNumbersNotInOrder() {
 36 
     public void testCorrectlyCalculatesLargestProductOfLengthTwoWithNumbersNotInOrder() {
37 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("576802143");
38 
-        final long expectedProduct = 48;
37 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("576802143");
38 
+        long expectedProduct = 48;
39
39
40 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
40 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
41
41
42 
         assertEquals(expectedProduct, actualProduct);
 42 
         assertEquals(expectedProduct, actualProduct);
43 
     }
 43 
     }
45 
     @Ignore("Remove to run test")
 45 
     @Ignore("Remove to run test")
46 
     @Test
 46 
     @Test
47 
     public void testCorrectlyCalculatesLargestProductOfLengthThreeWithNumbersInOrder() {
 47 
     public void testCorrectlyCalculatesLargestProductOfLengthThreeWithNumbersInOrder() {
48 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0123456789");
49 
-        final long expectedProduct = 504;
48 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0123456789");
49 
+        long expectedProduct = 504;
50
50
51 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(3);
51 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(3);
52
52
53 
         assertEquals(expectedProduct, actualProduct);
 53 
         assertEquals(expectedProduct, actualProduct);
54 
     }
 54 
     }
56 
     @Ignore("Remove to run test")
 56 
     @Ignore("Remove to run test")
57 
     @Test
 57 
     @Test
58 
     public void testCorrectlyCalculatesLargestProductOfLengthThreeWithNumbersNotInOrder() {
 58 
     public void testCorrectlyCalculatesLargestProductOfLengthThreeWithNumbersNotInOrder() {
59 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("1027839564");
60 
-        final long expectedProduct = 270;
59 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("1027839564");
60 
+        long expectedProduct = 270;
61
61
62 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(3);
62 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(3);
63
63
64 
         assertEquals(expectedProduct, actualProduct);
 64 
         assertEquals(expectedProduct, actualProduct);
65 
     }
 65 
     }
67 
     @Ignore("Remove to run test")
 67 
     @Ignore("Remove to run test")
68 
     @Test
 68 
     @Test
69 
     public void testCorrectlyCalculatesLargestProductOfLengthFiveWithNumbersInOrder() {
 69 
     public void testCorrectlyCalculatesLargestProductOfLengthFiveWithNumbersInOrder() {
70 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0123456789");
71 
-        final long expectedProduct = 15120;
70 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0123456789");
71 
+        long expectedProduct = 15120;
72
72
73 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(5);
73 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(5);
74
74
75 
         assertEquals(expectedProduct, actualProduct);
 75 
         assertEquals(expectedProduct, actualProduct);
76 
     }
 76 
     }
78 
     @Ignore("Remove to run test")
 78 
     @Ignore("Remove to run test")
79 
     @Test
 79 
     @Test
80 
     public void testCorrectlyCalculatesLargestProductInLongStringToSearchV1() {
 80 
     public void testCorrectlyCalculatesLargestProductInLongStringToSearchV1() {
81 
-        final LargestSeriesProductCalculator calculator
81 
+        LargestSeriesProductCalculator calculator
82 
                 = new LargestSeriesProductCalculator("73167176531330624919225119674426574742355349194934");
 82 
                 = new LargestSeriesProductCalculator("73167176531330624919225119674426574742355349194934");
83
83
84 
-        final long expectedProduct = 23520;
84 
+        long expectedProduct = 23520;
85
85
86 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(6);
86 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(6);
87
87
88 
         assertEquals(expectedProduct, actualProduct);
 88 
         assertEquals(expectedProduct, actualProduct);
89 
     }
 89 
     }
91 
     @Ignore("Remove to run test")
 91 
     @Ignore("Remove to run test")
92 
     @Test
 92 
     @Test
93 
     public void testCorrectlyCalculatesLargestProductOfZeroIfAllDigitsAreZeroes() {
 93 
     public void testCorrectlyCalculatesLargestProductOfZeroIfAllDigitsAreZeroes() {
94 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0000");
95 
-        final long expectedProduct = 0;
94 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("0000");
95 
+        long expectedProduct = 0;
96
96
97 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
97 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(2);
98
98
99 
         assertEquals(expectedProduct, actualProduct);
 99 
         assertEquals(expectedProduct, actualProduct);
100 
     }
 100 
     }
102 
     @Ignore("Remove to run test")
 102 
     @Ignore("Remove to run test")
103 
     @Test
 103 
     @Test
104 
     public void testCorrectlyCalculatesLargestProductOfZeroIfAllSeriesOfGivenLengthContainZero() {
 104 
     public void testCorrectlyCalculatesLargestProductOfZeroIfAllSeriesOfGivenLengthContainZero() {
105 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("99099");
106 
-        final long expectedProduct = 0;
105 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("99099");
106 
+        long expectedProduct = 0;
107
107
108 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(3);
108 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(3);
109
109
110 
         assertEquals(expectedProduct, actualProduct);
 110 
         assertEquals(expectedProduct, actualProduct);
111 
     }
 111 
     }
113 
     @Ignore("Remove to run test")
 113 
     @Ignore("Remove to run test")
114 
     @Test
 114 
     @Test
115 
     public void testSeriesLengthLongerThanLengthOfStringToTestIsRejected() {
 115 
     public void testSeriesLengthLongerThanLengthOfStringToTestIsRejected() {
116 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("123");
116 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("123");
117
117
118 
         expectedException.expect(IllegalArgumentException.class);
 118 
         expectedException.expect(IllegalArgumentException.class);
119 
         expectedException.expectMessage(
 119 
         expectedException.expectMessage(
125 
     @Ignore("Remove to run test")
 125 
     @Ignore("Remove to run test")
126 
     @Test
 126 
     @Test
127 
     public void testCorrectlyCalculatesLargestProductOfLength0ForEmptyStringToSearch() {
 127 
     public void testCorrectlyCalculatesLargestProductOfLength0ForEmptyStringToSearch() {
128 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("");
129 
-        final long expectedProduct = 1;
128 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("");
129 
+        long expectedProduct = 1;
130
130
131 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(0);
131 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(0);
132
132
133 
         assertEquals(expectedProduct, actualProduct);
 133 
         assertEquals(expectedProduct, actualProduct);
134 
     }
 134 
     }
136 
     @Ignore("Remove to run test")
 136 
     @Ignore("Remove to run test")
137 
     @Test
 137 
     @Test
138 
     public void testCorrectlyCalculatesLargestProductOfLength0ForNonEmptyStringToSearch() {
 138 
     public void testCorrectlyCalculatesLargestProductOfLength0ForNonEmptyStringToSearch() {
139 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("123");
140 
-        final long expectedProduct = 1;
139 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("123");
140 
+        long expectedProduct = 1;
141
141
142 
-        final long actualProduct = calculator.calculateLargestProductForSeriesLength(0);
142 
+        long actualProduct = calculator.calculateLargestProductForSeriesLength(0);
143
143
144 
         assertEquals(expectedProduct, actualProduct);
 144 
         assertEquals(expectedProduct, actualProduct);
145 
     }
 145 
     }
147 
     @Ignore("Remove to run test")
 147 
     @Ignore("Remove to run test")
148 
     @Test
 148 
     @Test
149 
     public void testEmptyStringToSearchAndSeriesOfNonZeroLengthIsRejected() {
 149 
     public void testEmptyStringToSearchAndSeriesOfNonZeroLengthIsRejected() {
150 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("");
150 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("");
151
151
152 
         expectedException.expect(IllegalArgumentException.class);
 152 
         expectedException.expect(IllegalArgumentException.class);
153 
         expectedException.expectMessage(
 153 
         expectedException.expectMessage(
168 
     @Ignore("Remove to run test")
 168 
     @Ignore("Remove to run test")
169 
     @Test
 169 
     @Test
170 
     public void testNegativeSeriesLengthIsRejected() {
 170 
     public void testNegativeSeriesLengthIsRejected() {
171 
-        final LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("12345");
171 
+        LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("12345");
172
172
173 
         expectedException.expect(IllegalArgumentException.class);
 173 
         expectedException.expect(IllegalArgumentException.class);
174 
         expectedException.expectMessage("Series length must be non-negative.");
 174 
         expectedException.expectMessage("Series length must be non-negative.");