Browse Source

Remove final keyword from tests

Scott Ertel 8 years ago
parent
commit
28f07fa785

+ 10
- 10
exercises/pythagorean-triplet/src/test/java/PythagoreanTripletTest.java View File

15
     @Test
15
     @Test
16
     public void shouldCalculateSum() {
16
     public void shouldCalculateSum() {
17
         PythagoreanTriplet triplet = new PythagoreanTriplet(3, 4, 5);
17
         PythagoreanTriplet triplet = new PythagoreanTriplet(3, 4, 5);
18
-        final int expected = 12;
19
-        final int actual = triplet.calculateSum();
18
+        int expected = 12;
19
+        int actual = triplet.calculateSum();
20
         assertEquals(expected, actual);
20
         assertEquals(expected, actual);
21
     }
21
     }
22
 
22
 
24
     @Test
24
     @Test
25
     public void shouldCalculateProduct() {
25
     public void shouldCalculateProduct() {
26
         PythagoreanTriplet triplet = new PythagoreanTriplet(3, 4, 5);
26
         PythagoreanTriplet triplet = new PythagoreanTriplet(3, 4, 5);
27
-        final long expected = 60l;
28
-        final long actual = triplet.calculateProduct();
27
+        long expected = 60l;
28
+        long actual = triplet.calculateProduct();
29
         assertEquals(expected, actual);
29
         assertEquals(expected, actual);
30
     }
30
     }
31
 
31
 
46
     @Ignore("Remove to run test")
46
     @Ignore("Remove to run test")
47
     @Test
47
     @Test
48
     public void shouldMakeTripletsUpToTen() {
48
     public void shouldMakeTripletsUpToTen() {
49
-        final List<Long> actual
49
+        List<Long> actual
50
                 = PythagoreanTriplet
50
                 = PythagoreanTriplet
51
                         .makeTripletsList()
51
                         .makeTripletsList()
52
                         .withFactorsLessThanOrEqualTo(10)
52
                         .withFactorsLessThanOrEqualTo(10)
55
                         .map(t -> t.calculateProduct())
55
                         .map(t -> t.calculateProduct())
56
                         .sorted()
56
                         .sorted()
57
                         .collect(Collectors.toList());
57
                         .collect(Collectors.toList());
58
-        final List<Long> expected = Arrays.asList(60l, 480l);
58
+        List<Long> expected = Arrays.asList(60l, 480l);
59
         assertEquals(expected, actual);
59
         assertEquals(expected, actual);
60
     }
60
     }
61
 
61
 
62
     @Ignore("Remove to run test")
62
     @Ignore("Remove to run test")
63
     @Test
63
     @Test
64
     public void shouldMakeTripletsElevenToTwenty() {
64
     public void shouldMakeTripletsElevenToTwenty() {
65
-        final List<Long> actual
65
+        List<Long> actual
66
                 = PythagoreanTriplet
66
                 = PythagoreanTriplet
67
                         .makeTripletsList()
67
                         .makeTripletsList()
68
                         .withFactorsGreaterThanOrEqualTo(11)
68
                         .withFactorsGreaterThanOrEqualTo(11)
72
                         .map(t -> t.calculateProduct())
72
                         .map(t -> t.calculateProduct())
73
                         .sorted((p1, p2) -> Double.compare(p1, p2))
73
                         .sorted((p1, p2) -> Double.compare(p1, p2))
74
                         .collect(Collectors.toList());
74
                         .collect(Collectors.toList());
75
-        final List<Long> expected = Arrays.asList(3840l);
75
+        List<Long> expected = Arrays.asList(3840l);
76
         assertEquals(expected, actual);
76
         assertEquals(expected, actual);
77
     }
77
     }
78
 
78
 
79
     @Ignore("Remove to run test")
79
     @Ignore("Remove to run test")
80
     @Test
80
     @Test
81
     public void shouldMakeTripletsAndFilterOnSum() {
81
     public void shouldMakeTripletsAndFilterOnSum() {
82
-        final List<Long> actual
82
+        List<Long> actual
83
                 = PythagoreanTriplet
83
                 = PythagoreanTriplet
84
                         .makeTripletsList()
84
                         .makeTripletsList()
85
                         .withFactorsLessThanOrEqualTo(100)
85
                         .withFactorsLessThanOrEqualTo(100)
89
                         .map(t -> t.calculateProduct())
89
                         .map(t -> t.calculateProduct())
90
                         .sorted((p1, p2) -> Double.compare(p1, p2))
90
                         .sorted((p1, p2) -> Double.compare(p1, p2))
91
                         .collect(Collectors.toList());
91
                         .collect(Collectors.toList());
92
-        final List<Long> expected = Arrays.asList(118080l, 168480l, 202500l);
92
+        List<Long> expected = Arrays.asList(118080l, 168480l, 202500l);
93
         assertEquals(expected, actual);
93
         assertEquals(expected, actual);
94
     }
94
     }
95
 }
95
 }