test methods

.idea/workspace.xml

@@ -2,9 +2,6 @@
 <project version="4">
   <component name="ChangeListManager">
     <list default="true" id="926ad23d-2ddc-41ae-980d-780dcc1811fa" name="Default" comment="">
-      <change beforePath="$PROJECT_DIR$/Checkbook/src/main/java/Checkbook.java" beforeDir="false" afterPath="$PROJECT_DIR$/Checkbook/src/main/java/Checkbook.java" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/Checkbook/src/main/java/Payee.java" beforeDir="false" afterPath="$PROJECT_DIR$/Checkbook/src/main/java/Payee.java" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/Checkbook/src/main/java/Transaction.java" beforeDir="false" afterPath="$PROJECT_DIR$/Checkbook/src/main/java/Transaction.java" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/Checkbook/src/test/java/CheckbookTest.java" beforeDir="false" afterPath="$PROJECT_DIR$/Checkbook/src/test/java/CheckbookTest.java" afterDir="false" />
     </list>
     <ignored path="$PROJECT_DIR$/Checkbook/target/" />
@@ -25,13 +22,13 @@
       <usages-collector id="statistics.file.types.open">
         <counts>
           <entry key="CLASS" value="6" />
-          <entry key="JAVA" value="43" />
+          <entry key="JAVA" value="44" />
           <entry key="Markdown" value="1" />
         </counts>
       </usages-collector>
       <usages-collector id="statistics.file.types.edit">
         <counts>
-          <entry key="JAVA" value="8937" />
+          <entry key="JAVA" value="9750" />
           <entry key="Markdown" value="11" />
         </counts>
       </usages-collector>
@@ -43,7 +40,7 @@
         <entry file="file://$PROJECT_DIR$/README.md">
           <provider selected="true" editor-type-id="split-provider[text-editor;markdown-preview-editor]">
             <state split_layout="FIRST">
-              <first_editor relative-caret-position="765">
+              <first_editor relative-caret-position="283">
                 <caret line="48" lean-forward="true" selection-start-line="48" selection-end-line="48" />
               </first_editor>
               <second_editor />
@@ -54,7 +51,7 @@
       <file pinned="false" current-in-tab="false">
         <entry file="file://$PROJECT_DIR$/Checkbook/src/main/java/Transaction.java">
           <provider selected="true" editor-type-id="text-editor">
-            <state relative-caret-position="185">
+            <state relative-caret-position="-279">
               <caret line="12" column="26" lean-forward="true" selection-start-line="12" selection-start-column="26" selection-end-line="12" selection-end-column="26" />
               <folding>
                 <element signature="imports" expanded="true" />
@@ -66,8 +63,8 @@
       <file pinned="false" current-in-tab="false">
         <entry file="file://$PROJECT_DIR$/Checkbook/src/main/java/Checkbook.java">
           <provider selected="true" editor-type-id="text-editor">
-            <state relative-caret-position="279">
-              <caret line="83" column="16" selection-start-line="83" selection-start-column="16" selection-end-line="83" selection-end-column="16" />
+            <state relative-caret-position="-1294">
+              <caret line="45" lean-forward="true" selection-start-line="45" selection-end-line="45" />
               <folding>
                 <element signature="imports" expanded="true" />
                 <element signature="e#1262#1263#0" expanded="true" />
@@ -94,8 +91,8 @@
       <file pinned="false" current-in-tab="true">
         <entry file="file://$PROJECT_DIR$/Checkbook/src/test/java/CheckbookTest.java">
           <provider selected="true" editor-type-id="text-editor">
-            <state relative-caret-position="-209">
-              <caret line="228" column="5" selection-start-line="228" selection-start-column="5" selection-end-line="228" selection-end-column="5" />
+            <state relative-caret-position="362">
+              <caret line="354" column="94" selection-start-line="354" selection-start-column="94" selection-end-line="354" selection-end-column="94" />
               <folding>
                 <element signature="imports" expanded="true" />
               </folding>
@@ -154,8 +151,8 @@
         <option value="$PROJECT_DIR$/Checkbook/src/main/java/Account.java" />
         <option value="$PROJECT_DIR$/Checkbook/src/main/java/Transaction.java" />
         <option value="$PROJECT_DIR$/Checkbook/src/main/java/Payee.java" />
-        <option value="$PROJECT_DIR$/Checkbook/src/test/java/CheckbookTest.java" />
         <option value="$PROJECT_DIR$/Checkbook/src/main/java/Checkbook.java" />
+        <option value="$PROJECT_DIR$/Checkbook/src/test/java/CheckbookTest.java" />
       </list>
     </option>
   </component>
@@ -241,7 +238,7 @@
   <component name="PropertiesComponent">
     <property name="WebServerToolWindowFactoryState" value="false" />
     <property name="aspect.path.notification.shown" value="true" />
-    <property name="com.android.tools.idea.instantapp.provision.ProvisionBeforeRunTaskProvider.myTimeStamp" value="1544124424998" />
+    <property name="com.android.tools.idea.instantapp.provision.ProvisionBeforeRunTaskProvider.myTimeStamp" value="1544135882851" />
     <property name="com.intellij.testIntegration.createTest.CreateTestDialog.defaultLibrary" value="JUnit4" />
     <property name="extract.method.default.visibility" value="private" />
     <property name="jdk.selected.JAVA_MODULE" value="1.8" />
@@ -272,7 +269,7 @@
       </list>
     </option>
   </component>
-  <component name="RunManager" selected="JUnit.CheckbookTest.getTransactionsForPayeeExists">
+  <component name="RunManager" selected="JUnit.CheckbookTest.testGetCreditsafterAdding">
     <configuration default="true" type="Applet" factoryName="Applet">
       <option name="POLICY_FILE" value="$APPLICATION_HOME_DIR$/bin/appletviewer.policy" />
       <method v="2">
@@ -285,55 +282,55 @@
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="CheckbookTest.getTransactionAddingNewTForDateA" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+    <configuration name="CheckbookTest.testGetCredits" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="Checkbook" />
       <option name="PACKAGE_NAME" value="" />
       <option name="MAIN_CLASS_NAME" value="CheckbookTest" />
-      <option name="METHOD_NAME" value="getTransactionAddingNewTForDateA" />
+      <option name="METHOD_NAME" value="testGetCredits" />
       <option name="TEST_OBJECT" value="method" />
       <option name="WORKING_DIRECTORY" value="%MODULE_WORKING_DIR%" />
       <method v="2">
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="CheckbookTest.getTransactionsForPayeeExists" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+    <configuration name="CheckbookTest.testGetCreditsNone" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="Checkbook" />
       <option name="PACKAGE_NAME" value="" />
       <option name="MAIN_CLASS_NAME" value="CheckbookTest" />
-      <option name="METHOD_NAME" value="getTransactionsForPayeeExists" />
+      <option name="METHOD_NAME" value="testGetCreditsNone" />
       <option name="TEST_OBJECT" value="method" />
       <option name="WORKING_DIRECTORY" value="%MODULE_WORKING_DIR%" />
       <method v="2">
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="CheckbookTest.getTransactionsForPayeeExists2" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+    <configuration name="CheckbookTest.testGetCreditsafterAdding" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="Checkbook" />
       <option name="PACKAGE_NAME" value="" />
       <option name="MAIN_CLASS_NAME" value="CheckbookTest" />
-      <option name="METHOD_NAME" value="getTransactionsForPayeeExists2" />
+      <option name="METHOD_NAME" value="testGetCreditsafterAdding" />
       <option name="TEST_OBJECT" value="method" />
       <option name="WORKING_DIRECTORY" value="%MODULE_WORKING_DIR%" />
       <method v="2">
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="CheckbookTest.getTransactionsForPayeeExistsAfterAdd" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+    <configuration name="CheckbookTest.testGetDebitsManipulatedCheckbook" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="Checkbook" />
       <option name="PACKAGE_NAME" value="" />
       <option name="MAIN_CLASS_NAME" value="CheckbookTest" />
-      <option name="METHOD_NAME" value="getTransactionsForPayeeExistsAfterAdd" />
+      <option name="METHOD_NAME" value="testGetDebitsManipulatedCheckbook" />
       <option name="TEST_OBJECT" value="method" />
       <option name="WORKING_DIRECTORY" value="%MODULE_WORKING_DIR%" />
       <method v="2">
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="CheckbookTest.getTransactionsForPayeeNotExists" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+    <configuration name="CheckbookTest.testToArrayFailV2" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="Checkbook" />
       <option name="PACKAGE_NAME" value="" />
       <option name="MAIN_CLASS_NAME" value="CheckbookTest" />
-      <option name="METHOD_NAME" value="getTransactionsForPayeeNotExists" />
+      <option name="METHOD_NAME" value="testToArrayFailV2" />
       <option name="TEST_OBJECT" value="method" />
       <option name="WORKING_DIRECTORY" value="%MODULE_WORKING_DIR%" />
       <method v="2">
@@ -364,19 +361,19 @@
       </method>
     </configuration>
     <list>
-      <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeExists" />
-      <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeExists2" />
-      <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeNotExists" />
-      <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeExistsAfterAdd" />
-      <item itemvalue="JUnit.CheckbookTest.getTransactionAddingNewTForDateA" />
+      <item itemvalue="JUnit.CheckbookTest.testGetDebitsManipulatedCheckbook" />
+      <item itemvalue="JUnit.CheckbookTest.testToArrayFailV2" />
+      <item itemvalue="JUnit.CheckbookTest.testGetCredits" />
+      <item itemvalue="JUnit.CheckbookTest.testGetCreditsNone" />
+      <item itemvalue="JUnit.CheckbookTest.testGetCreditsafterAdding" />
     </list>
     <recent_temporary>
       <list>
-        <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeExists" />
-        <item itemvalue="JUnit.CheckbookTest.getTransactionAddingNewTForDateA" />
-        <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeExistsAfterAdd" />
-        <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeNotExists" />
-        <item itemvalue="JUnit.CheckbookTest.getTransactionsForPayeeExists2" />
+        <item itemvalue="JUnit.CheckbookTest.testGetCreditsafterAdding" />
+        <item itemvalue="JUnit.CheckbookTest.testGetCreditsNone" />
+        <item itemvalue="JUnit.CheckbookTest.testGetCredits" />
+        <item itemvalue="JUnit.CheckbookTest.testToArrayFailV2" />
+        <item itemvalue="JUnit.CheckbookTest.testGetDebitsManipulatedCheckbook" />
       </list>
     </recent_temporary>
   </component>
@@ -391,44 +388,44 @@
       <option name="presentableId" value="Default" />
       <updated>1543958631974</updated>
       <workItem from="1543958633447" duration="3259000" />
-      <workItem from="1544046850600" duration="23473000" />
+      <workItem from="1544046850600" duration="24772000" />
     </task>
     <servers />
   </component>
   <component name="TestHistory">
-    <history-entry file="CheckbookTest_getTransactionsForPayeeExists2 - 2018.12.06 at 13h 20m 20s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeExists2" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_getTransactionsForPayeeExistsAfterAdd - 2018.12.06 at 14h 24m 20s.xml">
+      <configuration name="CheckbookTest.getTransactionsForPayeeExistsAfterAdd" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeExists2 - 2018.12.06 at 13h 20m 40s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeExists2" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_getTransactionsForPayeeExistsAfterAdd - 2018.12.06 at 14h 24m 50s.xml">
+      <configuration name="CheckbookTest.getTransactionsForPayeeExistsAfterAdd" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeExists2 - 2018.12.06 at 13h 20m 56s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeExists2" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_getTransactionAddingNewTForDateA - 2018.12.06 at 14h 27m 07s.xml">
+      <configuration name="CheckbookTest.getTransactionAddingNewTForDateA" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeNotExists - 2018.12.06 at 13h 24m 02s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeNotExists" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_getTransactionsForPayeeExists - 2018.12.06 at 14h 31m 23s.xml">
+      <configuration name="CheckbookTest.getTransactionsForPayeeExists" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeNotExists - 2018.12.06 at 13h 24m 22s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeNotExists" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_testGetDebits - 2018.12.06 at 17h 31m 07s.xml">
+      <configuration name="CheckbookTest.testGetDebits" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeExistsAfterAdd - 2018.12.06 at 13h 26m 25s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeExistsAfterAdd" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_testGetDebits - 2018.12.06 at 17h 31m 20s.xml">
+      <configuration name="CheckbookTest.testGetDebits" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeExistsAfterAdd - 2018.12.06 at 13h 26m 55s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeExistsAfterAdd" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_testGetDebits - 2018.12.06 at 17h 32m 48s.xml">
+      <configuration name="CheckbookTest.testGetDebits" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeExistsAfterAdd - 2018.12.06 at 14h 24m 20s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeExistsAfterAdd" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_testGetDebitsNone - 2018.12.06 at 17h 34m 21s.xml">
+      <configuration name="CheckbookTest.testGetDebitsNone" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionsForPayeeExistsAfterAdd - 2018.12.06 at 14h 24m 50s.xml">
-      <configuration name="CheckbookTest.getTransactionsForPayeeExistsAfterAdd" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_testGetDebitsManipulatedCheckbook - 2018.12.06 at 17h 35m 23s.xml">
+      <configuration name="CheckbookTest.testGetDebitsManipulatedCheckbook" configurationId="JUnit" />
     </history-entry>
-    <history-entry file="CheckbookTest_getTransactionAddingNewTForDateA - 2018.12.06 at 14h 27m 07s.xml">
-      <configuration name="CheckbookTest.getTransactionAddingNewTForDateA" configurationId="JUnit" />
+    <history-entry file="CheckbookTest_testToArrayFailV2 - 2018.12.06 at 17h 36m 26s.xml">
+      <configuration name="CheckbookTest.testToArrayFailV2" configurationId="JUnit" />
     </history-entry>
   </component>
   <component name="TimeTrackingManager">
-    <option name="totallyTimeSpent" value="26732000" />
+    <option name="totallyTimeSpent" value="28031000" />
   </component>
   <component name="ToolWindowManager">
     <frame x="0" y="23" width="1440" height="877" extended-state="0" />
@@ -450,7 +447,7 @@
       <window_info anchor="bottom" id="Cvs" order="4" weight="0.25" />
       <window_info anchor="bottom" id="Inspection" order="5" weight="0.4" />
       <window_info anchor="bottom" id="TODO" order="6" />
-      <window_info anchor="bottom" id="Terminal" order="7" weight="0.32899868" />
+      <window_info anchor="bottom" id="Terminal" order="7" weight="0.32769832" />
       <window_info anchor="bottom" id="Event Log" order="8" sideWeight="0.5007153" side_tool="true" weight="0.32769832" />
       <window_info anchor="bottom" id="Version Control" order="9" />
       <window_info anchor="right" id="Commander" order="0" weight="0.4" />
@@ -584,16 +581,6 @@
         </state>
       </provider>
     </entry>
-    <entry file="file://$PROJECT_DIR$/README.md">
-      <provider selected="true" editor-type-id="split-provider[text-editor;markdown-preview-editor]">
-        <state split_layout="FIRST">
-          <first_editor relative-caret-position="765">
-            <caret line="48" lean-forward="true" selection-start-line="48" selection-end-line="48" />
-          </first_editor>
-          <second_editor />
-        </state>
-      </provider>
-    </entry>
     <entry file="jar://$MAVEN_REPOSITORY$/junit/junit/4.0/junit-4.0.jar!/org/junit/Assert.class">
       <provider selected="true" editor-type-id="text-editor">
         <state relative-caret-position="124">
@@ -614,7 +601,7 @@
     </entry>
     <entry file="file://$PROJECT_DIR$/Checkbook/src/main/java/Transaction.java">
       <provider selected="true" editor-type-id="text-editor">
-        <state relative-caret-position="185">
+        <state relative-caret-position="-279">
           <caret line="12" column="26" lean-forward="true" selection-start-line="12" selection-start-column="26" selection-end-line="12" selection-end-column="26" />
           <folding>
             <element signature="imports" expanded="true" />
@@ -622,10 +609,20 @@
         </state>
       </provider>
     </entry>
+    <entry file="file://$PROJECT_DIR$/README.md">
+      <provider selected="true" editor-type-id="split-provider[text-editor;markdown-preview-editor]">
+        <state split_layout="FIRST">
+          <first_editor relative-caret-position="283">
+            <caret line="48" lean-forward="true" selection-start-line="48" selection-end-line="48" />
+          </first_editor>
+          <second_editor />
+        </state>
+      </provider>
+    </entry>
     <entry file="file://$PROJECT_DIR$/Checkbook/src/main/java/Checkbook.java">
       <provider selected="true" editor-type-id="text-editor">
-        <state relative-caret-position="279">
-          <caret line="83" column="16" selection-start-line="83" selection-start-column="16" selection-end-line="83" selection-end-column="16" />
+        <state relative-caret-position="-1294">
+          <caret line="45" lean-forward="true" selection-start-line="45" selection-end-line="45" />
           <folding>
             <element signature="imports" expanded="true" />
             <element signature="e#1262#1263#0" expanded="true" />
@@ -650,8 +647,8 @@
     </entry>
     <entry file="file://$PROJECT_DIR$/Checkbook/src/test/java/CheckbookTest.java">
       <provider selected="true" editor-type-id="text-editor">
-        <state relative-caret-position="-209">
-          <caret line="228" column="5" selection-start-line="228" selection-start-column="5" selection-end-line="228" selection-end-column="5" />
+        <state relative-caret-position="362">
+          <caret line="354" column="94" selection-start-line="354" selection-start-column="94" selection-end-line="354" selection-end-column="94" />
           <folding>
             <element signature="imports" expanded="true" />
           </folding>

Checkbook/src/test/java/CheckbookTest.java

@@ -2,6 +2,7 @@ import org.junit.Assert;
 import org.junit.Test;
 
 import java.time.LocalDate;
+import java.util.Arrays;
 import java.util.NoSuchElementException;
 
 import static org.junit.Assert.*;
@@ -13,7 +14,6 @@ public class CheckbookTest {
     private final double cashAmount = 500.00;
     private final double t2Amount = 100.00;
     private final double t3Amount = 50.00;
-    private final double DELTA = 0.0;
 
     @org.junit.Before
     public void setUp(){
@@ -179,7 +179,7 @@ public class CheckbookTest {
     public void testToArrayFailV2() {
         Transaction[] arrUnEx = {t1, t2};
         Transaction[] arr = {t1};
-        assertFalse(arr.equals(checkbook.toArray(arrUnEx)));
+        assertFalse(Arrays.equals(arr, checkbook.toArray(arrUnEx)));
     }
 
     @Test
@@ -317,31 +317,56 @@ public class CheckbookTest {
 
     @Test
     public void testGetDebits() {
+        Transaction d1 = checkbookWithDefault.getCheckbook().get(0);
+        Transaction d2 = checkbookWithOwner.getCheckbook().get(0);
 
+        Transaction[] expArr =  {d1, d2};
+        checkbookWithDefault.add(d2);
+        assertEquals(expArr, checkbookWithDefault.getSpecificTransactions("typee", TransactionType.DEBIT));
+
+        Transaction[] expArr2 = {d2, d2};
+        checkbookWithOwner.add(d2);
+        assertEquals(expArr2, checkbookWithOwner.getSpecificTransactions("typee", TransactionType.DEBIT));
     }
 
     @Test
     public void testGetDebitsNone() {
+        Transaction[] arr = {};
+
+        checkbook.remove(t2);
 
+        assertEquals(arr, checkbook.getSpecificTransactions("typee", TransactionType.DEBIT));
     }
 
     @Test
-    public void testGetDebitsAdded() {
+    public void testGetDebitsManipulatedCheckbook() {
+        Transaction t = new Transaction("foo", new Payee(), TransactionType.DEBIT, 400.00);
+        Transaction[] arr = {t};
+        checkbook.remove(t2);
+        checkbook.add(t);
 
+        assertEquals(arr, checkbook.getSpecificTransactions("typee", TransactionType.DEBIT));
     }
 
     @Test
     public void testGetCredits() {
-
+        Transaction[] expArr = {t1, t3};
+        assertEquals(expArr, checkbook.getSpecificTransactions("typee", TransactionType.CREDIT));
     }
 
     @Test
     public void testGetCreditsNone() {
-
+        Transaction[] expArr = {};
+        assertEquals(expArr, checkbookWithDefault.getSpecificTransactions("typee", TransactionType.CREDIT));
+        assertEquals(expArr, checkbookWithOwner.getSpecificTransactions("typee", TransactionType.CREDIT));
     }
 
     @Test
-    public void testGetCreditsRemoveAndAdd() {
+    public void testGetCreditsAfterAdding() {
+        Transaction t = new Transaction("bar", new Payee(), TransactionType.CREDIT, 10.00);
+        Transaction[] arr = {t};
 
+        checkbookWithOwner.add(t);
+        assertEquals(arr, checkbookWithOwner.getSpecificTransactions("typee", TransactionType.CREDIT));
     }
 }