ZCW-Lab-Fundamental-Methods

まだコンテンツがありません

Predicate

For the predicate, the comparison sign returns a boolean. So you don't have to do the if statement. You can say

public Boolean isGreaterThan(int x, int y) {
   return x>y;
}

String

For the concat method, a shorter way to concat is this:

    public String concatenation(int firstSegment, String secondSegment){
       return firstSegment + secondSegment;
    }

You don't need to convert the integer to string. Java will do that for you.

For getSuffix, you can inline it into one statement.

    public String getSuffix(String input){
        return input.substring(input.length() - 3);
    }

If you don't inline it, be more descriptive with your variable name.

    public String getSuffix(String input){
        int strLength = input.length();
        int suffixStartIndex = strLength - 3;
        return input.substring(suffixStartIndex);
    }

For compareTwoStrings, getFirstWord, getSecondWord, if you don't need to use the variable, you don't have to create one. So instead of

public Boolean compareTwoStrings(String inputValue, String comparableValue){
        Boolean a = inputValue.equals(comparableValue);
        return a;
    }

You can write it as

public Boolean compareTwoStrings(String inputValue, String comparableValue){
       return inputValue.equals(comparableValue);
    }

For getMiddleCharacter this should not pass all the test.

Please clean up the string and predicate lab and send me a message on slack when you're done.

このプルリクエストは自動的にマージできます。

ログインして議論に参加

ラベルなし

マイルストーンなし

担当者なし

参加者数 2

#12 Finished Fundamental Lab.

Predicate

String