up to paymentpresenter

README.MD

 # Section 2 - Comparable
 Note: You may use the String/Long compareTo methods in your code
 1. Edit the `Payment` class to extends the Comparable interface
-  - `public class Payment extends Comparable<Payment>`
+  - `public interface Payment extends Comparable<Payment>`
   - This indicate that payment can be comparable, which means it can be sorted
 2. Fix the syntax error in your CreditCard, Check, and Paypal class by adding the compare method
 3. Create a test for the `compareTo` method. Compare using the getShortDescription()
     Payment check = new Check(81L, "Tia Mowry", "11432543", "134344551")
 
     payment[0] = paypal;
-
+    payment[1] = check;
+    
     PaymentPresenter presenter = new PaymentPresenter();
     String expected = "Check Tia Mowry ***4551\nPaypal Tia Mowry tia@mowry.com\n";
 
       Payment check = new Check(81L, "Tia Mowry", "11432543", "134344551")
 
       payment[0] = paypal;
+      payment[1] = check;
 
       PaymentPresenter presenter = new PaymentPresenter();
       String expected = "Paypal Tamara Mowry tamara@mowry.com\nCheck Tia Mowry ***4551\n";
 
-      String actual = presenter.toString(payments);
+      String actual = presenter.toStringByPayerName(payments);
       assertEquals(expected, actual);
     ```
     
       Payment check = new Check(81L, "Tia Mowry", "11432543", "134344551")
 
       payment[0] = paypal;
+      payment[1] = check;
 
       PaymentPresenter presenter = new PaymentPresenter();
       String expected = "Paypal Tamara Mowry tamara@mowry.com\nCheck Tia Mowry ***4551\n";
 
-      String actual = presenter.toString(payments);
+      String actual = presenter.toStringById(payments);
       assertEquals(expected, actual);
     ```

pom.xml

     <groupId>com.zipcoder</groupId>
     <artifactId>payment</artifactId>
     <version>1.0-SNAPSHOT</version>
-
+    <dependencies>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>RELEASE</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
+    <properties>
+        <maven.compiler.source>1.8</maven.compiler.source>
+        <maven.compiler.target>1.8</maven.compiler.target>
+    </properties>
 
 </project>

src/main/java/com/zipcoder/payment/Check.java

 package com.zipcoder.payment;
 
-public class Check implements Payment {
+public class Check implements Payments{
 
-    private Long id;
-    private String payerName;
-    private String routingNumber;
-    private String accountNumber;
 
-    public Check(Long id, String payerName, String routingNumber, String accountNumber) {
+	Long id;
+	String payerName;
+	String routingNumber;
+	String accountNumber;
 
-        this.id = id;
-        this.payerName = payerName;
-        this.routingNumber = routingNumber;
-        this.accountNumber = accountNumber;
-    }
+	public Check(Long id, String payerName, String routingNumber, String accountNumber) {
+		this.id = id;
+		this.payerName = payerName;
+		this.routingNumber = routingNumber;
+		this.accountNumber = accountNumber;
+	}
 
-    public String getRoutingNumber() {
-        return routingNumber;
-    }
+	public Check(){}
 
-    public void setRoutingNumber(String routingNumber) {
-        this.routingNumber = routingNumber;
-    }
+	public Long getId() {
+		return id;
+	}
 
-    public String getAccountNumber() {
-        return accountNumber;
-    }
+	public String getRoutingNumber() {
+		return routingNumber;
+	}
 
-    public void setAccountNumber(String accountNumber) {
-        this.accountNumber = accountNumber;
-    }
+	public void setRoutingNumber(String routingNumber) {
+		this.routingNumber = routingNumber;
+	}
 
-    public Long getId() {
-        return id;
-    }
+	public String getAccountNumber() {
+		return accountNumber;
+	}
 
-    public void setId(Long id) {
-        this.id = id;
-    }
+	public void setAccountNumber(String accountNumber) {
+		this.accountNumber = accountNumber;
+	}
 
-    public String getPayerName() {
-        return payerName;
-    }
+	@Override
+	public Long getID() {
+		return id;
+	}
 
-    public void setPayerName(String payerName) {
-        this.payerName = payerName;
-    }
+	@Override
+	public void setId(Long id) {
+	this.id = id;
+	}
 
-    public String getShortDescription() {
-        return "Check " + payerName + " ***" + accountNumber.substring(accountNumber.length() - 4, accountNumber.length());
-    }
+	@Override
+	public String getPayerName() {
+		return payerName;
+	}
 
-    public int compareTo(Payment o) {
-        return this.id.compareTo(o.getId());
-    }
-}
+	@Override
+	public String getShortDescription() {
+		return "Check " + payerName + " ***"+ accountNumber.substring(accountNumber.length()-4, accountNumber.length());
+	}
+
+	@Override
+	public void setPayerName(String payerName) {
+	 this.payerName = payerName;
+	}
+
+	@Override
+	public int compareTo(Payments o) {
+		return this.getShortDescription().compareTo(o.getShortDescription());
+	}
+}

src/main/java/com/zipcoder/payment/CreditCard.java

 package com.zipcoder.payment;
 
-public class CreditCard implements Payment {
-
-    private Long id;
-    private String payerName;
-    private String number;
-    private int expiredMonth;
-    private int expiredYear;
-
-    public CreditCard() {
-    }
-
-    public CreditCard(Long id, String payerName, String number, int expiredMonth, int expiredYear) {
-        this.id = id;
-        this.payerName = payerName;
-        this.number = number;
-        this.expiredMonth = expiredMonth;
-        this.expiredYear = expiredYear;
-    }
-
-    public int getExpiredYear() {
-        return expiredYear;
-    }
-
-    public void setExpiredYear(int expiredYear) {
-        this.expiredYear = expiredYear;
-    }
-
-    public String getNumber() {
-        return number;
-    }
-
-    public void setNumber(String number) {
-        this.number = number;
-    }
-
-    public int getExpiredMonth() {
-        return expiredMonth;
-    }
-
-    public void setExpiredMonth(int expiredMonth) {
-        this.expiredMonth = expiredMonth;
-    }
-
-    public Long getId() {
-        return id;
-    }
-
-    public void setId(Long id) {
-        this.id = id;
-    }
-
-    public String getPayerName() {
-        return payerName;
-    }
-
-    public void setPayerName(String payerName) {
-        this.payerName = payerName;
-    }
-
-    public String getShortDescription() {
-        String lastFourDigitsOfNumber = number.substring(number.length() - 4, number.length());
-        String expiredMonthStringValue = String.valueOf(expiredMonth);
-        if (expiredMonth < 10) {
-            expiredMonthStringValue = "0" + expiredMonthStringValue;
-        }
-        return "CC " + payerName + " " + lastFourDigitsOfNumber + " " + expiredMonthStringValue + "/" + expiredYear;
-    }
-
-    public int compareTo(Payment o) {
-        return this.id.compareTo(o.getId());
-    }
+public class CreditCard implements Payments{
 
+
+	Long id;
+	String payerName;
+	String number;
+	int expiredMonth;
+	int expiredYear;
+
+	public CreditCard(Long id, String payerName, String number, int expiredMonth, int expiredYear) {
+		this.id = id;
+		this.payerName = payerName;
+		this.number = number;
+		this.expiredMonth = expiredMonth;
+		this.expiredYear = expiredYear;
+	}
+
+	public CreditCard(){}
+
+	public String getNumber() {
+		return number;
+	}
+
+	public void setNumber(String number) {
+		this.number = number;
+	}
+
+	public int getExpiredMonth() {
+		return expiredMonth;
+	}
+
+	public void setExpiredMonth(int expiredMonth) {
+		this.expiredMonth = expiredMonth;
+	}
+
+	public int getExpiredYear() {
+		return expiredYear;
+	}
+
+	public void setExpiredYear(int expiredYear) {
+		this.expiredYear = expiredYear;
+	}
+
+
+
+	public void setId(Long id) {
+		this.id = id;
+	}
+
+	public Long getID() {
+		return id;
+	}
+
+
+	public String getPayerName() {
+		return payerName;
+	}
+
+
+	public String getShortDescription() {
+		return "CC " + payerName + " "+number.substring(number.length()-4, number.length())+" "+expiredMonth+"/"+expiredYear;
+	}
+
+
+	public void setPayerName(String payerName) {
+		this.payerName = payerName;
+	}
+
+	@Override
+	public int compareTo(Payments o) {
+		return this.getShortDescription().compareTo(o.getShortDescription());
+	}
+
+
+//	@Override
+//	public int compareTo(Payments o) {
+//		return 0;
+//	}
 }

src/main/java/com/zipcoder/payment/Payment.java

-package com.zipcoder.payment;
-
-public interface Payment extends Comparable<Payment> {
-    Long getId();
-
-    String getPayerName();
-
-    String getShortDescription();
-
-    int compareTo(Payment o);
-}

src/main/java/com/zipcoder/payment/PaymentPresenter.java

 package com.zipcoder.payment;
 
-import java.util.Arrays;
+		import java.util.Arrays;
+		import java.util.Comparator;
 
 public class PaymentPresenter {
 
-
-    public String toString(Payment[] payments) {
-
-        Arrays.sort(payments, new PaymentSortByShortDescription());
-
-        return createString(payments);
-    }
-
-    public String toStringByPayerName(Payment[] payments) {
-        Arrays.sort(payments, new PaymentSortByPayer());
-
-        return createString(payments);
-    }
-
-    public String toStringById(Payment[] payments) {
-        Arrays.sort(payments);
-
-        return createString(payments);
-    }
-
-    private String createString(Payment[] payments) {
-        String retVal = "";
-        for (Payment payment : payments) {
-            retVal += payment.getShortDescription() + "\n";
-        }
-        return retVal;
-    }
-}
+	public String toString(Payments[] payments) {
+		StringBuilder sb = new StringBuilder();
+		Arrays.sort(payments);
+		for (int i = 0; i < payments.length; i++) {
+			payments[i].getShortDescription().toString();
+		}
+		return null;
+	}
+}

src/main/java/com/zipcoder/payment/PaymentSortByPayer.java

 package com.zipcoder.payment;
-
 import java.util.Comparator;
 
-public class PaymentSortByPayer implements Comparator<Payment> {
+public class PaymentSortByPayer implements Comparator<Payments>{
+
+
+
+	public int compare(Payments o1, Payments o2) {
 
-    public int compare(Payment o1, Payment o2) {
-        return o1.getPayerName().compareTo(o2.getPayerName());
-    }
+		return o1.getPayerName().compareTo(o2.getPayerName());
+	}
 }

src/main/java/com/zipcoder/payment/PaymentSortByShortDescription.java

-package com.zipcoder.payment;
-
-import java.util.Comparator;
-
-public class PaymentSortByShortDescription implements Comparator<Payment> {
-    public int compare(Payment o1, Payment o2) {
-        return o1.getShortDescription().compareTo(o2.getShortDescription());
-    }
-}

src/main/java/com/zipcoder/payment/Payments.java

+package com.zipcoder.payment;
+
+public interface Payments extends Comparable<Payments>{
+
+	public Long getID();
+	public void setId(Long id);
+	public String getPayerName();
+	public String getShortDescription();
+
+	void setPayerName(String payerName);
+}
+
+

src/main/java/com/zipcoder/payment/Paypal.java

 package com.zipcoder.payment;
 
-public class Paypal implements Payment {
+public class Paypal implements Payments {
 
-    private Long id;
-    private String payerName;
-    private String email;
+	Long id;
+	String payerName;
+	String email;
 
-    public Paypal(Long id, String payerName, String email) {
 
-        this.id = id;
-        this.payerName = payerName;
-        this.email = email;
-    }
+	public Paypal(Long id, String payerName, String email) {
+		this.id = id;
+		this.payerName = payerName;
+		this.email = email;
+	}
 
-    public Long getId() {
-        return id;
-    }
+	Paypal(){}
 
-    public void setId(Long id) {
-        this.id = id;
-    }
+	public String getEmail() {
+		return email;
+	}
 
-    public String getPayerName() {
-        return payerName;
-    }
+	public void setEmail(String email) {
+		this.email = email;
+	}
 
-    public String getShortDescription() {
-        return "Paypal " + payerName + " " + email;
-    }
+	@Override
+	public Long getID() {
+		return id;
+	}
 
-    public int compareTo(Payment o) {
-        return this.id.compareTo(o.getId());
-    }
+	@Override
+	public void setId(Long id) {
+		this.id = id;
+	}
+
+	@Override
+	public String getPayerName() {
+		return payerName;
+	}
+
+	@Override
+	public String getShortDescription() {
+		return "Paypal "+ payerName+ email;
+	}
+
+	@Override
+	public void setPayerName(String payerName) {
+		this.payerName = payerName;
+	}
+
+	@Override
+	public int compareTo(Payments o) {
+
+		return this.getShortDescription().compareTo(o.getShortDescription());
+	}
 }

src/test/java/com/zipcoder/payment/CheckTest.java

 package com.zipcoder.payment;
 
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
 
 public class CheckTest {
+	Check test = new Check();
 
-    @Test
-    public void getShortDescriptionTest() {
-        // Arrange
-        Check check = new Check(81L, "Tia Mowry", "11432543", "134344551");
-        String expected = "Check Tia Mowry ***4551";
 
-        // Act
-        String actual = check.getShortDescription();
+	@Before
+	public void setup() {
+	}
 
-        // Assert
-        Assert.assertEquals(expected, actual);
-    }
-}
+	@Test
+	public void getIdTest() {
+		//When
+		test.setId(23L);
+
+		// Expect
+		Long expect = 23L;
+
+		//Actual
+		Long actual = test.getID();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+	@Test
+	public void setIdTest() {
+		test.setId(30L);
+
+		Long expect = 30L;
+
+		Long actual = test.getID();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+
+	@Test
+	public void getPayerName() {
+		test.setPayerName("Tia Mowry");
+
+		String expect = "Tia Mowry";
+		String actual = test.getPayerName();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+	@Test
+	public void getShortDescription() {
+		test.setPayerName("Tia Mowry");
+		test.setAccountNumber("4551");
+
+		String expect = "Check Tia Mowry ***4551";
+		String actual = test.getShortDescription();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+	@Test
+	public void getAccountNumber() {
+		test.setAccountNumber("4551");
+
+		String expect = "4551";
+		String actual = test.getAccountNumber();
+
+		Assert.assertEquals(expect, actual);
+
+	}
+
+	@Test
+	public void getRoutingNumber() {
+		test.setRoutingNumber("904551");
+
+		String expect = "904551";
+		String actual = test.getRoutingNumber();
+
+		Assert.assertEquals(expect, actual);
+
+	}
+
+
+	@Test
+	public void compareToTest() {
+
+		test.setPayerName("Tia Mowry");
+		test.setAccountNumber("904551");
+
+		Check test1 = new Check();
+		test1.setPayerName("Tia Mowry");
+		test1.setAccountNumber("904551");
+
+		int actual = test.getShortDescription().compareTo(test1.getShortDescription());
+		Assert.assertTrue(actual == 0);
+
+	}
+}

src/test/java/com/zipcoder/payment/CreditCardTest.java

 package com.zipcoder.payment;
 
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
 
 public class CreditCardTest {
+	CreditCard test = new CreditCard();
 
-    @Test
-    public void idTest() {
-        // Arrange
-        CreditCard creditCard = new CreditCard();
-        Long expectedId = 100L;
-        creditCard.setId(expectedId);
-
-        // Act
-        Long actualId = creditCard.getId();
-
-        // Assert
-        Assert.assertEquals(expectedId, actualId);
-    }
-
-    @Test
-    public void payerNameTest() {
-        // Arrange
-        CreditCard creditCard = new CreditCard();
-        String expectedPayerName = "Joe";
-        creditCard.setPayerName(expectedPayerName);
-
-        // Act
-        String actualPayerName = creditCard.getPayerName();
-
-        // Assert
-        Assert.assertEquals(expectedPayerName, actualPayerName);
-    }
-
-    @Test
-    public void numberTest() {
-        // Arrange
-        CreditCard creditCard = new CreditCard();
-        String expectedNumber = "12345";
-        creditCard.setNumber(expectedNumber);
-
-        // Act
-        String actualNumber = creditCard.getNumber();
-
-        // Assert
-        Assert.assertEquals(expectedNumber, actualNumber);
-    }
-
-    @Test
-    public void expiredMonthTest() {
-        // Arrange
-        CreditCard creditCard = new CreditCard();
-        int expectedExpiredMonth = 2;
-        creditCard.setExpiredMonth(expectedExpiredMonth);
-
-        // Act
-        int actualExpiredMonth = creditCard.getExpiredMonth();
-
-        // Assert
-        Assert.assertEquals(expectedExpiredMonth, actualExpiredMonth);
-    }
-
-    @Test
-    public void expiredYearTest() {
-        // Arrange
-        CreditCard creditCard = new CreditCard();
-        int expectedExpiredYear = 2019;
-        creditCard.setExpiredYear(expectedExpiredYear);
-
-        // Act
-        int actualExpiredYear = creditCard.getExpiredYear();
-
-        // Assert
-        Assert.assertEquals(expectedExpiredYear, actualExpiredYear);
-    }
-
-    @Test
-    public void getShortDescription_DoubleDigitMonth_ShouldReturnShortDescription() {
-        // Arrange
-        CreditCard creditCard = new CreditCard(284914091L, "John Doe", "1234567890123456", 11, 2001);
-        String expectedShortDescription = "CC John Doe 3456 11/2001";
-
-        // Act
-        String actualShortDescription = creditCard.getShortDescription();
-
-        // Assert
-        Assert.assertEquals(expectedShortDescription, actualShortDescription);
-    }
-
-    @Test
-    public void getShortDescription_SingleDigitMonth_ShouldReturnShortDescription() {
-        // Arrange
-        CreditCard creditCard = new CreditCard(284914091L, "John Doe", "1234567890123456", 1, 2001);
-        String expectedShortDescription = "CC John Doe 3456 01/2001";
-
-        // Act
-        String actualShortDescription = creditCard.getShortDescription();
-
-        // Assert
-        Assert.assertEquals(expectedShortDescription, actualShortDescription);
-    }
-}
+
+	@Before
+	public void setup() {
+	}
+
+	@Test
+	public void getIdTest() {
+		//When
+		test.setId(23L);
+
+		// Expect
+		Long expect = 23L;
+
+		//Actual
+		Long actual = test.getID();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+	@Test
+	public void setIdTest() {
+		test.setId(30L);
+
+		Long expect = 30L;
+
+		Long actual = test.getID();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+
+	@Test
+	public void getPayerName() {
+		test.setPayerName("Tia Mowry");
+
+		String expect = "Tia Mowry";
+		String actual = test.getPayerName();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+	@Test
+	public void getShortDescription() {
+		test.setPayerName("Tia Mowry");
+		test.setNumber("4551");
+		test.setExpiredMonth(10);
+		test.setExpiredYear(2019);
+
+
+		String expect = "CC Tia Mowry 4551 10/2019";
+		String actual = test.getShortDescription();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+	@Test
+	public void getNumberTest() {
+		test.setNumber("4551");
+
+		String expect = "4551";
+		String actual = test.getNumber();
+
+		Assert.assertEquals(expect, actual);
+
+	}
+
+
+	@Test
+	public void getExpiredMonth() {
+		test.setExpiredMonth(9);
+
+		int expect = 9;
+		int actual = test.getExpiredMonth();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+	@Test
+	public void compareToTest() {
+
+		test.setPayerName("Tia Mowry");
+		test.setNumber("4551");
+
+		Check test1 = new Check();
+		test1.setPayerName("Tia Mowry");
+		test1.setAccountNumber("***4551");
+
+		int actual = test.getShortDescription().compareTo(test1.getShortDescription());
+		Assert.assertTrue(actual < 0);
+	}
+}

src/test/java/com/zipcoder/payment/PaymentPresenterTest.java

+package com.zipcoder.payment;
+
+import java.util.Arrays;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class PaymentPresenterTest {
+
+
+	@Before
+	public void setup() {
+		StringBuilder sb = new StringBuilder();
+	}
+
+
+
+	@Test
+	public void toStringNoPayment() {
+
+		Payments[] payments = new Payments[0];
+		PaymentPresenter presenter = new PaymentPresenter();
+		String expected = "";
+
+		String actual = presenter.toString(payments);
+
+		assertEquals(expected, actual);
+	}
+
+	@Test
+
+	public void multiplesToStringById() {
+
+	}
+
+}

src/test/java/com/zipcoder/payment/PaymentSortByPayerTest.java

+package com.zipcoder.payment;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+public class PaymentSortByPayerTest {
+
+	CreditCard check1;
+	Check check2;
+
+	PaymentSortByPayer paymentSortByPayer;
+
+	@Before
+
+	public void setup(){
+		paymentSortByPayer = new PaymentSortByPayer();
+		check1 = new CreditCard(0L,"James","4033",10,2000);
+		check2 = new Check(201111L, "James", "334344", "343423434");
+	}
+
+	@Test
+	public void compareTest(){
+
+		int actual = paymentSortByPayer.compare(check1, check2);
+
+		Assert.assertTrue(actual ==0);
+	}
+}

src/test/java/com/zipcoder/payment/PaypalTest.java

+package com.zipcoder.payment;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+
+public class PaypalTest {
+
+	Paypal test;
+
+	@Before
+	public void setup() {
+		test = new Paypal();
+	}
+
+	@Test
+	public void getID() {
+		//When
+		test.setId(23L);
+
+		// Expect
+		Long expect = 23L;
+
+		//Actual
+		Long actual = test.getID();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+
+	@Test
+	public void getPayerName() {
+		//When
+		test.setPayerName("Tia Mowry");
+
+		// Expect
+		String expect = "Tia Mowry";
+
+		//Actual
+		String actual = test.getPayerName();
+
+		Assert.assertEquals(expect, actual);
+	}
+
+
+	@Test
+	public void getShortDescription() {
+		test.setPayerName("Tia Mowry");
+		test.setEmail("tia@mowry.com");
+
+		String expect = "Paypal Tia Mowry tia@mowry.com";
+		String actual = test.getShortDescription();
+	}
+
+	@Test
+	public void compareTo() {
+		test.setPayerName("Tia Mowry");
+		test.setEmail("tia@mowry.com");
+
+		Check test1 = new Check();
+		test1.setPayerName("Tia Mowry");
+		test1.setAccountNumber("***4551");
+
+		int actual = test.getShortDescription().compareTo(test1.getShortDescription());
+		Assert.assertTrue(actual > 0);
+
+	}
+}

src/test/java/com/zipcoder/payment/PaypalTests.java

-package com.zipcoder.payment;
-
-import org.junit.Assert;
-import org.junit.Test;
-
-public class PaypalTests {
-
-    @Test
-    public void getShortDescriptionTest() {
-        // Arrange
-        Paypal paypal = new Paypal(100L, "Tia Mowry", "tia@mowry.com");
-        String expectedShortDescription = "Paypal Tia Mowry tia@mowry.com";
-
-        // Act
-        String actualShortDescription = paypal.getShortDescription();
-
-        // Assert
-        Assert.assertEquals(expectedShortDescription, actualShortDescription);
-    }
-}