off by 1

src/main/java/com/zipcoder/payment/Check.java

@@ -6,10 +6,12 @@ public class Check implements Payment{
     String routingNumber;
     String accountNumber;
 
-    public Check () {}
 
-    public Check(Long id, String payerName, String accountNumber, String routingNumber){
+    public Check () {}
 
+    public Check(Long id, String payerName, String routingNumber, String accountNumber){
+        this.id = id; this.payerName = payerName;
+        this.accountNumber = lastFourAccount(accountNumber); this.routingNumber = routingNumber;
     }
 
     @Override
@@ -35,7 +37,6 @@ public class Check implements Payment{
 
     }
 
-
     @Override
     public String getShortDescription() {
         return "Check " + getPayerName() + " ***" + getAccountNumber();
@@ -55,6 +56,7 @@ public class Check implements Payment{
 
     public void setAccountNumber(String accountNumber) {
         this.accountNumber = accountNumber;
+
     }
 
 

src/main/java/com/zipcoder/payment/CheckTest.java

@@ -103,4 +103,14 @@ public class CheckTest {
 
         assertEquals(expected, actual);
     }
+
+    @Test
+    public void lastFourAccount() {
+        String x = "1234567";
+
+        String expected = "4567";
+        String actual = check.lastFourAccount(x);
+
+        assertEquals(expected, actual);
+    }
 }

src/main/java/com/zipcoder/payment/PaymentPresenter.java

@@ -6,15 +6,32 @@ public class PaymentPresenter {
 
 
     public String toString(Payment[] payment) {
+        Arrays.sort(payment);
 
-        if (payment.length > 1)
-            return payment[0].getShortDescription() + "\n" + payment[1].getShortDescription() + "\n";
-        else return Arrays.toString(payment).replace("[]", "");
+        StringBuilder build = new StringBuilder();
+        for(Payment o : payment) build.append(o.getShortDescription()+"\n");
+        return build.toString();
 
-        for (Payment o : payment){
-             o.getId(); o.getPayerName();
+//             o.getId(); o.getPayerName();
         }
+
+    public String toStringByPayerName(Payment[] payment) {
+        Arrays.sort(payment, new PaymentSortByPayer());
+
+        StringBuilder build = new StringBuilder();
+        for(Payment o : payment) build.append(o.getShortDescription()+"\n");
+        return build.toString();
+    }
+
+    public String toStringById(Payment[] payment) {
+        Arrays.sort(payment, new PaymentSortByPayer());
+
+        StringBuilder build = new StringBuilder();
+        for(Payment o : payment) build.append(o.getShortDescription()+"\n");
+        return build.toString();
     }
+}
+
 
 
 
@@ -22,4 +39,3 @@ public class PaymentPresenter {
 
 
 
-}

src/main/java/com/zipcoder/payment/PaymentPresenterTest.java

@@ -21,8 +21,8 @@ public class PaymentPresenterTest {
     @Test
     public void toStringMultiplePayments() {
         Payment[] payment = new Payment[2];
-        Paypal paypal = new Paypal(4L, "Tia Mowry", "tia@mowry.com");
-        Check check = new Check(81L, "Tia Mowry", "11432543", "134344551");
+        Payment paypal = new Paypal(4L, "Tia Mowry", "tia@mowry.com");
+        Payment check = new Check(81L, "Tia Mowry", "11432543", "134344551");
 
 
         payment[0] = paypal;
@@ -35,10 +35,38 @@ public class PaymentPresenterTest {
         assertEquals(expected, actual);
     }
 
-//        paypal.setId(4L); paypal.setPayerName("Tia Mowry"); paypal.setEmail("tia@mowry.com");
-//        check.setId(81L); check.setPayerName("Tia Mowry"); check.setAccountNumber("11432543");
-//        check.setRoutingNumber("134344551");
+    @Test
+    public void toStringByPayerName() {
+        Payment[] payment = new Payment[2];
+        Payment paypal = new Paypal(4L, "Tamara Mowry", "tamara@mowry.com");
+        Payment check = new Check(81L, "Tia Mowry", "11432543", "134344551");
+
+        payment[0] = paypal;
+        payment[1] = check;
+
+        PaymentPresenter presenter = new PaymentPresenter();
+        String expected = "Paypal Tamara Mowry tamara@mowry.com\nCheck Tia Mowry ***4551\n";
+
+        String actual = presenter.toStringByPayerName(payment);
+        assertEquals(expected, actual);
+    }
+
+    @Test
+    public void toStringById() {
+        Payment[] payment = new Payment[2];
+        Payment paypal = new Paypal(120L, "Tamara Mowry", "tamara@mowry.com");
+        Payment check = new Check(81L, "Tia Mowry", "11432543", "134344551");
+
+        payment[0] = paypal;
+        payment[1] = check;
+
+        PaymentPresenter presenter = new PaymentPresenter();
+        String expected = "Paypal Tia Mowry tamara@mowry.com\nCheck Tamara Mowry ***4551\n";
+
+        String actual = presenter.toStringById(payment);
+        assertEquals(expected, actual);
 
     }
+}
 
 

src/main/java/com/zipcoder/payment/PaymentSortByPayer.java

@@ -0,0 +1,14 @@
+package com.zipcoder.payment;
+
+import java.util.Comparator;
+
+public class PaymentSortByPayer implements Comparator<Payment> {
+
+    public PaymentSortByPayer(){
+
+    }
+
+    public int compare(Payment o1, Payment o2) {
+        return o1.getPayerName().compareTo(o2.getPayerName());
+    }
+}

src/main/java/com/zipcoder/payment/Paypal.java

@@ -8,6 +8,7 @@ public class Paypal implements Payment{
     public Paypal () {}
 
     public Paypal(Long id, String payerName, String email){
+        this.id = id; this.payerName = payerName; this.email = email;
 
     }