refactored some of my test classes. Im think im getting better at TDD

src/main/java/com/zipcoder/payment/Check.java

@@ -25,7 +25,7 @@ public class Check implements Payment {
     }
 
     public String getShortDescription() {
-        return String.format("Check %s ****%d", this.getPayerName(), lastFourDigits());
+        return String.format("Check %s ****%d\n", this.getPayerName(), lastFourDigits());
     }
 
     public int lastFourDigits(){

src/main/java/com/zipcoder/payment/CreditCard.java

@@ -61,7 +61,7 @@ public class CreditCard implements Payment {
     }
 
     public String getShortDescription() {
-        return String.format("CC %s %d %d/%d", this.payerName, this.lastFourDigits(), this.expiredMonth, this.expiredYear);
+        return String.format("CC %s %d %d/%d\n", this.payerName, this.lastFourDigits(), this.expiredMonth, this.expiredYear);
     }
 
     public int lastFourDigits(){

src/main/java/com/zipcoder/payment/Paypal.java

@@ -40,7 +40,7 @@ public class Paypal implements Payment {
 
 
     public String getShortDescription() {
-        return String.format("Paypal %s %s", this.payerName, this.email);
+        return String.format("Paypal %s %s\n", this.payerName, this.email);
     }
 
     public int compareTo(Payment o) {

src/test/java/com/zipcoder/payment/CheckTest.java

@@ -1,52 +1,70 @@
 package com.zipcoder.payment;
 
 import static org.junit.Assert.*;
+import org.junit.Before;
 import org.junit.Test;
 
 public class CheckTest {
 
+    Check ck;
+
+    @Before
+    public void before(){
+        this.ck = new Check(45, "Nicholas M", "445784", "4451884");
+    }
+
     @Test
     public void getId() {
-        //When
-        Check ck = new Check();
-        ck.setId(4456);
-
         //Expect
-        long expected = 4456;
+        long expected = 45;
 
         //Actual
         long actual =  ck.getId();
-
         assertEquals(expected, actual);
     }
 
     @Test
-    public void getPayerName() {
+    public void setId(){
         //When
-        Check ck = new Check();
-        ck.setPayerName("Nicholas");
+        ck.setId(50);
 
         //Expect
-        String expected = "Nicholas";
+        long expect = 50;
 
         //Actual
-        String acual = ck.getPayerName();
-        assertEquals(expected, acual);
+        long actual = ck.getId();
+        assertEquals(expect, actual);
     }
 
     @Test
-    public void getShortDescription() {
-    }
+    public void getPayerName() {
+        //Expect
+        String expected = "Nicholas M";
+
+        //Actual
+        String actual = ck.getPayerName();
 
+        assertEquals(expected, actual);
+    }
 
     @Test
-    public void getRoutingNumber() {
+    public void setPayerName(){
         //When
-        Check ck = new Check();
-        ck.setRoutingNumber("4532353");
+        ck.setPayerName("Dan Smith");
 
         //Expect
-        String expected = "4532353";
+        String expect = "Dan Smith";
+
+        //Actual
+        String actual = ck.getPayerName();
+
+        assertEquals(expect, actual);
+    }
+
+    @Test
+    public void getRoutingNumber() {
+        //Expect
+        String expected = "445784";
 
         //Actual
         String actual = ck.getRoutingNumber();
@@ -57,7 +75,6 @@ public class CheckTest {
     @Test
     public void setRoutingNumber() {
         //When
-        Check ck = new Check();
         ck.setRoutingNumber("4532353");
 
         //Expect
@@ -71,7 +88,6 @@ public class CheckTest {
     @Test
     public void setAccountNumber() {
         //When
-        Check ck = new Check();
         ck.setAccountNumber("4532353");
 
         //Expect
@@ -83,41 +99,9 @@ public class CheckTest {
     }
 
     @Test
-    public void setPayerName() {
-        //When
-        Check ck = new Check();
-        ck.setPayerName("Nick M");
-
-        //Expect
-        String expected = "Nick M";
-
-        //Actual
-        String actual = ck.getPayerName();
-        assertEquals(expected,actual);
-    }
-
-    @Test
-    public void setId() {
-        //When
-        Check ck = new Check();
-        ck.setId(3423);
-
-        //Expect
-        long expected = 3423;
-
-        //Actual
-        long actual =  ck.getId();
-
-        assertEquals(expected, actual);
-    }
-
-    @Test
     public void getAccountNumber() {
-        //When
-        Check ck = new Check();
-        ck.setAccountNumber("893456");
         //Expect
-        String expected = "893456";
+        String expected = "4451884";
 
         //Actual
         String actual = ck.getAccountNumber();
@@ -127,12 +111,9 @@ public class CheckTest {
     }
 
     @Test
-    public void getShortDescription1() {
-        //When
-        Check ck = new Check(4563, "Nicholas Maidanos", "45335665", "444545");
-
+    public void getShortDescriptionTest() {
         //Expect
-        String expected = "Check Nicholas Maidanos ****4545";
+        String expected = "Check Nicholas M ****1884\n";
 
         //Actual
         String actual = ck.getShortDescription();

src/test/java/com/zipcoder/payment/CreditCardTest.java

@@ -7,14 +7,17 @@ import org.junit.Test;
 
 public class CreditCardTest {
 
+    CreditCard cc;
+
+    @Before
+    public void begin(){
+        this.cc = new CreditCard(12, 4111131,"Nicholas Maidanos", 4, 2011);
+    }
+
     @Test
     public void getIdTest(){
-        //When
-        CreditCard cc = new CreditCard();
-        cc.setId(100);
-
         //Expect
-        long expected = 100;
+        long expected = 12;
 
         //Actual
         long actual =  cc.getId();
@@ -25,7 +28,6 @@ public class CreditCardTest {
     @Test
     public void setIdTest(){
         //When
-        CreditCard cc = new CreditCard();
         cc.setId(100);
 
         //Expect
@@ -40,10 +42,6 @@ public class CreditCardTest {
 
     @Test
     public void getNameTest(){
-        //When
-        CreditCard cc = new CreditCard();
-        cc.setPayerName("Nicholas Maidanos");
-
         //Expect
         String expected = "Nicholas Maidanos";
 
@@ -54,9 +52,33 @@ public class CreditCardTest {
     }
 
     @Test
-    public void SetNumTest(){
+    public void setNameTest(){
+        //When
+        cc.setPayerName("Dan Smith");
+
+        //Expect
+        String expect = "Dan Smith";
+
+        //Actual
+        String actual = cc.getPayerName();
+
+        assertEquals(expect, actual);
+    }
+
+    @Test
+    public void getNumTest(){
+        //Expect
+        long expected = 4111131;
+
+        //Actual
+        long actual = cc.getNumber();
+
+        assertEquals(expected, actual);
+    }
+
+    @Test
+    public void setNumTest(){
         //When
-        CreditCard cc = new CreditCard();
         cc.setNumber(411111111);
 
         //Expect
@@ -70,12 +92,8 @@ public class CreditCardTest {
 
     @Test
     public void getMonthTest(){
-        //When
-        CreditCard cc = new CreditCard();
-        cc.setExpiredMonth(12);
-
         //Expect
-        int expected = 12;
+        int expected = 4;
 
         //Actual
         int actual =  cc.getExpiredMonth();
@@ -86,7 +104,6 @@ public class CreditCardTest {
     @Test
     public void setMonthTest(){
         //When
-        CreditCard cc = new CreditCard();
         cc.setExpiredMonth(12);
 
         //Expect
@@ -99,13 +116,9 @@ public class CreditCardTest {
     }
 
     @Test
-    public void setYearTest(){
-        //When
-        CreditCard cc = new CreditCard();
-        cc.setExpiredYear(1989);
-
+    public void getYearTest(){
         //Expect
-        int expected = 1989;
+        int expected = 2011;
 
         //Actual
         int actual =  cc.getExpiredYear();
@@ -114,9 +127,8 @@ public class CreditCardTest {
     }
 
     @Test
-    public void getYearTest(){
+    public void setYearTest(){
         //When
-        CreditCard cc = new CreditCard();
         cc.setExpiredYear(1989);
 
         //Expect
@@ -130,11 +142,8 @@ public class CreditCardTest {
 
     @Test
     public void getAndShortDescriptionTest(){
-        //When
-        CreditCard cc = new CreditCard(12, 4111131,"Nicholas Maidanos", 4, 11);
-
         //Expect
-        String expected = "CC Nicholas Maidanos 1131 4/11";
+        String expected = "CC Nicholas Maidanos 1131 4/2011\n";
 
         //Actual
         String actual = cc.getShortDescription();
@@ -142,19 +151,6 @@ public class CreditCardTest {
     }
 
     @Test
-    public void testGetLastFourDigits(){
-        //Given
-        CreditCard cc = new CreditCard();
-        cc.setNumber(888999);
-        Integer expected = 8999;
-
-        //When
-        Integer actual = cc.lastFourDigits();
-        assertEquals(expected, actual);
-
-    }
-
-    @Test
     public void compareToTest() {
         //Given
         Payment cc = new CreditCard(12, 4111131,"Nicholas Maidanos", 4, 11);

src/test/java/com/zipcoder/payment/PaypalTest.java

@@ -2,32 +2,35 @@ package com.zipcoder.payment;
 
 
 import static org.junit.Assert.*;
+import org.junit.Before;
 import org.junit.Test;
 
 public class PaypalTest {
 
+    Paypal pp;
+
+    @Before
+    public void setup(){
+        this.pp = new Paypal(50, "Nicholas Maidanos", "nmaidanos@gmail.com");
+    }
+
     @Test
-    void setId() {
+    public void setId() {
         //When
-        Paypal pp = new Paypal();
-        pp.setId(75);
+        pp.setId(48);
 
         //Expect
-        long expect = 75;
+        long expect = 48;
 
         //Actual
-        long actual = pp.getId();
+        long actual = this.pp.getId();
         assertEquals(expect, actual);
     }
 
     @Test
-    void getId() {
-        //When
-        Paypal pp = new Paypal();
-        pp.setId(75);
-
+    public void getId() {
         //Expect
-        long expect = 75;
+        long expect = 50;
 
         //Actual
         long actual = pp.getId();
@@ -35,13 +38,12 @@ public class PaypalTest {
     }
 
     @Test
-    void setPayerName() {
+    public void setPayerName() {
         //When
-        Paypal pp =  new Paypal();
-        pp.setPayerName("Nicholas Maidanos");
+        pp.setPayerName("Dan Smith");
 
         //Expect
-        String expect = "Nicholas Maidanos";
+        String expect = "Dan Smith";
 
         //Actual
         String actual = pp.getPayerName();
@@ -49,11 +51,7 @@ public class PaypalTest {
     }
 
     @Test
-    void getPayerName() {
-        //When
-        Paypal pp =  new Paypal();
-        pp.setPayerName("Nicholas Maidanos");
-
+    public void getPayerName() {
         //Expect
         String expect = "Nicholas Maidanos";
 
@@ -63,13 +61,12 @@ public class PaypalTest {
     }
 
     @Test
-    void setEmail() {
+    public void setEmail() {
         //When
-        Paypal pp = new Paypal();
-        pp.setEmail("example@email.com");
+        pp.setEmail("desk@email.com");
 
         //Expect
-        String expect = "example@email.com";
+        String expect = "desk@email.com";
 
         //Actual
         String actual = pp.getEmail();
@@ -77,13 +74,9 @@ public class PaypalTest {
     }
 
     @Test
-    void getEmail() {
-        //When
-        Paypal pp = new Paypal();
-        pp.setEmail("example@email.com");
-
+    public void getEmail() {
         //Expect
-        String expect = "example@email.com";
+        String expect = "nmaidanos@gmail.com";
 
         //Actual
         String actual = pp.getEmail();
@@ -91,12 +84,9 @@ public class PaypalTest {
     }
 
     @Test
-    void getShortDescription() {
-        //When
-        Paypal pp = new Paypal(78, "Nicholas Maidanos", "nmaidanos@gmail.com");
-
+    public void getShortDescription() {
         //Expect
-        String expect = "PayPal Nicholas Maidanos nmaidanos@gmail.com";
+        String expect = "Paypal Nicholas Maidanos nmaidanos@gmail.com\n";
 
         //Actual
         String actual = pp.getShortDescription();
@@ -105,6 +95,7 @@ public class PaypalTest {
     }
 
     @Test
-    void compareTo() {
+    public void compareTo() {
+
     }
 }