瀏覽代碼

cleand code

Shivam Patel 8 年之前
父節點
當前提交
8166ecfb8b
共有 2 個檔案被更改,包括 23 行新增21 行删除
  1. 19
    17
      Inventory.java
  2. 4
    4
      package.bluej

+ 19
- 17
Inventory.java 查看文件

9
 
9
 
10
     public void updateQuality() {
10
     public void updateQuality() {
11
         for (int i = 0; i < items.length; i++) {
11
         for (int i = 0; i < items.length; i++) {
12
-            if (!items[i].getName().equals("Aged Brie")) {
13
-                if (items[i].getQuality() > 0) {
14
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
15
-                        items[i].setQuality(items[i].getQuality() - 1);
16
-                    }
12
+            if (items[i].getName().equals("Aged Brie")) {
13
+                if(items[i].getQuality() < 50){
14
+                    items[i].setQuality(items[i].getQuality() + 1);
17
                 }
15
                 }
18
-            } else {
19
-                if (items[i].getQuality() < 50) {
16
+                if(items[i].getSellIn() < 0 && items[i].getQuality() < 50){
20
                     items[i].setQuality(items[i].getQuality() + 1);
17
                     items[i].setQuality(items[i].getQuality() + 1);
21
                 }
18
                 }
22
             }
19
             }
20
+            else if(items[i].getName().equals("Sulfuras, Hand of Ragnaros")){
21
+                items[i].setQuality(items[i].getQuality());
23
 
22
 
24
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
25
-                items[i].setSellIn(items[i].getSellIn() - 1);
26
             }
23
             }
24
+            else {
25
+                if(items[i].getSellIn() > 0 && items[i].getQuality() > 0 ){
26
+                    items[i].setQuality(items[i].getQuality() -1);
27
 
27
 
28
-            if (items[i].getSellIn() < 0) {
29
-                if (!items[i].getName().equals("Aged Brie")) {
30
-                  items[i].setQuality(items[i].getQuality() - 1);
31
-                } else {
32
-                    if (items[i].getQuality() < 50) {
33
-                        items[i].setQuality(items[i].getQuality() + 1);
34
-                    }
35
                 }
28
                 }
29
+                else if(items[i].getSellIn() <= 0 && items[i].getQuality() > 0 ) {
30
+                    items[i].setQuality(items[i].getQuality() - 2);
31
+                }
32
+            }
33
+            if(items[i].getQuality() < 80){
34
+                items[i].setSellIn(items[i].getSellIn() - 1);
35
+
36
             }
36
             }
37
+
37
         }
38
         }
38
-}
39
+
40
+    }
39
 }
41
 }

+ 4
- 4
package.bluej 查看文件

41
 target2.showInterface=false
41
 target2.showInterface=false
42
 target2.type=UnitTestTargetJunit4
42
 target2.type=UnitTestTargetJunit4
43
 target2.width=80
43
 target2.width=80
44
-target2.x=40
45
-target2.y=160
44
+target2.x=340
45
+target2.y=140
46
 target3.association=InventoryTest
46
 target3.association=InventoryTest
47
 target3.height=50
47
 target3.height=50
48
 target3.name=Inventory
48
 target3.name=Inventory
49
 target3.showInterface=false
49
 target3.showInterface=false
50
 target3.type=ClassTarget
50
 target3.type=ClassTarget
51
 target3.width=80
51
 target3.width=80
52
-target3.x=10
53
-target3.y=190
52
+target3.x=310
53
+target3.y=170