Get registration date from attempt, removed redundant null check.

dddsample/src/main/java/se/citerus/dddsample/application/impl/HandlingEventServiceImpl.java

@@ -31,6 +31,7 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
          it is determined wether the incoming data, the attempt, actually is capable
          of representing a real handling event. */
       final HandlingEvent event = handlingEventFactory.createHandlingEvent(
+        attempt.getRegistrationTime(),
         attempt.getCompletionTime(),
         attempt.getTrackingId(),
         attempt.getVoyageNumber(),
@@ -44,7 +45,7 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
        */
       handlingEventRepository.save(event);
 
-      /* Publish a system event stating that a cargo has been handled. */
+      /* Publish an event stating that a cargo has been handled. */
       applicationEvents.cargoWasHandled(event);
     } catch (CannotCreateHandlingEventException e) {
       /* This may be a bogus attempt, for example containing a tracking id

dddsample/src/main/java/se/citerus/dddsample/domain/model/handling/HandlingEventFactory.java

@@ -22,7 +22,9 @@ public class HandlingEventFactory {
   private final VoyageRepository voyageRepository;
   private final LocationRepository locationRepository;
 
-  public HandlingEventFactory(CargoRepository cargoRepository, VoyageRepository voyageRepository, LocationRepository locationRepository) {
+  public HandlingEventFactory(final CargoRepository cargoRepository,
+                              final VoyageRepository voyageRepository,
+                              final LocationRepository locationRepository) {
     this.cargoRepository = cargoRepository;
     this.voyageRepository = voyageRepository;
     this.locationRepository = locationRepository;
@@ -34,26 +36,24 @@ public class HandlingEventFactory {
    * @param voyageNumber      voyage number
    * @param unlocode          United Nations Location Code for the location of the event
    * @param type              type of event
+   * @param registrationTime  time when this event was received by the system
    * @throws UnknownVoyageException
    *                                    if there's not carrier movement with this id
    * @throws UnknownCargoException if there's no cargo with this tracking id
    * @throws UnknownLocationException   if there's no location with this UN Locode
    * @return A handling event.
    */
-  public HandlingEvent createHandlingEvent(Date completionTime, TrackingId trackingId, VoyageNumber voyageNumber, UnLocode unlocode, HandlingEvent.Type type)
+  public HandlingEvent createHandlingEvent(Date registrationTime, Date completionTime, TrackingId trackingId, VoyageNumber voyageNumber, UnLocode unlocode, HandlingEvent.Type type)
     throws CannotCreateHandlingEventException {
 
     // Voyage number may be null for certain event types
-    Validate.noNullElements(new Object[]{completionTime, trackingId, unlocode, type});
+    Validate.noNullElements(new Object[]
+      {registrationTime, completionTime, trackingId, unlocode, type}
+    );
 
     final Cargo cargo = findCargo(trackingId);
     final Voyage voyage = findVoyage(voyageNumber);
     final Location location = findLocation(unlocode);
-    
-    if (location == null) throw new UnknownLocationException(unlocode);
-
-    // TODO parameterize
-    final Date registrationTime = new Date();
 
     if (voyage == null) {
       return new HandlingEvent(cargo, completionTime, registrationTime, type, location);