Added dates to TransitEdge, fixed RMI exposure of Pathfinder service

dddsample/src/main/java/com/partner/pathfinder/api/GraphTraversalService.java

@@ -1,5 +1,7 @@
 package com.partner.pathfinder.api;
 
+import java.rmi.Remote;
+import java.rmi.RemoteException;
 import java.util.List;
 import java.util.Properties;
 
@@ -8,8 +10,8 @@ import java.util.Properties;
  * and used by us (booking and tracking team).
  * 
  */
-public interface GraphTraversalService {
+public interface GraphTraversalService extends Remote {
 
-  List<TransitPath> findShortestPath(String originUnLocode, String destinationUnLocode, Properties limitations);
+  List<TransitPath> findShortestPath(String originUnLocode, String destinationUnLocode, Properties limitations) throws RemoteException;
 
 }

dddsample/src/main/java/com/partner/pathfinder/api/TransitEdge.java

@@ -1,31 +1,44 @@
 package com.partner.pathfinder.api;
 
 import java.io.Serializable;
+import java.util.Date;
 
 /**
- * DTO for a leg in an itinerary.
+ * Represents an edge in a path through a graph,
+ * describing the route of a cargo.
+ *  
  */
 public final class TransitEdge implements Serializable {
 
-  private final String carrierMovementId;
+  private final String voyageNumber;
   private final String fromUnLocode;
   private final String toUnLocode;
+  private final Date fromDate;
+  private final Date toDate;
 
   /**
    * Constructor.
    *
-   * @param carrierMovementId
+   * @param voyageNumber
    * @param fromUnLocode
    * @param toUnLocode
+   * @param fromDate
+   * @param toDate
    */
-  public TransitEdge(final String carrierMovementId, final String fromUnLocode, final String toUnLocode) {
-    this.carrierMovementId = carrierMovementId;
+  public TransitEdge(final String voyageNumber,
+                     final String fromUnLocode,
+                     final String toUnLocode,
+                     final Date fromDate,
+                     final Date toDate) {
+    this.voyageNumber = voyageNumber;
     this.fromUnLocode = fromUnLocode;
     this.toUnLocode = toUnLocode;
+    this.fromDate = fromDate;
+    this.toDate = toDate;
   }
 
-  public String getCarrierMovementId() {
-    return carrierMovementId;
+  public String getVoyageNumber() {
+    return voyageNumber;
   }
 
   public String getFromUnLocode() {
@@ -36,4 +49,11 @@ public final class TransitEdge implements Serializable {
     return toUnLocode;
   }
 
+  public Date getFromDate() {
+    return fromDate;
+  }
+
+  public Date getToDate() {
+    return toDate;
+  }
 }

dddsample/src/main/java/com/partner/pathfinder/internal/GraphTraversalServiceImpl.java

@@ -33,18 +33,18 @@ public class GraphTraversalServiceImpl implements GraphTraversalService {
 
       transitEdges.add(new TransitEdge(
         dao.getVoyageNumber(originUnLocode, firstLegTo),
-        originUnLocode, firstLegTo));
+        originUnLocode, firstLegTo, new Date(), new Date()));
 
       for (int j = 0; j < allVertices.size() - 1; j++) {
         final String curr = allVertices.get(j);
         final String next = allVertices.get(j + 1);
-        transitEdges.add(new TransitEdge(dao.getVoyageNumber(curr, next), curr, next));
+        transitEdges.add(new TransitEdge(dao.getVoyageNumber(curr, next), curr, next, new Date(), new Date()));
       }
 
       final String lastLegFrom = allVertices.get(allVertices.size() - 1);
       transitEdges.add(new TransitEdge(
         dao.getVoyageNumber(lastLegFrom, destinationUnLocode),
-        lastLegFrom, destinationUnLocode));
+        lastLegFrom, destinationUnLocode, new Date(), new Date()));
 
       candidates.add(new TransitPath(transitEdges));
     }

dddsample/src/main/resources/com/partner/pathfinder/internal/applicationContext.xml

@@ -4,7 +4,7 @@
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd">
 
-  <bean id="graphTraversalService" class="com.partner.pathfinder.internal.GraphTraversalServiceImpl">
+  <bean id="internalGraphTraversalService" class="com.partner.pathfinder.internal.GraphTraversalServiceImpl">
     <constructor-arg ref="graphDAO"/>
   </bean>
 
@@ -12,7 +12,7 @@
 
   <bean id="rmiGraphTraversalService" class="org.springframework.remoting.rmi.RmiServiceExporter">
     <property name="serviceInterface" value="com.partner.pathfinder.api.GraphTraversalService"/>
-    <property name="service" ref="graphTraversalService"/>
+    <property name="service" ref="internalGraphTraversalService"/>
     <property name="serviceName" value="PathFinder"/>
   </bean>