Bläddra i källkod

registerNewCargo is now bookNewCargo, adapted to the ubiquitous language.

peter_backlund 18 år sedan
förälder
incheckning
66fa39363d

+ 1
- 1
dddsample/src/main/java/se/citerus/dddsample/service/BookingService.java Visa fil

19
    * @param destination cargo destination
19
    * @param destination cargo destination
20
    * @return Cargo tracking id
20
    * @return Cargo tracking id
21
    */
21
    */
22
-  TrackingId registerNewCargo(UnLocode origin, UnLocode destination);
22
+  TrackingId bookNewCargo(UnLocode origin, UnLocode destination);
23
 
23
 
24
   /**
24
   /**
25
    * Loads a cargo for routing operations.
25
    * Loads a cargo for routing operations.

+ 1
- 1
dddsample/src/main/java/se/citerus/dddsample/service/BookingServiceFacadeImpl.java Visa fil

37
   }
37
   }
38
 
38
 
39
   public String registerNewCargo(String origin, String destination) {
39
   public String registerNewCargo(String origin, String destination) {
40
-    TrackingId trackingId = bookingService.registerNewCargo(new UnLocode(origin), new UnLocode(destination));
40
+    TrackingId trackingId = bookingService.bookNewCargo(new UnLocode(origin), new UnLocode(destination));
41
     return trackingId.idString();
41
     return trackingId.idString();
42
   }
42
   }
43
 
43
 

+ 8
- 3
dddsample/src/main/java/se/citerus/dddsample/service/BookingServiceImpl.java Visa fil

16
   private CargoRepository cargoRepository;
16
   private CargoRepository cargoRepository;
17
   private LocationRepository locationRepository;
17
   private LocationRepository locationRepository;
18
   private RoutingService routingService;
18
   private RoutingService routingService;
19
+  // TODO
20
+  //private LockManager lockManager;
19
 
21
 
20
   private final Log logger = LogFactory.getLog(getClass());
22
   private final Log logger = LogFactory.getLog(getClass());
21
 
23
 
22
   @Transactional(readOnly = false)
24
   @Transactional(readOnly = false)
23
-  public TrackingId registerNewCargo(final UnLocode originUnLocode, final UnLocode destinationUnLocode) {
25
+  public TrackingId bookNewCargo(final UnLocode originUnLocode, final UnLocode destinationUnLocode) {
24
     Validate.notNull(originUnLocode);
26
     Validate.notNull(originUnLocode);
25
     Validate.notNull(destinationUnLocode);
27
     Validate.notNull(destinationUnLocode);
26
 
28
 
39
   public Cargo loadCargoForRouting(final TrackingId trackingId) {
41
   public Cargo loadCargoForRouting(final TrackingId trackingId) {
40
     Validate.notNull(trackingId);
42
     Validate.notNull(trackingId);
41
 
43
 
42
-    // TODO obtain offline lock
44
+    // TODO
45
+    //CargoLock cargoLock = lockManager.lockCargo(trackingId);
46
+
43
     final Cargo cargo = cargoRepository.find(trackingId);
47
     final Cargo cargo = cargoRepository.find(trackingId);
44
 
48
 
45
     return cargo;
49
     return cargo;
68
 
72
 
69
     logger.info("Assigned cargo " + trackingId + " to new route");
73
     logger.info("Assigned cargo " + trackingId + " to new route");
70
 
74
 
71
-    // TODO release offline lock
75
+    // TODO
76
+    //lockManager.unlockCargo(cargoLock, trackingId);
72
   }
77
   }
73
 
78
 
74
   public void setCargoRepository(final CargoRepository cargoRepository) {
79
   public void setCargoRepository(final CargoRepository cargoRepository) {

+ 2
- 2
dddsample/src/test/java/se/citerus/dddsample/service/BookingServiceTest.java Visa fil

37
 
37
 
38
     replay(cargoRepository, locationRepository);
38
     replay(cargoRepository, locationRepository);
39
 
39
 
40
-    TrackingId trackingId = cargoService.registerNewCargo(fromUnlocode, toUnlocode);
40
+    TrackingId trackingId = cargoService.bookNewCargo(fromUnlocode, toUnlocode);
41
     assertEquals(expectedTrackingId, trackingId);
41
     assertEquals(expectedTrackingId, trackingId);
42
   }
42
   }
43
 
43
 
44
   public void testRegisterNewNullArguments() {
44
   public void testRegisterNewNullArguments() {
45
     replay(cargoRepository, locationRepository);
45
     replay(cargoRepository, locationRepository);
46
     try {
46
     try {
47
-      cargoService.registerNewCargo(null, null);
47
+      cargoService.bookNewCargo(null, null);
48
       fail("Null arguments should not be allowed");
48
       fail("Null arguments should not be allowed");
49
     } catch (IllegalArgumentException expected) {}
49
     } catch (IllegalArgumentException expected) {}
50
   }
50
   }