Brought EventService closer to the domain by renaming it DomainEventNotifier and use ubiquitous language in the method signatures (fireHandlingEventRegistered is now cargoWasHandled) in order to make it naturally fit in among the domain services.

dddsample/src/main/java/se/citerus/dddsample/application/messaging/HandlingEventMessageDelegate.java

@@ -13,7 +13,7 @@ import javax.jms.MessageListener;
  * Consumes JMS messages and delegates notification of misdirected
  * cargo to the cargo service.
  * <p/>
- * This point of this is to decouple the cargo service from JMS,
+ * This point of this is to decouple the tracking service from JMS,
  * and to allow a thread-based messaging implementation to live in
  * parallell.
  */
@@ -27,7 +27,7 @@ public class HandlingEventMessageDelegate implements MessageListener {
       logger.debug("Received message " + message);
     }
     try {
-      String tidString = message.getStringProperty(JmsEventServiceImpl.TRACKING_ID_KEY);
+      String tidString = message.getStringProperty(JmsDomainEventNotifierImpl.TRACKING_ID_KEY);
       trackingService.notify(new TrackingId(tidString));
     } catch (JMSException e) {
       logger.error(e, e);

dddsample/src/main/java/se/citerus/dddsample/application/messaging/JmsEventServiceImpl.java → dddsample/src/main/java/se/citerus/dddsample/application/messaging/JmsDomainEventNotifierImpl.java

@@ -4,19 +4,19 @@ import org.springframework.jms.core.JmsOperations;
 import org.springframework.jms.core.MessageCreator;
 import se.citerus.dddsample.domain.model.cargo.TrackingId;
 import se.citerus.dddsample.domain.model.handling.HandlingEvent;
-import se.citerus.dddsample.domain.service.EventService;
+import se.citerus.dddsample.domain.service.DomainEventNotifier;
 
 import javax.jms.*;
 
 /**
  * JMS based implementation.
  */
-public final class JmsEventServiceImpl implements EventService {
+public final class JmsDomainEventNotifierImpl implements DomainEventNotifier {
   private JmsOperations jmsOperations;
   private Destination destination;
   public static final String TRACKING_ID_KEY = TrackingId.class.getName() + ".KEY";
 
-  public void fireHandlingEventRegistered(final HandlingEvent event) {
+  public void cargoWasHandled(final HandlingEvent event) {
     jmsOperations.send(destination, new MessageCreator() {
       // TODO: richer message type
       public Message createMessage(final Session session) throws JMSException {

dddsample/src/main/java/se/citerus/dddsample/application/messaging/ThreadBasedDomainEventNotifierImpl.java

@@ -0,0 +1,25 @@
+package se.citerus.dddsample.application.messaging;
+
+import se.citerus.dddsample.domain.model.handling.HandlingEvent;
+import se.citerus.dddsample.domain.service.DomainEventNotifier;
+import se.citerus.dddsample.domain.service.TrackingService;
+
+/**
+ * Thread based implementation.
+ */
+public class ThreadBasedDomainEventNotifierImpl implements DomainEventNotifier {
+
+  private TrackingService trackingService;
+
+  public void cargoWasHandled(final HandlingEvent event) {
+    new Thread(new Runnable() {
+      public void run() {
+        trackingService.notify(event.cargo().trackingId());
+      }
+    }).start();
+  }
+
+  public void setTrackingService(TrackingService trackingService) {
+    this.trackingService = trackingService;
+  }
+}

dddsample/src/main/java/se/citerus/dddsample/domain/service/DomainEventNotifier.java

@@ -0,0 +1,22 @@
+package se.citerus.dddsample.domain.service;
+
+import se.citerus.dddsample.domain.model.handling.HandlingEvent;
+
+/**
+ * This interface provides a way to let other parts
+ * of the system know about domain events that have occurred.
+ * <p/>
+ * All method signatures are expressed in the ubiquitous language.    
+ * <p/>
+ * It may be implemented synchronously or asynchronously, using
+ * for example JMS.
+ */
+public interface DomainEventNotifier {
+
+  /**
+   * A cargo has been handled.
+   *
+   * @param event handling event
+   */
+  void cargoWasHandled(HandlingEvent event);
+}

dddsample/src/main/java/se/citerus/dddsample/domain/service/HandlingEventServiceImpl.java

@@ -21,7 +21,7 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
   private CarrierMovementRepository carrierMovementRepository;
   private HandlingEventRepository handlingEventRepository;
   private LocationRepository locationRepository;
-  private EventService eventService;
+  private DomainEventNotifier domainEventNotifier;
 
   @Transactional(readOnly = false)
   public void register(final Date completionTime, final TrackingId trackingId, final CarrierMovementId carrierMovementId,
@@ -53,7 +53,7 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
      */
     handlingEventRepository.save(event);
 
-    eventService.fireHandlingEventRegistered(event);
+    domainEventNotifier.cargoWasHandled(event);
   }
 
   private CarrierMovement findCarrierMovement(final CarrierMovementId carrierMovementId)
@@ -99,7 +99,7 @@ public final class HandlingEventServiceImpl implements HandlingEventService {
     this.locationRepository = locationRepository;
   }
 
-  public void setEventService(final EventService eventService) {
-    this.eventService = eventService;
+  public void setEventService(final DomainEventNotifier domainEventNotifier) {
+    this.domainEventNotifier = domainEventNotifier;
   }
 }

dddsample/src/main/resources/context-messaging-jms.xml

@@ -34,7 +34,7 @@
     <property name="connectionFactory" ref="jmsConnectionFactory"/>
   </bean>
 
-  <bean id="eventService" class="se.citerus.dddsample.application.messaging.JmsEventServiceImpl">
+  <bean id="domainEventNotifier" class="se.citerus.dddsample.application.messaging.JmsDomainEventNotifierImpl">
     <property name="jmsOperations" ref="jmsOperations"/>
     <property name="destination" ref="handlingEventTopic"/>
   </bean>

dddsample/src/main/resources/context-messaging-thread.xml

@@ -4,7 +4,7 @@
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd">
 
-  <bean id="eventService" class="se.citerus.dddsample.application.messaging.ThreadBasedEventServiceImpl">
+  <bean id="domainEventNotifier" class="se.citerus.dddsample.application.messaging.ThreadBasedDomainEventNotifierImpl">
     <property name="bookingService" ref="bookingService"/>
   </bean>
 

dddsample/src/main/resources/context-service.xml

@@ -24,7 +24,7 @@
     <property name="handlingEventRepository" ref="handlingEventRepository"/>
     <property name="carrierMovementRepository" ref="carrierMovementRepository"/>
     <property name="locationRepository" ref="locationRepository"/>
-    <property name="eventService" ref="eventService"/>
+    <property name="domainEventNotifier" ref="domainEventNotifier"/>
   </bean>
 
   <bean id="routingService" class="se.citerus.dddsample.application.routing.ExternalRoutingService">

dddsample/src/test/java/se/citerus/dddsample/domain/service/HandlingEventServiceTest.java

@@ -18,7 +18,7 @@ import java.util.Date;
 
 public class HandlingEventServiceTest extends TestCase {
   private HandlingEventServiceImpl service;
-  private EventService eventService;
+  private DomainEventNotifier domainEventNotifier;
   private CargoRepository cargoRepository;
   private CarrierMovementRepository carrierMovementRepository;
   private HandlingEventRepository handlingEventRepository;
@@ -37,17 +37,17 @@ public class HandlingEventServiceTest extends TestCase {
     carrierMovementRepository = createMock(CarrierMovementRepository.class);
     handlingEventRepository = createMock(HandlingEventRepository.class);
     locationRepository = createMock(LocationRepository.class);
-    eventService = createMock(EventService.class);
+    domainEventNotifier = createMock(DomainEventNotifier.class);
 
     service.setCargoRepository(cargoRepository);
     service.setCarrierMovementRepository(carrierMovementRepository);
     service.setHandlingEventRepository(handlingEventRepository);
     service.setLocationRepository(locationRepository);
-    service.setEventService(eventService);
+    service.setEventService(domainEventNotifier);
   }
 
   protected void tearDown() throws Exception {
-    verify(cargoRepository, carrierMovementRepository, handlingEventRepository, eventService);
+    verify(cargoRepository, carrierMovementRepository, handlingEventRepository, domainEventNotifier);
   }
 
   public void testRegisterEvent() throws Exception {
@@ -64,9 +64,9 @@ public class HandlingEventServiceTest extends TestCase {
 
     // TODO: does not inspect the handling event instance in a sufficient way
     handlingEventRepository.save(isA(HandlingEvent.class));
-    eventService.fireHandlingEventRegistered(isA(HandlingEvent.class));
+    domainEventNotifier.cargoWasHandled(isA(HandlingEvent.class));
 
-    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, eventService);
+    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, domainEventNotifier);
     
     service.register(date, trackingId, carrierMovementId, unLocode, HandlingEvent.Type.LOAD);
   }
@@ -78,11 +78,11 @@ public class HandlingEventServiceTest extends TestCase {
     expect(cargoRepository.find(trackingId)).andReturn(cargoABC);
 
     handlingEventRepository.save(isA(HandlingEvent.class));
-    eventService.fireHandlingEventRegistered(isA(HandlingEvent.class));
+    domainEventNotifier.cargoWasHandled(isA(HandlingEvent.class));
 
     expect(locationRepository.find(STOCKHOLM.unLocode())).andReturn(STOCKHOLM);
 
-    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, eventService);
+    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, domainEventNotifier);
 
     service.register(date, trackingId, null, STOCKHOLM.unLocode(), HandlingEvent.Type.CLAIM);
   }
@@ -99,7 +99,7 @@ public class HandlingEventServiceTest extends TestCase {
 
     expect(locationRepository.find(MELBOURNE.unLocode())).andReturn(MELBOURNE);
     
-    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, eventService);
+    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, domainEventNotifier);
     
     try {
       service.register(date, trackingId, carrierMovementId, MELBOURNE.unLocode(), HandlingEvent.Type.UNLOAD);
@@ -115,7 +115,7 @@ public class HandlingEventServiceTest extends TestCase {
 
     expect(locationRepository.find(HONGKONG.unLocode())).andReturn(HONGKONG);
     
-    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, eventService);
+    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, domainEventNotifier);
     
     try {
       service.register(date, trackingId, null, HONGKONG.unLocode(), HandlingEvent.Type.CLAIM);
@@ -131,7 +131,7 @@ public class HandlingEventServiceTest extends TestCase {
     UnLocode wayOff = new UnLocode("XXYYY");
     expect(locationRepository.find(wayOff)).andReturn(null);
     
-    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, eventService);
+    replay(cargoRepository, carrierMovementRepository, handlingEventRepository, locationRepository, domainEventNotifier);
     
     try {
       service.register(date, trackingId, null, wayOff, HandlingEvent.Type.CLAIM);