Ver código fonte

Merge 114f1c1f78f1ee71a616b0bafa1f538b96e93575 into 0665dd6f3de2bb92a7f856bde34efac87df0531f

erc91087 8 anos atrás
pai
commit
8959c39728
Nenhuma conta conectada ao e-mail do autor de commit

+ 28
- 5
src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java Ver arquivo

@@ -1,6 +1,7 @@
1 1
 package com.zipcodewilmington.phone;
2 2
 
3 3
 import com.zipcodewilmington.exceptions.InvalidPhoneNumberFormatException;
4
+import com.zipcodewilmington.tools.RandomNumberFactory;
4 5
 
5 6
 import java.util.logging.Logger;
6 7
 
@@ -20,14 +21,25 @@ public final class PhoneNumberFactory {
20 21
      * @return array of randomly generated PhoneNumber objects
21 22
      */ //TODO - Implement logic
22 23
     public static PhoneNumber[] createRandomPhoneNumberArray(int phoneNumberCount) {
23
-        return null;
24
+        PhoneNumber[] phNumbers = new PhoneNumber[phoneNumberCount];
25
+
26
+        for(int i =0; i < phNumbers.length; i++){
27
+            phNumbers[i] = createRandomPhoneNumber();
28
+        }
29
+        return phNumbers;
24 30
     }
25 31
 
26 32
     /**
27 33
      * @return an instance of PhoneNumber with randomly generated phone number value
28 34
      */ //TODO - Implement logic
29 35
     public static PhoneNumber createRandomPhoneNumber() {
30
-        return createPhoneNumberSafely(-1, -1, -1);
36
+
37
+        int areaCode = RandomNumberFactory.createInteger(100, 999);
38
+        int centralOfficeCode = RandomNumberFactory.createInteger(100, 999);
39
+        int phoneLineCode = RandomNumberFactory.createInteger(1000, 9999);
40
+
41
+        return createPhoneNumberSafely(areaCode, centralOfficeCode, phoneLineCode);
42
+       // return createPhoneNumberSafely(-1, -1, -1);
31 43
     }
32 44
 
33 45
 
@@ -38,7 +50,16 @@ public final class PhoneNumberFactory {
38 50
      * @return a new phone number object
39 51
      */ //TODO - if input is valid, return respective PhoneNumber object, else return null
40 52
     public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOfficeCode, int phoneLineCode) {
41
-        return createPhoneNumber(null);
53
+        StringBuilder phoneNumberConcat = new StringBuilder();
54
+        phoneNumberConcat.append("(" + areaCode + ")-" + centralOfficeCode + "-" + phoneLineCode);
55
+
56
+        try {
57
+            return createPhoneNumber(phoneNumberConcat.toString());
58
+        } catch (InvalidPhoneNumberFormatException e) {
59
+            //e.printStackTrace();
60
+            logger.warning(areaCode + "-" + centralOfficeCode + "-" + phoneLineCode + " is not a valid number");
61
+        }
62
+        return null;
42 63
     }
43 64
 
44 65
     /**
@@ -46,7 +67,9 @@ public final class PhoneNumberFactory {
46 67
      * @return a new phone number object
47 68
      * @throws InvalidPhoneNumberFormatException - thrown if phoneNumberString does not match acceptable format
48 69
      */ // TODO - Add throws statement to method signature
49
-    public static PhoneNumber createPhoneNumber(String phoneNumberString) {
50
-        return null;
70
+    public static PhoneNumber createPhoneNumber(String phoneNumberString) throws InvalidPhoneNumberFormatException {
71
+        logger.info("New number with value " + phoneNumberString);
72
+
73
+        return new PhoneNumber(phoneNumberString);
51 74
     }
52 75
 }