Преглед изворни кода

Merge 7610968f9ec46d84bfcdd9cc8b2a0760abd7932c into 0665dd6f3de2bb92a7f856bde34efac87df0531f

CWinarski пре 8 година
родитељ
комит
5009f8280a
No account linked to committer's email

+ 22
- 6
src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java Прегледај датотеку

@@ -1,7 +1,10 @@
1 1
 package com.zipcodewilmington.phone;
2 2
 
3 3
 import com.zipcodewilmington.exceptions.InvalidPhoneNumberFormatException;
4
+import com.zipcodewilmington.tools.RandomNumberFactory;
4 5
 
6
+import java.io.IOException;
7
+import java.util.logging.Level;
5 8
 import java.util.logging.Logger;
6 9
 
7 10
 /**
@@ -20,14 +23,19 @@ public final class PhoneNumberFactory {
20 23
      * @return array of randomly generated PhoneNumber objects
21 24
      */ //TODO - Implement logic
22 25
     public static PhoneNumber[] createRandomPhoneNumberArray(int phoneNumberCount) {
23
-        return null;
26
+        PhoneNumber[] phoneNumberArray = new PhoneNumber[phoneNumberCount];
27
+        for (int i = 0; i < phoneNumberArray.length; i++){
28
+            phoneNumberArray[i] =createRandomPhoneNumber();
29
+        }
30
+        return phoneNumberArray;
24 31
     }
25 32
 
26 33
     /**
27 34
      * @return an instance of PhoneNumber with randomly generated phone number value
28 35
      */ //TODO - Implement logic
29
-    public static PhoneNumber createRandomPhoneNumber() {
30
-        return createPhoneNumberSafely(-1, -1, -1);
36
+    public static PhoneNumber createRandomPhoneNumber(){
37
+        return createPhoneNumberSafely(RandomNumberFactory.createInteger(100,999),
38
+                RandomNumberFactory.createInteger(100,999), RandomNumberFactory.createInteger(1000, 9999));
31 39
     }
32 40
 
33 41
 
@@ -38,7 +46,13 @@ public final class PhoneNumberFactory {
38 46
      * @return a new phone number object
39 47
      */ //TODO - if input is valid, return respective PhoneNumber object, else return null
40 48
     public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOfficeCode, int phoneLineCode) {
41
-        return createPhoneNumber(null);
49
+        String safePhoneNumberString = String.format("(%3d)-%3d-%4d", areaCode,centralOfficeCode,phoneLineCode);
50
+        try{
51
+            return createPhoneNumber(safePhoneNumberString);
52
+        } catch (InvalidPhoneNumberFormatException ipfe){
53
+            logger.log(Level.SEVERE, "safePhoneNumberString is not a valid phone number");
54
+            return null;
55
+        }
42 56
     }
43 57
 
44 58
     /**
@@ -46,7 +60,9 @@ public final class PhoneNumberFactory {
46 60
      * @return a new phone number object
47 61
      * @throws InvalidPhoneNumberFormatException - thrown if phoneNumberString does not match acceptable format
48 62
      */ // TODO - Add throws statement to method signature
49
-    public static PhoneNumber createPhoneNumber(String phoneNumberString) {
50
-        return null;
63
+    public static PhoneNumber createPhoneNumber(String phoneNumberString) throws InvalidPhoneNumberFormatException{
64
+           PhoneNumber newPhoneNumber = new PhoneNumber(phoneNumberString);
65
+           logger.log(Level.SEVERE,"Attempting to create a phone number object with the value of newPhoneNumber");
66
+           return newPhoneNumber;
51 67
     }
52 68
 }

+ 1
- 1
src/test/java/com/zipcodewilmington/PhoneNumberFactoryTest.java Прегледај датотеку

@@ -78,7 +78,7 @@ public class PhoneNumberFactoryTest {
78 78
     }
79 79
 
80 80
     @Test
81
-    public void testCreateRandomPhoneNumber() {
81
+    public void testCreateRandomPhoneNumber(){
82 82
         for (int i = 0; i < 999; i++) {
83 83
             // : Given
84 84
             // : When