Przeglądaj źródła

Merge 8194325655c2fdf6c23235057bc5a0a48288c075 into 0665dd6f3de2bb92a7f856bde34efac87df0531f

ktecle 8 lat temu
rodzic
commit
0247c5ee34
Brak konta powiązanego z e-mailem autora

+ 28
- 5
src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java Wyświetl plik

@@ -1,6 +1,7 @@
1 1
 package com.zipcodewilmington.phone;
2 2
 
3 3
 import com.zipcodewilmington.exceptions.InvalidPhoneNumberFormatException;
4
+import com.zipcodewilmington.tools.RandomNumberFactory;
4 5
 
5 6
 import java.util.logging.Logger;
6 7
 
@@ -20,14 +21,23 @@ public final class PhoneNumberFactory {
20 21
      * @return array of randomly generated PhoneNumber objects
21 22
      */ //TODO - Implement logic
22 23
     public static PhoneNumber[] createRandomPhoneNumberArray(int phoneNumberCount) {
23
-        return null;
24
+        PhoneNumber[] phoneNumberArray = new PhoneNumber[phoneNumberCount];
25
+        for(int i =0;i<phoneNumberCount;i++){
26
+         phoneNumberArray[i]=createRandomPhoneNumber();
27
+        }
28
+        return phoneNumberArray;
24 29
     }
25 30
 
26 31
     /**
27 32
      * @return an instance of PhoneNumber with randomly generated phone number value
28 33
      */ //TODO - Implement logic
29 34
     public static PhoneNumber createRandomPhoneNumber() {
30
-        return createPhoneNumberSafely(-1, -1, -1);
35
+
36
+        int areaCode = RandomNumberFactory.createInteger(100,999);
37
+        int centralOfficeCode = RandomNumberFactory.createInteger(100,999);
38
+        int phoneLineCode = RandomNumberFactory.createInteger(1000,9999);
39
+
40
+        return createPhoneNumberSafely(areaCode, centralOfficeCode, phoneLineCode);
31 41
     }
32 42
 
33 43
 
@@ -38,7 +48,19 @@ public final class PhoneNumberFactory {
38 48
      * @return a new phone number object
39 49
      */ //TODO - if input is valid, return respective PhoneNumber object, else return null
40 50
     public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOfficeCode, int phoneLineCode) {
41
-        return createPhoneNumber(null);
51
+
52
+        StringBuilder builder = new StringBuilder();
53
+        builder.append("("+areaCode +")"+ "-"+ centralOfficeCode + "-"+phoneLineCode);
54
+        String phoneNumberString = builder.toString();
55
+        try{
56
+            return createPhoneNumber(phoneNumberString);
57
+        }catch(InvalidPhoneNumberFormatException e){
58
+            logger.info(phoneNumberString + " is not a valid phone number entry");
59
+            return null;
60
+
61
+
62
+        }
63
+
42 64
     }
43 65
 
44 66
     /**
@@ -46,7 +68,8 @@ public final class PhoneNumberFactory {
46 68
      * @return a new phone number object
47 69
      * @throws InvalidPhoneNumberFormatException - thrown if phoneNumberString does not match acceptable format
48 70
      */ // TODO - Add throws statement to method signature
49
-    public static PhoneNumber createPhoneNumber(String phoneNumberString) {
50
-        return null;
71
+    public static PhoneNumber createPhoneNumber(String phoneNumberString) throws InvalidPhoneNumberFormatException {
72
+
73
+        return new PhoneNumber(phoneNumberString);
51 74
     }
52 75
 }