completed

src/main/java/com/zipcodewilmington/arrayutility/ArrayUtility.java

@@ -41,17 +41,16 @@ public class ArrayUtility<I> {
 
     public I getMostCommonFromMerge(I[] arrayToMerge) {
 
-        I[] mergedArray = (I[]) new Object[arrayToMerge.length + arr.length];
-        System.arraycopy(arr,0,mergedArray,0,arr.length);
-        System.arraycopy(arrayToMerge,0,mergedArray,arr.length,arrayToMerge.length);
+        I[] mergedArray = mergeArrays(arr,arrayToMerge);
 
         I mostCommon = mergedArray[0];
-        Integer commonCount = getNumberOfOccurrences(mostCommon);
+        Integer commonCount = betterGetNumberOfOccurrences(mostCommon, mergedArray);
 
         for (int i = 0; i < mergedArray.length; i++) {
-            Integer tempCount = getNumberOfOccurrences(mergedArray[i]);
+            Integer tempCount = betterGetNumberOfOccurrences(mergedArray[i], mergedArray);
             if(tempCount > commonCount){
                 mostCommon = mergedArray[i];
+                commonCount = betterGetNumberOfOccurrences(mergedArray[i], mergedArray);
             }
         }
         return mostCommon;
@@ -67,4 +66,21 @@ public class ArrayUtility<I> {
         }
         return count;
     }
+
+    public I[] mergeArrays(I[] array1, I[] array2){
+        I[] mergedArray = (I[]) new Object[array2.length + array1.length];
+        System.arraycopy(array1,0, mergedArray,0,array1.length);
+        System.arraycopy(array2,0, mergedArray, array1.length, array2.length);
+        return mergedArray;
+    }
+
+    public Integer betterGetNumberOfOccurrences(I valueToEvaluate, I[] arr) {
+        Integer count = 0;
+        for(I i : arr){
+            if(i == valueToEvaluate){
+                count++;
+            }
+        }
+        return count;
+    }
 }

src/test/java/com/zipcodewilmington/arrayutility/GetMostCommonFromMergeTest.java

@@ -28,7 +28,7 @@ public class GetMostCommonFromMergeTest {
         // Given
         Long expected = 8L;
         Long[] inputArray = {1L, 2L, expected, 8L, 4L, 5L, expected, 0L, 9L, 8L, expected};
-        Long[] arrayToMerge = {1L, 2L, expected, 8L, 4L, 5L, expected, 0L, 9L, 8L, expected};
+        Long[] arrayToMerge = {1L, 2L, expected, 8L, 4L, 5L, expected, 0L, 9L, expected, 8L};
         ArrayUtility<Long> arrayUtility = new ArrayUtility<Long>(inputArray);
 
         // When