CleanCode with test

Inventory.java

@@ -8,32 +8,38 @@ public class Inventory {
     }
 
     public void updateQuality() {
-        for (int i = 0; i < items.length; i++) {
-            if (!items[i].getName().equals("Aged Brie")) {
-                if (items[i].getQuality() > 0) {
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                        items[i].setQuality(items[i].getQuality() - 1);
-                    }
-                }
-            } else {
-                if (items[i].getQuality() < 50) {
-                    items[i].setQuality(items[i].getQuality() + 1);
-                }
+        for (int i = 0; i < items.length; i++) { // each if/else handles each specific item
+            if (items[i].getName().equals("Sulfuras, Hand of Ragnoros")) {
+                continue;
             }
+            if (items[i].getName().equals("Aged Brie")) {
+                updateAgedBrie(i);
+            } else updateNormalItem(i);
+        }
+    }
 
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                items[i].setSellIn(items[i].getSellIn() - 1);
-            }
+    public void updateAgedBrie(int i) {
+        if (items[i].getSellIn() > 0 && items[i].getQuality() <= 49) {
+            items[i].setQuality(items[i].getQuality() + 1);
+        } else if (items[i].getSellIn() <= 0 && items[i].getQuality() <= 48) {
+            items[i].setQuality(items[i].getQuality() + 2);
+        }
+    }
 
-            if (items[i].getSellIn() < 0) {
-                if (!items[i].getName().equals("Aged Brie")) {
-                  items[i].setQuality(items[i].getQuality() - 1);
-                } else {
-                    if (items[i].getQuality() < 50) {
-                        items[i].setQuality(items[i].getQuality() + 1);
-                    }
-                }
-            }
+    public void updateNormalItem(int i) {
+        if (items[i].getSellIn() > 0 && items[i].getQuality() <= 49) {
+            items[i].setQuality(items[i].getQuality() - 1);
+        } else if (items[i].getSellIn() <= 0 && items[i].getQuality() <= 48) {
+            items[i].setQuality(items[i].getQuality() - 2);
         }
-}
-}
+    }
+
+    public void updateConjuredItem(int i) {
+        if (items[i].getSellIn() > 0 && items[i].getQuality() <= 50){
+            items[i].setQuality(items[i].getQuality() - 1);
+        }
+        if (items[i].getSellIn() <= 0 && items[i].getQuality() <= 50){
+            items[i].setQuality(items[i].getQuality() - 4);
+        }
+    }
+}

InventoryTest.java

@@ -8,14 +8,18 @@ public class InventoryTest {
     private static final String AGED_BRIE_NAME = "Aged Brie";
     private static final String BACKSTAGE_PASS_NAME = "Backstage passes to a TAFKAL80ETC concert";
     private static final String NORMAL_ITEM_NAME = "+5 Dexterity Vest";
-
+    private static final String CONJURED_ITEM_NAME = "Conjured Holy Water";
+    private static final int minimumQuality = 0;
+    
     private Item sulfuras;
     private Item normalItem;
-
+    private Item conjuredItem;
+    
     @Before
     public void setup(){
         sulfuras = new Item("Sulfuras, Hand of Ragnaros", 0, 80);
         normalItem = new Item(NORMAL_ITEM_NAME, 10, 20);
+        conjuredItem = new Item(CONJURED_ITEM_NAME, 10, MAX_QUALITY);
     }
 
     @Test
@@ -28,6 +32,7 @@ public class InventoryTest {
 
         assertEquals(expectedQuality, sulfuras.getQuality());
     }
+
     @Test
     public void testUpdate_ForSulfurasSellIn() throws Exception {
         int expectedSellIn = sulfuras.getSellIn();
@@ -119,4 +124,40 @@ public class InventoryTest {
 
         assertEquals(expectedQuality, agedBrie.getQuality());
     }
-}
+
+    @Test
+    public void testUpdate_WhenConjuredItem() throws Exception {
+        Item conjuredItem = new Item(CONJURED_ITEM_NAME, 10, 25);
+        int expectedQuality = conjuredItem.getQuality() - 1;
+        Item[] items = {conjuredItem};
+        Inventory sut = new Inventory(items);
+
+        sut.updateQuality();
+
+        assertEquals(expectedQuality, conjuredItem.getQuality());
+    }
+
+    @Test
+    public void testUpdate_WhenConjuredItemIsMaxQuality() throws Exception {
+        Item agedBrie = new Item(CONJURED_ITEM_NAME, 10, MAX_QUALITY);
+        int expectedQuality = conjuredItem.getQuality();
+        Item[] items = {conjuredItem};
+        Inventory sut = new Inventory(items);
+
+        sut.updateQuality();
+
+        assertEquals(expectedQuality, conjuredItem.getQuality());
+    }
+    
+     @Test
+    public void testUpdate_WhenConjuredItemOnceTheSellInDatePassed() throws Exception {
+        Item conjuredItem = new Item(CONJURED_ITEM_NAME, -1, 10);
+        int expectedQuality = conjuredItem.getQuality() - 2;
+        Item[] items = {conjuredItem};
+        Inventory sut = new Inventory(items);
+
+        sut.updateQuality();
+
+        assertEquals(expectedQuality, conjuredItem.getQuality());
+    }
+}

README.MD

@@ -71,3 +71,15 @@ new code as long as everything still works correctly.
 * Don't use the `!` for your if statement
 
 This was "borrowed" from [alexaitken](https://github.com/alexaitken/GildedRose_java) which originated from [Bobby Johnson's Blog](https://iamnotmyself.com/2011/02/13/refactor-this-the-gilded-rose-kata/).
+
+
+WHAT WE KNOW
+- all items have int SellIn
+- all items have int Quality
+- Regular items:
+    - QUality goes down by 1
+    - QUality goes down by 2 if SellIN < 0
+    
+AgedBrie
+    - QWuality goes up by 1
+    -Quality goes up by 2 if SellIn < 0