tests written, passing 100%

src/main/java/com/zipcodewilmington/gildedrose/Inventory.java

@@ -18,16 +18,16 @@ public class Inventory {
                 {
                     if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros"))
                     {
-                        items[i].setQuality(items[i].getQuality() - 1);
+                        items[i].setQuality(items[i].getQuality() - 1); //sulfuras never decrease in quality
                     }
                 }
             } else
                 {
-                if (items[i].getQuality() < 50)
+                if (items[i].getQuality() < 50) // quality of item never less than 50
                 {
                     items[i].setQuality(items[i].getQuality() + 1);
 
-                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert")
+                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") // start of backstage pass details
                     {
                         if (items[i].getSellIn() < 11)
                         {
@@ -48,7 +48,7 @@ public class Inventory {
                 }
             }
 
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros"))
+            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) // sulfuras never loses value
             {
                 items[i].setSellIn(items[i].getSellIn() - 1);
             }
@@ -61,9 +61,9 @@ public class Inventory {
                     {
                         if (items[i].getQuality() > 0)
                         {
-                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros"))
+                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) //sulfuras never loses value
                             {
-                                items[i].setQuality(items[i].getQuality() - 1);
+                                items[i].setQuality(items[i].getQuality() - 1); // other depreciate
                             }
                         }
                     } else

src/test/java/com/zipcodewilmington/gildedrose/InventoryTest.java

@@ -6,106 +6,248 @@ import org.junit.Test;
 
 public class InventoryTest {
 
+    Item genericItem = new Item("Generic Item", 7, 25);
     Item agedbrietest = new Item("Aged Brie", 7, 4);
-    Item backstagepasstest = new Item("Backstage passes to a TAFKAL80ETC concert", 13, 4);
-    Item sulfurastest = new Item("Sulfuras, Hand of Ragnaros", 7, 4);
+    Item backstagepasstest = new Item("Backstage passes to a TAFKAL80ETC concert", 13, 45);
+    Item sulfurastest = new Item("Sulfuras, Hand of Ragnaros", 7, 20);
 
-    Item[] inventoryList =  {agedbrietest,backstagepasstest,sulfurastest};
+    Item[] inventoryList = {genericItem, agedbrietest, backstagepasstest, sulfurastest};
 
     @Test
     public void updateQualityTest() {
         Inventory test = new Inventory(inventoryList);
+        int before = inventoryList[0].getQuality();
         test.updateQuality();
-
-        int expected = agedbrietest.getQuality();
-        int actual = 5;
-        Assert.assertEquals(expected, actual);
+        int after = inventoryList[0].getQuality();
+        //int expected = 5;
+        //int actual = agedbrietest.getQuality();
+        Assert.assertTrue(before > after);
     }
-@Test
-        public void aged_sellInTest(){
+
+    @Test
+    public void aged_sellInTest() {
         Inventory test = new Inventory(inventoryList);
 
         test.updateQuality();
 
-        int expected=agedbrietest.getSellIn();
-        int actual=6;
-        Assert.assertEquals(expected,actual);
+        int expected = 6;
+        int actual = agedbrietest.getSellIn();
+        Assert.assertEquals(expected, actual);
     }
+
     @Test
     public void sulfur_sellInTest() {
         Inventory test = new Inventory(inventoryList);
 
         test.updateQuality();
 
-        int expected = sulfurastest.getSellIn();
-        int actual = 7;
+        int expected = 7;
+        int actual = sulfurastest.getSellIn();
         Assert.assertEquals(expected, actual);
     }
 
     @Test
-    public void backstage_sellInTest(){
+    public void backstage_sellInTest() {
         Inventory test = new Inventory(inventoryList);
 
         test.updateQuality();
 
-        int expected=backstagepasstest.getSellIn();
-        int actual=12;
-        Assert.assertEquals(expected,actual);
+        int expected = 12;
+        int actual = backstagepasstest.getSellIn();
+        Assert.assertEquals(expected, actual);
     }
+
     public void setNameTest() {
-        sulfurastest.setName("sulphura");
-        sulfurastest.getName();
 
+
+        sulfurastest.setName("sulphura");
         String expected = "sulphura";
-        String actual = "sulphura";
-        Assert.assertEquals(1, 1);
+        String actual = sulfurastest.getName();
+        Assert.assertEquals(expected,actual);
     }
+
     @Test
     public void getNameTest() {
-        agedbrietest.getName();
+
 
         String expected = "Aged Brie";
-        String actual = "Aged Brie";
-        Assert.assertEquals(1, 1);
+        String actual = agedbrietest.getName();
+        Assert.assertEquals(expected, actual);
     }
 
     @Test
     public void getQualityTest() {
 
 
-        agedbrietest.getQuality();
-
         int expected = 4;
-        int actual = 4;
-        Assert.assertEquals(1, 1);
+
+        int actual = agedbrietest.getQuality();
+        Assert.assertEquals(expected, actual);
     }
 
     @Test
     public void setQualityTest() {
         agedbrietest.setQuality(8);
-        agedbrietest.getQuality();
+
 
         int expected = 8;
-        int actual = 8;
-        Assert.assertEquals(1, 1);
+        int actual = agedbrietest.getQuality();
+        Assert.assertEquals(expected, actual);
     }
 
     @Test
     public void getSellinTest() {
-        backstagepasstest.getSellIn();
+
 
         int expected = 13;
-        int actual = 13;
-        Assert.assertEquals(1, 1);
+        int actual = backstagepasstest.getSellIn();
+        Assert.assertEquals(expected, actual);
     }
+
     @Test
-    public void setSellInTest(){
+    public void setSellInTest() {
         sulfurastest.setSellIn(4);
-        sulfurastest.getSellIn();
+
 
         int expected = 4;
-        int actual = 4;
-        Assert.assertEquals(1, 1);
-}
+        int actual = sulfurastest.getSellIn();
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void sellByDatePassedTest() {
+        Inventory test = new Inventory(inventoryList);
+        genericItem.setSellIn(1);
+        test.updateQuality();
+        int before = genericItem.getQuality();
+        test.updateQuality();
+        int after = genericItem.getQuality();
+        Assert.assertTrue(after == (before - 2));
+
+    }
+
+    @Test
+    public void neverNegativeTest() {
+        Inventory test = new Inventory(inventoryList);
+        agedbrietest.setQuality(0);
+        int before = agedbrietest.getQuality();
+        test.updateQuality();
+        int after = agedbrietest.getQuality();
+        Assert.assertTrue(after > 0);
+    }
+
+    @Test
+    public void agedBrieImprovesTest() {
+        Inventory test = new Inventory(inventoryList);
+        int before = agedbrietest.getQuality();
+        test.updateQuality();
+        int after = agedbrietest.getQuality();
+        Assert.assertTrue(after > before);
+    }
+
+    @Test
+    public void qualityNeverMoreThan50Test() {
+        Inventory test = new Inventory(inventoryList);
+        agedbrietest.setSellIn(0);
+        agedbrietest.setQuality(47);
+        int before = agedbrietest.getQuality();
+        test.updateQuality();
+        test.updateQuality();
+        test.updateQuality();
+        test.updateQuality();
+        test.updateQuality();
+        int after = agedbrietest.getQuality();
+        Assert.assertTrue(after == 50);
+    }
+
+    @Test
+    public void sulfurasNeverDegradesTest() {
+        Inventory test = new Inventory(inventoryList);
+        int before = sulfurastest.getQuality();
+        test.updateQuality();
+        int after = sulfurastest.getQuality();
+        Assert.assertTrue(before == after);
+    }
+
+    @Test
+    public void sulfurasNeverSellOutTest() {
+        Inventory test = new Inventory(inventoryList);
+
+        int before = sulfurastest.getSellIn();
+        test.updateQuality();
+
+        int after = sulfurastest.getSellIn();
+        Assert.assertTrue(after == before);
+    }
+
+    @Test
+    public void backStagePassQualityTest1() {
+        Inventory test = new Inventory(inventoryList);
+        backstagepasstest.setSellIn(9);
+        int before = backstagepasstest.getQuality();
+        int temp = backstagepasstest.getSellIn();
+        test.updateQuality();
+        int after = 0;
+        if (temp > 10) {
+            after=before+1;
+        }
+
+        if (temp <= 10) {
+            after = before + 2;
+        }
+
+        int expected = after;
+        int actual = backstagepasstest.getQuality();
+
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void backStagePassQualityTest2() {
+        Inventory test = new Inventory(inventoryList);
+        backstagepasstest.setSellIn(4);
+        int before = backstagepasstest.getQuality();
+        int temp = backstagepasstest.getSellIn();
+        test.updateQuality();
+        int after = 0;
+        if (temp > 10) {
+            after=before+1;
+        }
+
+        if (temp <= 5) {
+            after = before + 3;
+        }
+
+        int expected = after;
+        int actual = backstagepasstest.getQuality();
+
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void backStagePassQualityTest3() {
+        Inventory test = new Inventory(inventoryList);
+        backstagepasstest.setSellIn(0);
+        int before = backstagepasstest.getQuality();
+        int temp = backstagepasstest.getSellIn();
+        test.updateQuality();
+        int after = 0;
+        if (temp > 10) {
+            after=before+1;
+        }
+
+        if (temp <= 0) {
+            after = 0;
+        }
+
+        int expected = after;
+        int actual = backstagepasstest.getQuality();
+
+        Assert.assertEquals(expected,actual);
+    }
+
+
 }
 
+
+