100% Test Coverage, and Refactored Code

src/main/java/com/zipcodewilmington/gildedrose/Inventory.java

@@ -1,6 +1,5 @@
 package com.zipcodewilmington.gildedrose;
 
-
 public class Inventory {
     private Item[] items;
 
@@ -9,58 +8,102 @@ public class Inventory {
         this.items = items;
     }
 
+    private static void updateBackstage(Item[] items, int i){
+        String itemName = items[i].getName();
+        int sellIndays = items[i].getSellIn();
 
-    public void updateQuality() {
-        for (int i = 0; i < items.length; i++) {
-            if (!items[i].getName().equals("Aged Brie")
-                    && !items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                if (items[i].getQuality() > 0) {
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                        items[i].setQuality(items[i].getQuality() - 1);
-                    }
-                }
-            } else {
-                if (items[i].getQuality() < 50) {
-                    items[i].setQuality(items[i].getQuality() + 1);
-
-                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") {
-                        if (items[i].getSellIn() < 11) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
-
-                        if (items[i].getSellIn() < 6) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
-                    }
-                }
-            }
+        if (itemName.equals("Backstage Pass") && InventoryUtilities.ValidQualityCheck(items, i)){
 
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                items[i].setSellIn(items[i].getSellIn() - 1);
+            if(sellIndays <= 0){
+                items[i].setQuality(1);
+                InventoryUtilities.decreaseSellin(items, i);
             }
+            else if(sellIndays <= 5){
+                InventoryUtilities.increaseQuality(items,i,3);
+                InventoryUtilities.decreaseSellin(items, i);
 
-            if (items[i].getSellIn() < 0) {
-                if (!items[i].getName().equals("Aged Brie")) {
-                    if (!items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].getQuality() > 0) {
-                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                                items[i].setQuality(items[i].getQuality() - 1);
-                            }
-                        }
-                    } else {
-                        items[i].setQuality(items[i].getQuality()
-                                - items[i].getQuality());
-                    }
-                } else {
-                    if (items[i].getQuality() < 50) {
-                        items[i].setQuality(items[i].getQuality() + 1);
-                    }
-                }
             }
+            else if(sellIndays <= 10){
+                InventoryUtilities.increaseQuality(items, i, 2);
+                InventoryUtilities.decreaseSellin(items, i);
+            }
+            else{
+                InventoryUtilities.increaseQuality(items, i, 1);
+                InventoryUtilities.decreaseSellin(items, i);
+            }
+
+        }
+
+    }
+    private static void updateAgedBrie(Item[] items, int i){
+        String itemName = items[i].getName();
+
+        if(itemName.equals("Aged Brie") && InventoryUtilities.ValidQualityCheck(items, i)){
+            InventoryUtilities.increaseQuality(items,i,1);
+            InventoryUtilities.decreaseSellin(items, i);
+        }
+
+    }
+
+    private static void updatePastSellin(Item[] items, int i){
+        int itemSellin = items[i].getSellIn();
+        String itemName = items[i].getName();
+
+        if(itemSellin < 0 && InventoryUtilities.ValidQualityCheck(items, i) && !itemName.equals("Aged Brie")){
+            InventoryUtilities.decreaseQuality(items, i, 2);
+            InventoryUtilities.decreaseSellin(items, i);
         }
+
     }
-}
+    private static void updateConjured(Item[] items, int i){
+        int itemSellin = items[i].getSellIn();
+        String itemName = items[i].getName();
+
+        if(InventoryUtilities.ValidQualityCheck(items, i) && itemName.equals("Conjured Item")){
+            InventoryUtilities.decreaseQuality(items, i, 2);
+            InventoryUtilities.decreaseSellin(items, i);
+        }
+
+    }
+    private static void updateSulfuras(Item[] items, int i){
+        String itemName = items[i].getName();
+        if (itemName.equals("Sulfuras")){
+            items[i].setQuality(80);
+        }
+
+    }
+
+    private static void updateNormalItem(Item[] items, int i){
+        if(InventoryUtilities.ValidQualityCheck(items, i) && !checkUnique(items, i)){
+
+            InventoryUtilities.decreaseQuality(items, i, 1);
+            InventoryUtilities.decreaseSellin(items, i);
+        }
+
+    }
+
+    private static boolean checkUnique(Item[] items, int i){
+        String itemName = items[i].getName();
+        int itemSellin = items[i].getSellIn();
+
+        if(itemName.equals("Aged Brie") || itemName.equals("Backstage Pass") || itemName.equals("Sulfuras") || itemName.equals("Conjured Item") || itemSellin < 0)
+        {
+            return true;
+        }
+        else
+            {
+            return false;
+            }
+
+    }
+    public void updateQuality() {
+        for (int i = 0; i < items.length; i++) {
+            updateBackstage(items, i);
+            updateNormalItem(items, i);
+            updatePastSellin(items, i);
+            updateAgedBrie(items, i);
+            updateSulfuras(items, i);
+            updateConjured(items, i);
+            }
+        }
+    }

src/main/java/com/zipcodewilmington/gildedrose/InventoryUtilities.java

@@ -0,0 +1,32 @@
+package com.zipcodewilmington.gildedrose;
+
+public class InventoryUtilities {
+    private Item[] items;
+
+
+
+    public static void increaseQuality(Item[] items, int i, int howMuch){
+        for(int idx = 0; idx <= howMuch; idx++){
+            items[i].setQuality(items[i].getQuality() + 1);
+        }
+    }
+
+    public static void decreaseQuality(Item[] items, int i, int howMuch){
+        for(int idx = 2; idx <= howMuch; idx++) {
+            items[i].setQuality(items[i].getQuality() - 1);
+        }
+    }
+    public static void decreaseSellin(Item[] items, int i){
+        items[i].setQuality(items[i].getQuality() - 1);
+    }
+
+
+    public static boolean ValidQualityCheck(Item[] items, int i){
+        int itemQuality = items[i].getQuality();
+
+        if(itemQuality > 0 && itemQuality < 50){
+            return true;
+        }
+        return false;
+    }
+}

src/test/java/com/zipcodewilmington/gildedrose/InventoryTest.java

@@ -5,8 +5,184 @@ import org.junit.Test;
 
 public class InventoryTest {
     @Test
-    public void updateQuantityTest(){
-        Assert.assertEquals(1, 1);
+    public void checkSetName(){
+
+        Item normalItem = new Item("Sock", 20, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+        itemList[0].setName("Sulfuras");
+        String actual = itemList[0].getName();
+
+        Assert.assertEquals("Sulfuras",actual);
+    }
+
+    @Test
+    public void checkSetSellin(){
+
+        Item normalItem = new Item("Sock", 20, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+        itemList[0].setSellIn(10);
+        int actual = itemList[0].getSellIn();
+
+        Assert.assertEquals(10,actual);
+    }
+
+    @Test
+    public void checkNormalQuality(){
+        //Given
+        Item normalItem = new Item("Sock", 20, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(8, actual);
+    }
+    @Test
+    public void checkPastSellin(){
+        //Given
+        Item normalItem = new Item("Sock", -1, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(7, actual);
+    }
+    @Test
+    public void checkSulfuras(){
+        //Given
+        Item normalItem = new Item("Sulfuras", -1, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(80, actual);
+    }
+    @Test
+    public void checkeAgedBrie(){
+        //Given
+        Item normalItem = new Item("Aged Brie", -1, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(10, actual);
+    }
+    @Test
+    public void checkBackStagePassesDay20(){
+        //Given
+        Item normalItem = new Item("Backstage Pass", 20, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(10, actual);
     }
+    @Test
+    public void checkBackStagePassesDay10(){
+        //Given
+        Item normalItem = new Item("Backstage Pass", 10, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(11, actual);
+    }
+    @Test
+    public void checkBackStagePassesDay5(){
+        //Given
+        Item normalItem = new Item("Backstage Pass", 5, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(12, actual);
+    }
+    @Test
+    public void checkBackStagePassesDay0(){
+        //Given
+        Item normalItem = new Item("Backstage Pass", 0, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(0, actual);
+    }
+    @Test
+    public void checkConjured(){
+        //Given
+        Item normalItem = new Item("Conjured Item", 4, 9);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(7, actual);
+    }
+
+    @Test
+    public void checkMin(){
+        //Given
+        Item normalItem = new Item("Conjured Item", 4, 0);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(0, actual);
+    }
+    @Test
+    public void checkMax(){
+        //Given
+        Item normalItem = new Item("Backstage Pass", 4, 50);
+        Item[] itemList = new Item[1];
+        itemList[0] = normalItem;
+
+        Inventory testInventory = new Inventory(itemList);
+        testInventory.updateQuality();
+
+        int actual = itemList[0].getQuality();
+
+        Assert.assertEquals(50, actual);
+    }
+
 }