refactored code

src/main/java/com/zipcodewilmington/gildedrose/Inventory.java

@@ -11,52 +11,50 @@ public class Inventory {
 
 
     public void updateQuality() {
+        /*
+        loop through items.
+
+        1. if name DNE "Aged" && DNE "Backstage
+            a. if quality > 0
+                1. if name is NOT "Sulfuras",  subtract 1 quality | *
+        2. If name is either "Aged" or "Backstage"
+            a. if quality < 50, add 1 quality | **
+                1. if name is "Backstage"
+                    a. if getSellIn < 11
+                        1. if quality < 50, then add 1 quality | *
+                    b. if get sellIn < 6
+                        1. if quality < 50, then add 1 quality | *
+        1. if name DNE "Sulfuras"
+            a. subtract one sellIn | **
+
+        1. If getSellIn < 0
+            a. if name is NOT "Aged"
+                1. if name is NOT "Backstage"
+                    a. if quality > 0
+                        1. if name is NOT "Sulfuras, then subtract 1 quality (useless);
+                2. else set quality to 0;
+            b. else if quality < 50, add 1 quality
+         */
         for (int i = 0; i < items.length; i++) {
-            if (!items[i].getName().equals("Aged Brie")
-                    && !items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                if (items[i].getQuality() > 0) {
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                        items[i].setQuality(items[i].getQuality() - 1);
-                    }
-                }
-            } else {
+            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
                 if (items[i].getQuality() < 50) {
                     items[i].setQuality(items[i].getQuality() + 1);
-
-                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") {
+                    if (items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
                         if (items[i].getSellIn() < 11) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
+                            items[i].setQuality(items[i].getQuality() + 1);
                         }
-
                         if (items[i].getSellIn() < 6) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
+                            items[i].setQuality(items[i].getQuality() + 1);
                         }
                     }
                 }
-            }
 
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
                 items[i].setSellIn(items[i].getSellIn() - 1);
-            }
 
-            if (items[i].getSellIn() < 0) {
-                if (!items[i].getName().equals("Aged Brie")) {
-                    if (!items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].getQuality() > 0) {
-                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                                items[i].setQuality(items[i].getQuality() - 1);
-                            }
-                        }
-                    } else {
-                        items[i].setQuality(items[i].getQuality()
-                                - items[i].getQuality());
-                    }
-                } else {
-                    if (items[i].getQuality() < 50) {
+                if (items[i].getSellIn() < 0) {
+                    if (items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
+                        items[i].setQuality(0);
+                    } else if (items[i].getName().equals("Aged Brie") && items[i].getQuality() < 50) {
                         items[i].setQuality(items[i].getQuality() + 1);
                     }
                 }

src/test/java/com/zipcodewilmington/gildedrose/InventoryTest.java

@@ -4,9 +4,96 @@ import org.junit.Assert;
 import org.junit.Test;
 
 public class InventoryTest {
+    Item agedBrie = new Item("Aged Brie", 7,40);
+    Item backStage = new Item("Backstage passes to a TAFKAL80ETC concert", 10,20);
+    Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 4,15);
+    Item[] item = {agedBrie, backStage, sulfuras};
+
+    Inventory inv = new Inventory(item);
+
     @Test
     public void updateQuantityTest(){
-        Assert.assertEquals(1, 1);
+        inv.updateQuality();
+        int actual = agedBrie.getQuality();
+        int expected = 41;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest2(){
+        inv.updateQuality();
+        int actual = backStage.getQuality();
+        int expected = 22;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest3(){
+        backStage.setSellIn(4);
+        inv.updateQuality();
+        int actual = backStage.getQuality();
+        int expected = 23;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest4(){
+        inv.updateQuality();
+        int actual = sulfuras.getQuality();
+        int expected = 15;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest5(){
+        inv.updateQuality();
+        int actual = backStage.getSellIn();
+        int expected = 9;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest6(){
+        inv.updateQuality();
+        int actual = agedBrie.getSellIn();
+        int expected = 6;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest7(){
+        agedBrie.setSellIn(-1);
+        inv.updateQuality();
+        int actual = agedBrie.getQuality();
+        int expected = 42;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest8(){
+        backStage.setSellIn(-1);
+        inv.updateQuality();
+        int actual = backStage.getQuality();
+        int expected = 0;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest9(){
+        sulfuras.setSellIn(-1);
+        inv.updateQuality();
+        int actual = sulfuras.getQuality();
+        int expected = 15;
+        Assert.assertEquals(expected,actual);
+    }
+
+    @Test
+    public void updateQuantityTest10(){
+        sulfuras.setName("Aged Brie");
+        inv.updateQuality();
+        int actual = sulfuras.getQuality();
+        int expected = 16;
+        Assert.assertEquals(expected,actual);
     }
 }