new-item

src/main/java/com/zipcodewilmington/gildedrose/Inventory.java

@@ -12,55 +12,62 @@ public class Inventory {
 
     public void updateQuality() {
         for (int i = 0; i < items.length; i++) {
-            if (!items[i].getName().equals("Aged Brie")
-                    && !items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                if (items[i].getQuality() > 0) {
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                        items[i].setQuality(items[i].getQuality() - 1);
-                    }
+            if (items[i].getName().equals("Conjured")){
+                int temp = items[i].getQuality() == 1 ? 1 : 2;
+                items[i].setQuality(items[i].getQuality() - temp);
+            }
+            else{
+                if (items[i].getQuality() > 0 && !items[i].getName().matches("Aged Brie|Backstage passes to a TAFKAL80ETC concert|Sulfuras, Hand of Ragnaros")) {
+                    items[i].setQuality(items[i].getQuality() - 1);
+                } else {
+                    updateBasicORConcert(i);
                 }
-            } else {
-                if (items[i].getQuality() < 50) {
-                    items[i].setQuality(items[i].getQuality() + 1);
 
-                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") {
-                        if (items[i].getSellIn() < 11) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
-
-                        if (items[i].getSellIn() < 6) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
-                    }
+                if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
+                    items[i].setSellIn(items[i].getSellIn() - 1);
+                }
+                if (items[i].getSellIn() < 0) {
+                    sellInUnderZero(i);
                 }
             }
+        }//loop
+    }//updateQuality
 
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                items[i].setSellIn(items[i].getSellIn() - 1);
+    /**
+     * Helper method that will update any 'basic' item or a concert item
+     * @param i
+     */
+    private void updateBasicORConcert(int i){
+        if (items[i].getQuality() < 50) {
+            items[i].setQuality(items[i].getQuality() + 1);
+            if (items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert") && items[i].getQuality() < 50) {
+                if (items[i].getSellIn() < 11) {
+                    items[i].setQuality(items[i].getQuality() + 1);
+                }if (items[i].getSellIn() < 6) {
+                    items[i].setQuality(items[i].getQuality() + 1);
+                }
             }
+        }
+    }
 
-            if (items[i].getSellIn() < 0) {
-                if (!items[i].getName().equals("Aged Brie")) {
-                    if (!items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].getQuality() > 0) {
-                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                                items[i].setQuality(items[i].getQuality() - 1);
-                            }
-                        }
-                    } else {
-                        items[i].setQuality(items[i].getQuality()
-                                - items[i].getQuality());
-                    }
-                } else {
-                    if (items[i].getQuality() < 50) {
-                        items[i].setQuality(items[i].getQuality() + 1);
-                    }
-                }
+    /**
+     * Helper method to determine if Quality should be set to zero or incremented
+     * @param i
+     */
+    private void sellInUnderZero(int i){
+        if (!items[i].getName().equals("Aged Brie")) {
+            if (items[i].getQuality() > 0 && !items[i].getName().matches("Backstage passes to a TAFKAL80ETC concert|Sulfuras, Hand of Ragnaros")) {
+                items[i].setQuality(items[i].getQuality() - 1);
+            }
+            else {
+                items[i].setQuality(0);
             }
         }
+        else if (items[i].getQuality() < 50) {
+            items[i].setQuality(items[i].getQuality() + 1);
+        }
     }
-}
+}
+
+
+

src/main/java/com/zipcodewilmington/gildedrose/InventoryOriginal.java

@@ -0,0 +1,67 @@
+package com.zipcodewilmington.gildedrose;
+
+/*
+public class InventoryOriginal {
+    private Item[] items;
+
+    public InventoryOriginal(Item[] items) {
+        super();
+        this.items = items;
+    }
+
+
+    public void updateQuality() {
+        for (int i = 0; i < items.length; i++) {
+            if (!items[i].getName().equals("Aged Brie")
+                    && !items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
+                if (items[i].getQuality() > 0) {
+                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
+                        items[i].setQuality(items[i].getQuality() - 1);
+                    }
+                }
+            } else {
+                if (items[i].getQuality() < 50) {
+                    items[i].setQuality(items[i].getQuality() + 1);
+
+                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") {
+                        if (items[i].getSellIn() < 11) {
+                            if (items[i].getQuality() < 50) {
+                                items[i].setQuality(items[i].getQuality() + 1);
+                            }
+                        }
+
+                        if (items[i].getSellIn() < 6) {
+                            if (items[i].getQuality() < 50) {
+                                items[i].setQuality(items[i].getQuality() + 1);
+                            }
+                        }
+                    }
+                }
+            }
+
+            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
+                items[i].setSellIn(items[i].getSellIn() - 1);
+            }
+
+            if (items[i].getSellIn() < 0) {
+                if (!items[i].getName().equals("Aged Brie")) {
+                    if (!items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
+                        if (items[i].getQuality() > 0) {
+                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
+                                items[i].setQuality(items[i].getQuality() - 1);
+                            }
+                        }
+                    } else {
+                        items[i].setQuality(items[i].getQuality()
+                                - items[i].getQuality());
+                    }
+                } else {
+                    if (items[i].getQuality() < 50) {
+                        items[i].setQuality(items[i].getQuality() + 1);
+                    }
+                }
+            }
+        }
+    }
+}
+*/

src/test/java/com/zipcodewilmington/gildedrose/InventoryOriginalTest.java

@@ -0,0 +1,248 @@
+/*
+package com.zipcodewilmington.gildedrose;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class InventoryOriginalTest {
+    @Test
+    public void agedBrieTen(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", 10, 47);
+            Item[] basicItems = new Item[1];
+            basicItems[0] = agedBrie;
+            InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 48;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void agedBrieQuality50(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", 11, 50);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = agedBrie;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 50;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void agedBrieExpired(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", -1, 48);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = agedBrie;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 50;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void agedBrieExpiredMaxQuality(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", -1, 50);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = agedBrie;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 50;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+
+
+    @Test
+    public void stagePassQualityOne(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 11, 20);
+            Item[] basicItems = new Item[1];
+            basicItems[0] = stagePass;
+            InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 21;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void stagePassQualityTwo(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 10, 20);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = stagePass;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 22;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void stagePassQualityThree(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 5, 20);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = stagePass;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 23;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void stagePassQualityZero(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 0, 20);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = stagePass;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 0;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void sulfuras(){
+        //Given
+        Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 05, 80);
+            Item[] basicItems = new Item[1];
+            basicItems[0] = sulfuras;
+            InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 80;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = sulfuras.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void newItem(){
+        //Given
+        Item newItem = new Item("New Item", 05, 49);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = newItem;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 48;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = newItem.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void changeItemName(){
+        //Given
+        Item newItem = new Item("New Item", 02, 49);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = newItem;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        newItem.setName("Changed Name");
+        String expected = "Changed Name";
+        inventoryOriginal.updateQuality();
+
+        //When
+        String actual = newItem.getName();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void passedSellIn(){
+        //Given
+        Item newItem = new Item("Expired", -1, 10);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = newItem;
+        InventoryOriginal inventoryOriginal = new InventoryOriginal(basicItems);
+        int expected = 8;
+        inventoryOriginal.updateQuality();
+
+        //When
+        int actual = newItem.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+}
+
+
+
+
+
+
+
+First an introduction to our system:
+
+All items have
+    SellIn value
+        number of days we have to sell the item
+    Quality value
+        how valuable the item is
+    End of each day
+        lower both values for every item
+
+Quality of an item is never more than 50
+Sell by date has passed
+    Quality degrades twice as fast
+
+Quality
+    never negative
+
+"Aged Brie"
+    increases in Quality the older it gets
+"Sulfuras"
+    "Sulfuras" is a legendary item and as such its Quality is 80
+    never has to be sold or decreases in Quality
+"Backstage passes"
+    like aged brie, increases in Quality as it's SellIn value approaches;
+        Quality increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but Quality drops to 0 after the concert
+ */
+

src/test/java/com/zipcodewilmington/gildedrose/InventoryTest.java

@@ -5,8 +5,243 @@ import org.junit.Test;
 
 public class InventoryTest {
     @Test
-    public void updateQuantityTest(){
-        Assert.assertEquals(1, 1);
+    public void agedBrieTen(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", 10, 47);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = agedBrie;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 48;
+        inventory.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void agedBrieQuality50(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", 11, 50);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = agedBrie;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 50;
+        inventory.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void agedBrieExpired(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", -1, 48);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = agedBrie;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 50;
+        inventory.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void agedBrieExpiredMaxQuality(){
+        //Given
+        Item agedBrie = new Item("Aged Brie", -1, 50);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = agedBrie;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 50;
+        inventory.updateQuality();
+
+        //When
+        int actual = agedBrie.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+
+
+    @Test
+    public void stagePassQualityOne(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 11, 20);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = stagePass;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 21;
+        inventory.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void stagePassQualityTwo(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 10, 20);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = stagePass;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 22;
+        inventory.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void stagePassQualityThree(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 5, 20);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = stagePass;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 23;
+        inventory.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
     }
-}
 
+    @Test
+    public void stagePassQualityZero(){
+        //Given
+        Item stagePass = new Item("Backstage passes to a TAFKAL80ETC concert", 0, 20);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = stagePass;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 0;
+        inventory.updateQuality();
+
+        //When
+        int actual = stagePass.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void sulfuras(){
+        //Given
+        Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 05, 80);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = sulfuras;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 80;
+        inventory.updateQuality();
+
+        //When
+        int actual = sulfuras.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void newItem(){
+        //Given
+        Item newItem = new Item("New Item", 05, 49);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = newItem;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 48;
+        inventory.updateQuality();
+
+        //When
+        int actual = newItem.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void changeItemName(){
+        //Given
+        Item newItem = new Item("New Item", 02, 49);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = newItem;
+        Inventory inventory = new Inventory(basicItems);
+        newItem.setName("Changed Name");
+        String expected = "Changed Name";
+        inventory.updateQuality();
+
+        //When
+        String actual = newItem.getName();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void passedSellIn(){
+        //Given
+        Item newItem = new Item("Expired", -1, 10);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = newItem;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 8;
+        inventory.updateQuality();
+
+        //When
+        int actual = newItem.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void conjured(){
+        //Given
+        Item conjured = new Item("Conjured", 10, 25);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = conjured;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 23;
+        inventory.updateQuality();
+
+        //When
+        int actual = conjured.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void conjuredatOne(){
+        //Given
+        Item conjured = new Item("Conjured", 10, 1);
+        Item[] basicItems = new Item[1];
+        basicItems[0] = conjured;
+        Inventory inventory = new Inventory(basicItems);
+        int expected = 0;
+        inventory.updateQuality();
+
+        //When
+        int actual = conjured.getQuality();
+
+        //Then
+        Assert.assertEquals(expected, actual);
+    }
+}