GildedRoseKatagit add .

src/main/java/com/zipcodewilmington/gildedrose/Inventory.java

@@ -5,62 +5,118 @@ public class Inventory {
     private Item[] items;
 
     public Inventory(Item[] items) {
-        super();
         this.items = items;
     }
 
-
     public void updateQuality() {
-        for (int i = 0; i < items.length; i++) {
-            if (!items[i].getName().equals("Aged Brie")
-                    && !items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                if (items[i].getQuality() > 0) {
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                        items[i].setQuality(items[i].getQuality() - 1);
-                    }
-                }
-            } else {
-                if (items[i].getQuality() < 50) {
-                    items[i].setQuality(items[i].getQuality() + 1);
-
-                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") {
-                        if (items[i].getSellIn() < 11) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
-
-                        if (items[i].getSellIn() < 6) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
-                    }
-                }
+        for (Item item : items) {
+            ItemCategory category = categorize(item);
+            category.updateOneItem(item, this);
+        }
+    }
+
+    private ItemCategory categorize(Item item) {
+        if (item.getName().equals("Sulfuras, Hand of Ragnaros"))
+            return new Legendary();
+        if (item.getName().equals("Aged Brie"))
+            return new Cheese();
+        if (item.getName().equals("Backstage passes to a TAFKAL80ETC concert"))
+            return new BackstagePass();
+        if(item.getName().startsWith("Conjured"))
+            return new Conjured();
+        return new ItemCategory();
+    }
+
+    private boolean hasExpired(Item item) {
+        return item.getSellIn() < 0;
+    }
+
+
+    private class ItemCategory {
+        protected void incrementQuality(Item item) {
+            if (item.getQuality() < 50) {
+                item.setQuality(item.getQuality() + 1);
+            }
+        }
+
+        protected void decrementQuality(Item item) {
+            if (item.getQuality() > 0) {
+                item.setQuality(item.getQuality() - 1);
+            }
+        }
+
+        protected void updateExpired(Item item) {
+                decrementQuality(item);
+        }
+
+        protected void updateSellIn(Item item) {
+                item.setSellIn(item.getSellIn() - 1);
+
+        }
+
+        protected void updateQuality(Item item) {
+            decrementQuality(item);
+        }
+
+        protected void updateOneItem(Item item, Inventory inventory) {
+            updateQuality(item);
+
+            updateSellIn(item);
+
+            if (inventory.hasExpired(item)) {
+                updateExpired(item);
             }
+        }
+    }
+
+    private class Legendary extends ItemCategory {
+        protected void updateExpired(Item item) {}
+
+        protected void updateSellIn(Item item) {}
+
+        protected void updateQuality(Item item) {}
+    }
+
+    private class Cheese extends ItemCategory {
+        protected void updateExpired(Item item) {
+                incrementQuality(item);
+        }
 
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                items[i].setSellIn(items[i].getSellIn() - 1);
+        protected void updateQuality(Item item) {
+                incrementQuality(item);
+
+        }
+    }
+
+    private class BackstagePass extends ItemCategory {
+        protected void updateExpired(Item item) {
+            item.setQuality(0);
+        }
+
+        protected void updateQuality(Item item) {
+            incrementQuality(item);
+
+            if (item.getSellIn() < 11) {
+                incrementQuality(item);
             }
 
-            if (items[i].getSellIn() < 0) {
-                if (!items[i].getName().equals("Aged Brie")) {
-                    if (!items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].getQuality() > 0) {
-                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                                items[i].setQuality(items[i].getQuality() - 1);
-                            }
-                        }
-                    } else {
-                        items[i].setQuality(items[i].getQuality()
-                                - items[i].getQuality());
-                    }
-                } else {
-                    if (items[i].getQuality() < 50) {
-                        items[i].setQuality(items[i].getQuality() + 1);
-                    }
-                }
+            if (item.getSellIn() < 6) {
+                incrementQuality(item);
             }
+
         }
     }
+
+    private class Conjured extends ItemCategory {
+        protected void updateExpired(Item item) {
+            decrementQuality(item);
+            decrementQuality(item);
+        }
+
+        protected void updateQuality(Item item) {
+            decrementQuality(item);
+            decrementQuality(item);
+        }
+
+    }
 }

src/test/java/com/zipcodewilmington/gildedrose/InventoryTest.java

@@ -2,11 +2,76 @@ package com.zipcodewilmington.gildedrose;
 
 import org.junit.Assert;
 import org.junit.Test;
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
+
+import static org.junit.Assert.assertEquals;
+
 
 public class InventoryTest {
+
+    final String expected = "OMGHAI!\n" +
+            "---------day 0 --------\n" +
+            "name, sellIn, quality\n" +
+            "+5 Dexterity Vest, 10, 20\n" +
+            "Aged Brie, 2, 0\n" +
+            "Elixir of the Mangoose, 5, 7 \n" +
+            "Sulfuras, Hand of Ragnaros, 0, 80\n" +
+            "Sulfuras, Hand of Ragnaros -1, 80\n" +
+            "Backstage passes to a TAFKAL80ETC concert, 15, 20\n" +
+            "Backstage passes to a TAFKAL80ETC concert, 10, 49\n" +
+            "Backstage passes to a TAFKAL80ETC concert, 5, 49\n" +
+            "Conjured Mana Cake, 3, 4\n" +
+            "\n" +
+            "----------day 1 ---------\n" +
+            "name, sellIn, quality\n" +
+            "+5 Dexterity Vest, 9, 19\n" +
+            "Aged Brie, 1, 1\n" +
+            "Elixir of the Mongoose, 4, 6\n" +
+            "Sulfuras, Hand of Ragnaros,0, 80\n " +
+            "Sulfuras, Hand of Ragnaros, -1, 80\n" +
+            "Backstage passes to a TAFKAL80ETC concert, 14, 21\n" +
+            "Backstage passes to a TAFKAL80ETC concert, 9, 50\n" +
+            "Backstage passes to a TAFKAL80ETC concert, 4, 50\n" +
+            "Conjured Mana Cake, 2, 6\n" +
+            "\n";
+
     @Test
-    public void updateQuantityTest(){
-        Assert.assertEquals(1, 1);
+    public void gildedRose() {
+        ByteArrayOutputStream output = new ByteArrayOutputStream();
+        PrintStream out = new PrintStream(output);
+
+        out.println("OMGHAI!");
+
+        Item[] items = new Item[]{
+                new Item("+5 Dexterity Vest", 10, 20), //
+                new Item("Aged Brie", 2, 0), //
+                new Item("Elixir of the Mongoose", 5, 7), //
+                new Item("Sulfuras, Hand of Ragnaros", 0, 80), //
+                new Item("Sulfuras, Hand of Ragnaros", -1, 80), //
+                new Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
+                new Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
+                new Item("Backstage passes to a TAFKAL80ETC concert", 5, 49),
+                // this conjured item does not work properly yet
+                new Item("Conjured Mana Cake", 3, 6)};
+
+        Inventory app = new Inventory(items);
+
+        int days = 2;
+
+        for (int i = 0; i < days; i++) {
+            out.println(" --------- day " + i + " ---------- ");
+            out.println("name, sellIn, quality");
+            for (Item item : items) {
+                out.println(item);
+            }
+            out.println();
+            app.updateQuality();
+        }
+
+//        System.out.println(output.toString());
+//        Assert.assertEquals(expected, output.toString());
     }
 }
 
+

src/test/java/com/zipcodewilmington/gildedrose/ItemTest.java

@@ -0,0 +1 @@
+package com.zipcodewilmington.gildedrose;
import com.zipcodewilmington.gildedrose.Item;
import org.junit.Test;
import static org.junit.Assert.assertEquals;

public class ItemTest {
    @Test
    public void testGetName() {

        Item name = new Item("Chai", 1,1);
        String expected = "Chai";
        String actual = name.getName();
        assertEquals(expected, actual);
    }

    @Test
    public void testSetName() {

        Item myName=new Item("Chai",1,1);
        String expected = "Chaitali";
         myName.setName("Chaitali");
        assertEquals(expected, myName.getName());
    }

    @Test
    public void getSellIn() {

        Item sellIn = new Item("Chai",1,1);
        int expected = 1;
        int actual = sellIn.getSellIn();
        assertEquals(expected, actual);
    }

    @Test
    public void setSellIn() {

        Item chai = new Item("Chai",1,1);
        int expected = 2;
        chai.setSellIn(2);
        int actual = chai.getSellIn();
        assertEquals(expected, actual);
    }

    @Test
    public void getQuality() {

        Item quant = new Item("Chai",1,1);
        int expected = 1;
        int actual = quant.getQuality();
        assertEquals(expected, actual);
    }

    @Test
    public void setQuality() {

        Item setquant = new Item("Chai",1,1);
        int expected = 4;
        setquant.setQuality(4);
        int actual = setquant.getQuality();
        assertEquals(expected, actual);
    }
}