Product Manager

src/main/java/com/zipcodewilmington/gildedrose/Inventory.java

 
 public class Inventory {
     private Item[] items;
+    private int maxQuality = 50;
+    private int legendaryQuality = 80;
 
     public Inventory(Item[] items) {
         super();
     }
 
 
-    public void updateQuality() {
-        for (int i = 0; i < items.length; i++) {
-            if (!items[i].getName().equals("Aged Brie")
-                    && !items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                if (items[i].getQuality() > 0) {
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                        items[i].setQuality(items[i].getQuality() - 1);
-                    }
-                }
-            } else {
-                if (items[i].getQuality() < 50) {
-                    items[i].setQuality(items[i].getQuality() + 1);
 
-                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") {
-                        if (items[i].getSellIn() < 11) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
+    //insert method to set this.items = adjustItems(this.items)
 
-                        if (items[i].getSellIn() < 6) {
-                            if (items[i].getQuality() < 50) {
-                                items[i].setQuality(items[i].getQuality() + 1);
-                            }
-                        }
-                    }
-                }
+    public Item[] adjustItems(Item[] items) {
+        for (Item item : items) {
+            if (item.getName().equals("Sulfuras, Hand of Ragnaros")) {
+                item = sulfurasHandler(item);
+            } else if (item.getName().equals("Aged Brie")) {
+                item = agedBrieHandler(item);
+            } else if (item.getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
+                item = backstagePassHandler(item);
             }
+        }
+        return items;
+    }
 
-            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                items[i].setSellIn(items[i].getSellIn() - 1);
-            }
+    public Item sulfurasHandler(Item legendaryItem) {
+        legendaryItem.setQuality(legendaryQuality);
+        return legendaryItem;
+    }
 
-            if (items[i].getSellIn() < 0) {
-                if (!items[i].getName().equals("Aged Brie")) {
-                    if (!items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].getQuality() > 0) {
-                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
-                                items[i].setQuality(items[i].getQuality() - 1);
-                            }
-                        }
-                    } else {
-                        items[i].setQuality(items[i].getQuality()
-                                - items[i].getQuality());
-                    }
-                } else {
-                    if (items[i].getQuality() < 50) {
-                        items[i].setQuality(items[i].getQuality() + 1);
-                    }
-                }
-            }
+    public Item agedBrieHandler(Item item) {
+        int x = 1;
+        int quality = item.getQuality();
+        if (isMaxQuality(quality) && !itemIsExpired(item)) {
+            return item;
+        } else if (itemIsExpired(item)) {
+            x = -2;
+        }
+        adjustItemQuality(item, x);
+        adjustItemSellIn(item);
+        return item;
+    }
+
+    public Item backstagePassHandler(Item item) {
+        int x = 0;
+        int sellIn = item.getSellIn();
+        if (isMaxQuality(item.getQuality()) && !itemIsExpired(item)) return item;
+        else if (sellIn >= 10) {
+            x = 1;
+        } else if (sellIn >= 5) {
+            x = 2;
+        } else if (sellIn > 0) {
+            x = 3;
+        } else {
+            x = item.getQuality() * -1;
+        }
+        adjustItemQuality(item, x);
+        adjustItemSellIn(item);
+        return item;
+    }
+
+    public boolean isMaxQuality(int n) {
+
+        return n == maxQuality;
+    }
+
+    public boolean itemIsExpired(Item i) {
+        return i.getSellIn() <= 0;
+    }
+
+    public void adjustItemQuality(Item i, Integer n) {
+        int q = i.getQuality();
+        int result = q + n;
+        if (result < 0) {
+            i.setQuality(0);
+        } else if (result <= maxQuality) {
+            i.setQuality(result);
+        }  else {
+            i.setQuality(maxQuality);
         }
     }
+
+    public void adjustItemSellIn(Item i) {
+        i.setSellIn(i.getSellIn() - 1);
+    }
 }

src/test/java/com/zipcodewilmington/gildedrose/InventoryTest.java

 import org.junit.Test;
 
 public class InventoryTest {
+
     @Test
-    public void updateQuantityTest(){
-        Assert.assertEquals(1, 1);
+    public void testAdjustItem(){
+        Item agedBrie = new Item("Aged Brie", 10, 30);
+        Item backstagePasses = new Item("Backstage passes to a TAFKAL80ETC concert", 10, 30);
+        Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 10, 80);
+        Item[] expected = {agedBrie, backstagePasses, sulfuras};
+
+        Item[] actual = expected;
+
+
+
+        Assert.assertEquals(expected, actual);
     }
+
+
+    @Test
+    public void testSulfurasHandler() {
+        Item agedBrie = new Item("Aged Brie", 10, 30);
+        Item backstagePasses = new Item("Backstage passes to a TAFKAL80ETC concert", 10, 30);
+        Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 10, 80);
+        Item[] item = {agedBrie, backstagePasses, sulfuras};
+        Inventory inv = new Inventory(item);
+        int before = sulfuras.getQuality();
+        int expected = before;
+
+        int actual = before;
+
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void testAgedBrieHandler() {
+        // given
+        Item agedBrie = new Item("Aged Brie", 10, 30);
+        Item backstagePasses = new Item("Backstage passes to a TAFKAL80ETC concert", 10, 30);
+        Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 10, 80);
+        Item[] item = {agedBrie, backstagePasses, sulfuras};
+        Inventory inv = new Inventory(item);
+        int expected = agedBrie.getQuality() + 1;
+
+        // when
+        inv.adjustItemQuality(agedBrie, 1);
+        int actual= agedBrie.getQuality();
+
+
+        //then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void testBackstagePassesHandler(){
+        // given
+        Item agedBrie = new Item("Aged Brie", 10, 30);
+        Item backstagePasses = new Item("Backstage passes to a TAFKAL80ETC concert", 10, 30);
+        Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 10, 80);
+        Item[] item = {agedBrie, backstagePasses, sulfuras};
+        Inventory inv = new Inventory(item);
+        int expected = backstagePasses.getQuality() + 2;
+
+        //when
+        inv.adjustItemQuality(backstagePasses, 2);
+        int actual = backstagePasses.getQuality();
+
+        //then
+        Assert.assertEquals(expected, actual);
+    }
+
+    @Test
+    public void testIsMaxQuality(){
+        //given
+        Item agedBrie = new Item("Aged Brie", 10, 50);
+        Item backstagePasses = new Item("Backstage passes to a TAFKAL80ETC concert", 10, 50);
+        Item[] item = {agedBrie, backstagePasses};
+        Inventory inv = new Inventory(item);
+
+
+        Assert.assertTrue(inv.isMaxQuality(50));
+    }
+
+    @Test
+    public void testItemisExpired(){
+        Item agedBrie = new Item("Aged Brie", 0, 50);
+        Item backstagePasses = new Item("Backstage passes to a TAFKAL80ETC concert", 0, 50);
+        Item[] item = {agedBrie, backstagePasses};
+        Inventory inv = new Inventory(item);
+
+        Assert.assertTrue(inv.itemIsExpired(agedBrie));
+    }
+
+    @Test
+    public void testAdjustItemSellIn(){
+        Item agedBrie = new Item("Aged Brie", 1, 50);
+        Item backstagePasses = new Item("Backstage passes to a TAFKAL80ETC concert", 1, 50);
+        Item sulfuras = new Item("Sulfuras, Hand of Ragnaros", 1, 80);
+        Item[] item = {agedBrie, backstagePasses, sulfuras};
+        Inventory inv = new Inventory(item);
+
+        inv.adjustItemSellIn(agedBrie);
+
+        Assert.assertTrue(inv.itemIsExpired(agedBrie));
+    }
+
 }