100% coverage

arraz/src/main/java/Arraz.java

@@ -78,12 +78,9 @@ public class Arraz<T> {
 
     public T[] createEmptyGenericArray(T[] array, int length) {
         Class cl = array.getClass();
-        if (!cl.isArray()) {
-            return null;
-        } else {
-            T[] copy = (T[]) Array.newInstance(cl.getComponentType(), length);
-            return copy;
-        }
+        T[] copy = (T[]) Array.newInstance(cl.getComponentType(), length);
+
+        return copy;
     }
 
     public T[] copyArrayByIterator(T[] array) {
@@ -249,14 +246,14 @@ public class Arraz<T> {
         return newArray;
     }
 
-    public boolean check2ArraysForEquals(T[] array1, T[] array2){
+    public boolean check2ArraysForEquals(T[] array1, T[] array2) {
         if (Arrays.equals(array1, array2)) {
             return true;
         }
         return false;
     }
 
-    public double averageArrayWithoutMaxMin(int[] array){
+    public double averageArrayWithoutMaxMin(int[] array) {
         double sum = 0;
         int dupes = 0;
 
@@ -271,7 +268,7 @@ public class Arraz<T> {
         return sum / (array.length - dupes);
     }
 
-    public boolean arrayHas65And77(int[] array){
+    public boolean arrayHas65And77(int[] array) {
         if (containsValue(array, 65) && containsValue(array, 77)) {
             return true;
         }
@@ -279,7 +276,7 @@ public class Arraz<T> {
         return false;
     }
 
-    public boolean theTotalofTensIs30(int[] array){
+    public boolean theTotalofTensIs30(int[] array) {
         int sum = 0;
 
         for (int integer : array) {
@@ -296,19 +293,19 @@ public class Arraz<T> {
     }
 
 
-    public int findSmallestOfArray(int[] array){
+    public int findSmallestOfArray(int[] array) {
         return findMin(array);
     }
 
-    public int findSecondSmallestOfArray(int[] array){
+    public int findSecondSmallestOfArray(int[] array) {
         int indexOfSmallest = findIndexOf(array, findSmallestOfArray(array));
         array[indexOfSmallest] = findMax(array);
 
         return findMin(array);
     }
 
-    public int[] makeMeACopyPlease(int[] array){
-       return reverseArray(array);
+    public int[] makeMeACopyPlease(int[] array) {
+        return reverseArray(array);
     }
 
     public T[] removeFromIndex(T[] array, int index) {
@@ -348,21 +345,20 @@ public class Arraz<T> {
         return newArray;
     }
 
-    public List[] sortArrayIntoEvensThenOdds(int[] array){
-        List[] evensThenOdds = new ArrayList[2];
-        List<Integer> evens = new ArrayList<>();
-        List<Integer> odds = new ArrayList<>();
+    public ArrayList<Integer> sortArrayIntoEvensThenOdds(int[] array) {
+        ArrayList<Integer> arrayList = new ArrayList<>();
+        int indexOfEvens = 0;
 
-        for (int integer : array) {
-            if (integer % 2 == 0) {
-                evens.add(integer);
+        for (int integer: array) {
+            if (integer % 2 ==0) {
+                arrayList.add(indexOfEvens, integer);
+                indexOfEvens++;
             } else {
-                odds.add(integer);
+                arrayList.add(integer);
             }
         }
 
-        evensThenOdds[0] = evens; evensThenOdds[1] = odds;
-        return evensThenOdds;
+        return arrayList;
     }
 
 }

arraz/src/test/java/ArrazTest.java

@@ -3,7 +3,6 @@ import org.junit.Before;
 import org.junit.Test;
 
 import java.util.ArrayList;
-import java.util.List;
 
 public class ArrazTest {
 
@@ -404,7 +403,8 @@ public class ArrazTest {
         original.add(92);
 
         Integer[] expected = new Integer[]{6, 20, 92};
-        Integer[] actual = (Integer[]) arraz.makeMeAnArrayFromArrayList(original, new Integer[0]);
+        Integer[] actual = new Integer[original.size()];
+        actual = (Integer[]) arraz.makeMeAnArrayFromArrayList(original, actual);
 
         Assert.assertEquals(expected, actual);
     }
@@ -416,7 +416,8 @@ public class ArrazTest {
         original.add("goodbye");
 
         String[] expected = new String[]{"hello", "goodbye"};
-        String[] actual = (String[]) arraz.makeMeAnArrayFromArrayList(original, new String[0]);
+        String[] actual = new String[original.size()];
+        actual = (String[]) arraz.makeMeAnArrayFromArrayList(original, new String[0]);
 
         Assert.assertEquals(expected, actual);
     }
@@ -652,26 +653,18 @@ public class ArrazTest {
     public void sortArrayIntoEvensThenOdds1() {
         int[] spiffyHandyIntArray = new int[] {4, 5, 102, 6, -7, 12, -32, 92, 8};
 
-        List<Integer> evens = new ArrayList<>();
-        evens.add(4); evens.add(102); evens.add(6); evens.add(12); evens.add(-32); evens.add(92); evens.add(8);
-        List<Integer> odds = new ArrayList<>();
-        odds.add(5); odds.add(-7);
-
-        List[] expected = new List[] {evens, odds};
-        List[] actual = arraz.sortArrayIntoEvensThenOdds(spiffyHandyIntArray);
+        ArrayList<Integer> expected = new ArrayList<>();
+        expected.add(4); expected.add(102); expected.add(6); expected.add(12); expected.add(-32); expected.add(92); expected.add(8); expected.add(5); expected.add(-7);
+        ArrayList<Integer> actual = arraz.sortArrayIntoEvensThenOdds(spiffyHandyIntArray);
 
         Assert.assertEquals(expected, actual);
     }
 
     @Test
     public void sortArrayIntoEvensThenOdds2() {
-        List<Integer> evens = new ArrayList<>();
-        evens.add(2); evens.add(4);
-        List<Integer> odds = new ArrayList<>();
-        odds.add(1); odds.add(3); odds.add(5);
-
-        List[] expected = new List[] {evens, odds};
-        List[] actual = arraz.sortArrayIntoEvensThenOdds(intArray);
+        ArrayList<Integer> expected = new ArrayList<>();
+        expected.add(2); expected.add(4); expected.add(1); expected.add(3); expected.add(5);
+        ArrayList<Integer> actual = arraz.sortArrayIntoEvensThenOdds(intArray);
 
         Assert.assertEquals(expected, actual);
     }