Verify poll exists before put, add tests

src/main/java/io/zipcoder/tc_spring_poll_application/controllers/PollController.java

@@ -70,10 +70,7 @@ public class PollController {
 
     @RequestMapping(value = "/polls/{pollId}", method = RequestMethod.PUT)
     public ResponseEntity<Poll> updatePoll(@RequestBody Poll poll, @PathVariable Long pollId) {
-        //TODO: check ids
-        //if (pollId != poll.getId())
-        //return BAD_REQUEST
-
+        verifyPoll(pollId);
         return new ResponseEntity<>(pollRepository.save(poll), HttpStatus.OK);
     }
 

src/test/java/io/zipcoder/tc_spring_poll_application/controllers/PollControllerTest.java

@@ -38,6 +38,8 @@ public class PollControllerTest {
     private PollRepository pollRepo;
 
     private List<Poll> polls = new ArrayList<>();
+    private Long exists = 10L;
+    private Long dne = 999L;
 
     @Before
     public void setup() {
@@ -114,14 +116,22 @@ public class PollControllerTest {
     }
 
     @Test
-    public void updatesPoll() {
+    public void updatesPollExists() {
         HttpStatus expected = HttpStatus.OK;
-        HttpStatus actual = pollCtrl.updatePoll(mock(Poll.class), anyLong()).getStatusCode();
+        HttpStatus actual = pollCtrl.updatePoll(mock(Poll.class), exists).getStatusCode();
 
         verify(pollRepo).save(any(Poll.class));
         assertEquals(expected, actual);
     }
 
+    @Test(expected = ResourceNotFoundException.class)
+    public void updatePollFails404() {
+        HttpStatus expected = HttpStatus.OK;
+        HttpStatus actual = pollCtrl.updatePoll(mock(Poll.class), dne).getStatusCode();
+
+        verify(pollRepo).save(any(Poll.class));
+    }
+
     @Test
     public void deletePoll() {
         HttpStatus expected = HttpStatus.OK;
@@ -134,7 +144,6 @@ public class PollControllerTest {
     @Test
     public void testVerifyPoll() {
 
-        Long exists = 10L;
 
         try {
             pollCtrl.verifyPoll(exists);
@@ -145,6 +154,6 @@ public class PollControllerTest {
 
     @Test(expected = ResourceNotFoundException.class)
     public void testVerifyPollNotFound() {
-        pollCtrl.verifyPoll(999L);
+        pollCtrl.verifyPoll(dne);
     }
 }