Add error messages/handling

src/main/java/io/zipcoder/tc_spring_poll_application/error/ErrorDetail.java

@@ -1,5 +1,8 @@
 package io.zipcoder.tc_spring_poll_application.error;
 
+import java.util.List;
+import java.util.Map;
+
 /**
  * project: spring-demo
  * package: io.zipcoder.tc_spring_poll_application.error
@@ -13,6 +16,16 @@ public class ErrorDetail {
     long timestamp;
     String developerMessage;
 
+    public Map<String, List<ValidationError>> getErrors() {
+        return errors;
+    }
+
+    public void setErrors(Map<String, List<ValidationError>> errors) {
+        this.errors = errors;
+    }
+
+    Map<String, List<ValidationError>> errors;
+
     public String getTitle() {
         return title;
     }

src/main/java/io/zipcoder/tc_spring_poll_application/error/RestExceptionHandler.java

@@ -1,32 +0,0 @@
-package io.zipcoder.tc_spring_poll_application.error;
-
-import io.zipcoder.tc_spring_poll_application.exception.ResourceNotFoundException;
-import org.springframework.http.HttpStatus;
-import org.springframework.http.ResponseEntity;
-import org.springframework.web.bind.annotation.ControllerAdvice;
-import org.springframework.web.bind.annotation.ExceptionHandler;
-
-import javax.servlet.http.HttpServletRequest;
-import java.util.Arrays;
-import java.util.Date;
-
-/**
- * project: spring-demo
- * package: io.zipcoder.tc_spring_poll_application.error
- * author: https://github.com/vvmk
- * date: 4/7/18
- */
-@ControllerAdvice
-public class RestExceptionHandler {
-    @ExceptionHandler(ResourceNotFoundException.class)
-    public ResponseEntity<?> handleResourceNotFoundException(ResourceNotFoundException rnfe,
-                                                             HttpServletRequest request) {
-        ErrorDetail err = new ErrorDetail();
-        err.setTimestamp(new Date().getTime());
-        err.setStatus(HttpStatus.NOT_FOUND.value());
-        err.setDetail(rnfe.getMessage());
-        err.setDeveloperMessage(Arrays.toString(rnfe.getStackTrace()));
-        err.setTitle(rnfe.getClass().toString());
-        return new ResponseEntity<>(err, HttpStatus.NOT_FOUND);
-    }
-}

src/main/java/io/zipcoder/tc_spring_poll_application/error/ValidationError.java

@@ -0,0 +1,28 @@
+package io.zipcoder.tc_spring_poll_application.error;
+
+/**
+ * project: spring-demo
+ * package: io.zipcoder.tc_spring_poll_application.error
+ * author: https://github.com/vvmk
+ * date: 4/7/18
+ */
+public class ValidationError {
+    public String getCode() {
+        return code;
+    }
+
+    public void setCode(String code) {
+        this.code = code;
+    }
+
+    public String getMessage() {
+        return message;
+    }
+
+    public void setMessage(String message) {
+        this.message = message;
+    }
+
+    String code;
+    String message;
+}

src/main/java/io/zipcoder/tc_spring_poll_application/exception/RestExceptionHandler.java

@@ -0,0 +1,67 @@
+package io.zipcoder.tc_spring_poll_application.exception;
+
+import io.zipcoder.tc_spring_poll_application.error.ErrorDetail;
+import io.zipcoder.tc_spring_poll_application.error.ValidationError;
+import io.zipcoder.tc_spring_poll_application.exception.ResourceNotFoundException;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.MessageSource;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.validation.FieldError;
+import org.springframework.web.bind.MethodArgumentNotValidException;
+import org.springframework.web.bind.annotation.ControllerAdvice;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+
+import javax.servlet.http.HttpServletRequest;
+import java.util.*;
+
+/**
+ * project: spring-demo
+ * package: io.zipcoder.tc_spring_poll_application.error
+ * author: https://github.com/vvmk
+ * date: 4/7/18
+ */
+@ControllerAdvice
+public class RestExceptionHandler {
+    private MessageSource messageSource;
+
+    @Autowired
+    public RestExceptionHandler(MessageSource messageSource) {
+        this.messageSource = messageSource;
+    }
+
+    @ExceptionHandler(ResourceNotFoundException.class)
+    public ResponseEntity<?> handleResourceNotFoundException(ResourceNotFoundException rnfe,
+                                                             HttpServletRequest request) {
+        ErrorDetail err = new ErrorDetail();
+        err.setTimestamp(new Date().getTime());
+        err.setStatus(HttpStatus.NOT_FOUND.value());
+        err.setDetail(rnfe.getMessage());
+        err.setDeveloperMessage(Arrays.toString(rnfe.getStackTrace()));
+        err.setTitle(rnfe.getClass().toString());
+        return new ResponseEntity<>(err, HttpStatus.NOT_FOUND);
+    }
+
+    @ExceptionHandler(MethodArgumentNotValidException.class)
+    public ResponseEntity<?>
+    handleValidationError(MethodArgumentNotValidException manve, HttpServletRequest request) {
+
+        ErrorDetail errorDetail = new ErrorDetail();
+
+        List<FieldError> fieldErrors =  manve.getBindingResult().getFieldErrors();
+        for(FieldError fe : fieldErrors) {
+
+            List<ValidationError> validationErrorList = errorDetail.getErrors().get(fe.getField());
+            if(validationErrorList == null) {
+                validationErrorList = new ArrayList<>();
+                errorDetail.getErrors().put(fe.getField(), validationErrorList);
+            }
+            ValidationError validationError = new ValidationError();
+            validationError.setCode(fe.getCode());
+            validationError.setMessage(messageSource.getMessage(fe, Locale.JAPANESE));
+            validationErrorList.add(validationError);
+        }
+
+        return new ResponseEntity<>(errorDetail, HttpStatus.BAD_REQUEST);
+    }
+}

src/main/resources/messages.properties

@@ -0,0 +1,2 @@
+NotEmpty.poll.question=Question is a required field
+Size.poll.options=Options must be greater than {1} and less than {0}