Explorar el Código

Cleaned up all tests pass

Allison Ziegler hace 8 años
padre
commit
c4de47e036
Se han modificado 2 ficheros con 60 adiciones y 57 borrados
  1. 49
    46
      Inventory.java
  2. 11
    11
      package.bluej

+ 49
- 46
Inventory.java Ver fichero

@@ -10,55 +10,58 @@ public class Inventory {
10 10
 
11 11
     public void updateQuality() {
12 12
         for (int i = 0; i < items.length; i++) {
13
-            if (!items[i].getName().equals("Aged Brie")
14
-                    && !items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
15
-                if (items[i].getQuality() > 0) {
16
-                    if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
17
-                        items[i].setQuality(items[i].getQuality() - 1);
18
-                    }
19
-                }
20
-            } else {
21
-                if (items[i].getQuality() < 50) {
22
-                    items[i].setQuality(items[i].getQuality() + 1);
23
-
24
-                    if (items[i].getName() == "Backstage passes to a TAFKAL80ETC concert") {
25
-                        if (items[i].getSellIn() < 11) {
26
-                            if (items[i].getQuality() < 50) {
27
-                                items[i].setQuality(items[i].getQuality() + 1);
28
-                            }
29
-                        }
30
-
31
-                        if (items[i].getSellIn() < 6) {
32
-                            if (items[i].getQuality() < 50) {
33
-                                items[i].setQuality(items[i].getQuality() + 1);
34
-                            }
35
-                        }
36
-                    }
37
-                }
38
-            }
39
-
40 13
             if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
14
+                switch (items[i].getName()) {
15
+                    case "Backstage passes to a TAFKAL80ETC concert" :
16
+                        updateTickets(items[i]);
17
+                        break;
18
+                    case "Aged Brie" :
19
+                        updateBrie(items[i]);
20
+                        break;
21
+                    default : 
22
+                        updateNormalItem(items[i]);
23
+                        break;
24
+                }
41 25
                 items[i].setSellIn(items[i].getSellIn() - 1);
42 26
             }
43
-
44
-            if (items[i].getSellIn() < 0) {
45
-                if (!items[i].getName().equals("Aged Brie")) {
46
-                    if (!items[i].getName().equals("Backstage passes to a TAFKAL80ETC concert")) {
47
-                        if (items[i].getQuality() > 0) {
48
-                            if (!items[i].getName().equals("Sulfuras, Hand of Ragnaros")) {
49
-                                items[i].setQuality(items[i].getQuality() - 1);
50
-                            }
51
-                        }
52
-                    } else {
53
-                        items[i].setQuality(items[i].getQuality()
54
-                                - items[i].getQuality());
55
-                    }
56
-                } else {
57
-                    if (items[i].getQuality() < 50) {
58
-                        items[i].setQuality(items[i].getQuality() + 1);
59
-                    }
60
-                }
27
+        }
28
+    }
29
+    
30
+    public void updateTickets(Item ticket) {
31
+        if (ticket.getSellIn() < 0) {
32
+            ticket.setQuality(0);
33
+        }
34
+        else if (ticket.getQuality() >= 48) {
35
+            ticket.setQuality(50);
36
+        }
37
+        else {
38
+            if (ticket.getSellIn() >= 11) {
39
+                ticket.setQuality(ticket.getQuality() + 1);
40
+            }
41
+            if (ticket.getSellIn() >= 6 && ticket.getSellIn() < 11) {
42
+                ticket.setQuality(ticket.getQuality() + 2);
43
+            }
44
+            else if (ticket.getSellIn() < 6) {
45
+                ticket.setQuality(ticket.getQuality() + 3);
61 46
             }
62 47
         }
63
-}
48
+    }
49
+    
50
+    public void updateBrie(Item brie) {
51
+        if (brie.getSellIn() > 0 && brie.getQuality() < 50) {
52
+            brie.setQuality(brie.getQuality() + 1);
53
+        }
54
+        else if (brie.getSellIn() < 0) {
55
+            brie.setQuality(brie.getQuality() + 2);
56
+        }
57
+    }
58
+    
59
+    public void updateNormalItem(Item item) {
60
+        if (item.getQuality() > 0) {
61
+            item.setQuality(item.getQuality() - 1);
62
+        }
63
+        if (item.getSellIn() < 0) {
64
+            item.setQuality(item.getQuality() - 1);
65
+        }
66
+    }
64 67
 }

+ 11
- 11
package.bluej Ver fichero

@@ -5,18 +5,18 @@ dependency1.type=UsesDependency
5 5
 dependency2.from=InventoryTest
6 6
 dependency2.to=Inventory
7 7
 dependency2.type=UsesDependency
8
-editor.fx.0.height=722
9
-editor.fx.0.width=800
10
-editor.fx.0.x=320
11
-editor.fx.0.y=50
8
+editor.fx.0.height=717
9
+editor.fx.0.width=1280
10
+editor.fx.0.x=0
11
+editor.fx.0.y=23
12 12
 objectbench.height=164
13
-objectbench.width=776
13
+objectbench.width=461
14 14
 package.divider.horizontal=0.6
15 15
 package.divider.vertical=0.6845018450184502
16 16
 package.editor.height=364
17 17
 package.editor.width=674
18
-package.editor.x=577
19
-package.editor.y=61
18
+package.editor.x=79
19
+package.editor.y=50
20 20
 package.frame.height=600
21 21
 package.frame.width=800
22 22
 package.numDependencies=2
@@ -34,14 +34,14 @@ target1.name=Item
34 34
 target1.showInterface=false
35 35
 target1.type=ClassTarget
36 36
 target1.width=80
37
-target1.x=10
38
-target1.y=100
37
+target1.x=40
38
+target1.y=110
39 39
 target2.height=50
40 40
 target2.name=InventoryTest
41 41
 target2.showInterface=false
42 42
 target2.type=UnitTestTargetJunit4
43 43
 target2.width=80
44
-target2.x=40
44
+target2.x=220
45 45
 target2.y=160
46 46
 target3.association=InventoryTest
47 47
 target3.height=50
@@ -49,5 +49,5 @@ target3.name=Inventory
49 49
 target3.showInterface=false
50 50
 target3.type=ClassTarget
51 51
 target3.width=80
52
-target3.x=10
52
+target3.x=190
53 53
 target3.y=190